From: Ondrej Jirman <megous@megous.com> To: "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel@ffwll.ch>, "Thierry Reding" <thierry.reding@gmail.com>, "Sam Ravnborg" <sam@ravnborg.org>, "Fabio Estevam" <festevam@gmail.com>, "Guido Günther" <agx@sigxcpu.org>, "Robert Chiras" <robert.chiras@nxp.com> Cc: Ondrej Jirman <megous@megous.com>, Samuel Holland <samuel@sholland.org>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] drm/panel: st7703: Fix the power up sequence of the panel Date: Thu, 16 Jul 2020 14:37:53 +0200 [thread overview] Message-ID: <20200716123753.3552425-3-megous@megous.com> (raw) In-Reply-To: <20200716123753.3552425-1-megous@megous.com> The datasheet specifies that it's better to keep reset asserted while powering up the supplies, and that IOVCC should be enabled first. There also needs to be a delay after enabling the supplies and before deasserting the reset. The datasheet specifies 1ms after the supplies reach the required voltage. Use 10-20ms to also give the power supplies some time to reach the required voltage, too. This fixes intermittent panel initialization failures and screen corruption during resume from sleep on PinePhone. Reported-by: Samuel Holland <samuel@sholland.org> Signed-off-by: Ondrej Jirman <megous@megous.com> --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c index 45833e6a0f4f..48569a8688f6 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c @@ -429,12 +429,8 @@ static int st7703_prepare(struct drm_panel *panel) return 0; DRM_DEV_DEBUG_DRIVER(ctx->dev, "Resetting the panel\n"); - ret = regulator_enable(ctx->vcc); - if (ret < 0) { - DRM_DEV_ERROR(ctx->dev, - "Failed to enable vcc supply: %d\n", ret); - return ret; - } + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + ret = regulator_enable(ctx->iovcc); if (ret < 0) { DRM_DEV_ERROR(ctx->dev, @@ -442,10 +438,18 @@ static int st7703_prepare(struct drm_panel *panel) goto disable_vcc; } - gpiod_set_value_cansleep(ctx->reset_gpio, 1); - usleep_range(20, 40); + ret = regulator_enable(ctx->vcc); + if (ret < 0) { + DRM_DEV_ERROR(ctx->dev, + "Failed to enable vcc supply: %d\n", ret); + return ret; + } + + /* Give power supplies time to stabilize before deasserting reset. */ + usleep_range(10000, 20000); + gpiod_set_value_cansleep(ctx->reset_gpio, 0); - msleep(20); + usleep_range(15000, 20000); ctx->prepared = true; -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Ondrej Jirman <megous@megous.com> To: "David Airlie" <airlied@linux.ie>, "Daniel Vetter" <daniel@ffwll.ch>, "Thierry Reding" <thierry.reding@gmail.com>, "Sam Ravnborg" <sam@ravnborg.org>, "Fabio Estevam" <festevam@gmail.com>, "Guido Günther" <agx@sigxcpu.org>, "Robert Chiras" <robert.chiras@nxp.com> Cc: Ondrej Jirman <megous@megous.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Samuel Holland <samuel@sholland.org> Subject: [PATCH 2/2] drm/panel: st7703: Fix the power up sequence of the panel Date: Thu, 16 Jul 2020 14:37:53 +0200 [thread overview] Message-ID: <20200716123753.3552425-3-megous@megous.com> (raw) In-Reply-To: <20200716123753.3552425-1-megous@megous.com> The datasheet specifies that it's better to keep reset asserted while powering up the supplies, and that IOVCC should be enabled first. There also needs to be a delay after enabling the supplies and before deasserting the reset. The datasheet specifies 1ms after the supplies reach the required voltage. Use 10-20ms to also give the power supplies some time to reach the required voltage, too. This fixes intermittent panel initialization failures and screen corruption during resume from sleep on PinePhone. Reported-by: Samuel Holland <samuel@sholland.org> Signed-off-by: Ondrej Jirman <megous@megous.com> --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c index 45833e6a0f4f..48569a8688f6 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c @@ -429,12 +429,8 @@ static int st7703_prepare(struct drm_panel *panel) return 0; DRM_DEV_DEBUG_DRIVER(ctx->dev, "Resetting the panel\n"); - ret = regulator_enable(ctx->vcc); - if (ret < 0) { - DRM_DEV_ERROR(ctx->dev, - "Failed to enable vcc supply: %d\n", ret); - return ret; - } + gpiod_set_value_cansleep(ctx->reset_gpio, 1); + ret = regulator_enable(ctx->iovcc); if (ret < 0) { DRM_DEV_ERROR(ctx->dev, @@ -442,10 +438,18 @@ static int st7703_prepare(struct drm_panel *panel) goto disable_vcc; } - gpiod_set_value_cansleep(ctx->reset_gpio, 1); - usleep_range(20, 40); + ret = regulator_enable(ctx->vcc); + if (ret < 0) { + DRM_DEV_ERROR(ctx->dev, + "Failed to enable vcc supply: %d\n", ret); + return ret; + } + + /* Give power supplies time to stabilize before deasserting reset. */ + usleep_range(10000, 20000); + gpiod_set_value_cansleep(ctx->reset_gpio, 0); - msleep(20); + usleep_range(15000, 20000); ctx->prepared = true; -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-16 12:38 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-16 12:37 [PATCH 0/2] Fix st7703 panel initialization failures Ondrej Jirman 2020-07-16 12:37 ` Ondrej Jirman 2020-07-16 12:37 ` [PATCH 1/2] drm/panel: st7703: Make the sleep exit timing match the spec Ondrej Jirman 2020-07-16 12:37 ` Ondrej Jirman 2020-07-16 12:37 ` Ondrej Jirman [this message] 2020-07-16 12:37 ` [PATCH 2/2] drm/panel: st7703: Fix the power up sequence of the panel Ondrej Jirman 2020-07-16 14:08 ` [PATCH 0/2] Fix st7703 panel initialization failures Guido Günther 2020-07-16 14:08 ` Guido Günther 2020-07-16 14:32 ` Ondřej Jirman 2020-07-16 14:32 ` Ondřej Jirman 2020-07-18 17:31 ` Guido Günther 2020-07-18 17:31 ` Guido Günther 2020-07-18 17:42 ` Ondřej Jirman 2020-07-18 17:42 ` Ondřej Jirman 2020-07-29 15:48 ` Guido Günther 2020-07-29 15:48 ` Guido Günther 2020-07-30 13:41 ` Ondřej Jirman 2020-07-30 13:41 ` Ondřej Jirman 2020-08-01 11:04 ` Guido Günther 2020-08-01 11:04 ` Guido Günther
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200716123753.3552425-3-megous@megous.com \ --to=megous@megous.com \ --cc=agx@sigxcpu.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=festevam@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robert.chiras@nxp.com \ --cc=sam@ravnborg.org \ --cc=samuel@sholland.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.