drivers/net/can/kvaser_pciefd.c:681 kvaser_pciefd_pwm_start() error: double unlocked 'can->lock' (orig line 666)

drivers/net/can/kvaser_pciefd.c:681 kvaser_pciefd_pwm_start() error: double unlocked 'can->lock' (orig line 666)

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3687 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Christer Beskow <chbe@kvaser.com>
CC: "Marc Kleine-Budde" <mkl@pengutronix.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   07a56bb875afbe39dabbf6ba7b83783d166863db
commit: 1910cd88539c07abf34a558a0976b506483c377c can: kvaser_pciefd: kvaser_pciefd_pwm_stop(): remove unnecessary code when setting pwm duty cycle to zero
date:   11 months ago
:::::: branch date: 11 hours ago
:::::: commit date: 11 months ago
config: ia64-randconfig-m031-20200717 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/net/can/kvaser_pciefd.c:681 kvaser_pciefd_pwm_start() error: double unlocked 'can->lock' (orig line 666)

# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1910cd88539c07abf34a558a0976b506483c377c
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout 1910cd88539c07abf34a558a0976b506483c377c
vim +681 drivers/net/can/kvaser_pciefd.c

26ad340e582d3d Henning Colliander 2019-05-28  659  
26ad340e582d3d Henning Colliander 2019-05-28  660  static void kvaser_pciefd_pwm_start(struct kvaser_pciefd_can *can)
26ad340e582d3d Henning Colliander 2019-05-28  661  {
26ad340e582d3d Henning Colliander 2019-05-28  662  	int top, trigger;
26ad340e582d3d Henning Colliander 2019-05-28  663  	u32 pwm_ctrl;
26ad340e582d3d Henning Colliander 2019-05-28  664  	unsigned long irq;
26ad340e582d3d Henning Colliander 2019-05-28  665  
26ad340e582d3d Henning Colliander 2019-05-28 @666  	kvaser_pciefd_pwm_stop(can);
26ad340e582d3d Henning Colliander 2019-05-28  667  	spin_lock_irqsave(&can->lock, irq);
26ad340e582d3d Henning Colliander 2019-05-28  668  
26ad340e582d3d Henning Colliander 2019-05-28  669  	/* Set frequency to 500 KHz*/
26ad340e582d3d Henning Colliander 2019-05-28  670  	top = can->can.clock.freq / (2 * 500000) - 1;
26ad340e582d3d Henning Colliander 2019-05-28  671  
26ad340e582d3d Henning Colliander 2019-05-28  672  	pwm_ctrl = top & 0xff;
26ad340e582d3d Henning Colliander 2019-05-28  673  	pwm_ctrl |= (top & 0xff) << KVASER_PCIEFD_KCAN_PWM_TOP_SHIFT;
26ad340e582d3d Henning Colliander 2019-05-28  674  	iowrite32(pwm_ctrl, can->reg_base + KVASER_PCIEFD_KCAN_PWM_REG);
26ad340e582d3d Henning Colliander 2019-05-28  675  
26ad340e582d3d Henning Colliander 2019-05-28  676  	/* Set duty cycle to 95 */
26ad340e582d3d Henning Colliander 2019-05-28  677  	trigger = (100 * top - 95 * (top + 1) + 50) / 100;
26ad340e582d3d Henning Colliander 2019-05-28  678  	pwm_ctrl = trigger & 0xff;
26ad340e582d3d Henning Colliander 2019-05-28  679  	pwm_ctrl |= (top & 0xff) << KVASER_PCIEFD_KCAN_PWM_TOP_SHIFT;
26ad340e582d3d Henning Colliander 2019-05-28  680  	iowrite32(pwm_ctrl, can->reg_base + KVASER_PCIEFD_KCAN_PWM_REG);
26ad340e582d3d Henning Colliander 2019-05-28 @681  	spin_unlock_irqrestore(&can->lock, irq);
26ad340e582d3d Henning Colliander 2019-05-28  682  }
26ad340e582d3d Henning Colliander 2019-05-28  683  

:::::: The code at line 681 was first introduced by commit
:::::: 26ad340e582d3d5958ed8456a1911d79cfb567b4 can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices

:::::: TO: Henning Colliander <henning.colliander@evidente.se>
:::::: CC: Marc Kleine-Budde <mkl@pengutronix.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 25877 bytes --]