From: Qais Yousef <qais.yousef@arm.com>
To: peterz@infradead.org
Cc: Steven Rostedt <rostedt@goodmis.org>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
x86@kernel.org, Ingo Molnar <mingo@kernel.org>,
sfr@canb.auug.org.au
Subject: Re: [tip:sched/fifo 44/45] ERROR: modpost: "sched_setscheduler" undefined!
Date: Tue, 21 Jul 2020 11:13:58 +0100 [thread overview]
Message-ID: <20200721101357.xoa6x4xtzkqoltfk@e107158-lin> (raw)
In-Reply-To: <20200721083643.GG119549@hirez.programming.kicks-ass.net>
On 07/21/20 10:36, peterz@infradead.org wrote:
> On Mon, Jul 20, 2020 at 06:19:43PM -0400, Steven Rostedt wrote:
> > On Mon, 20 Jul 2020 23:49:18 +0200
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > > Steve, would this work for you, or would you prefer renaming the
> > > parameters as well?
> > >
> >
> > Yeah, that's fine. You don't have any sched_fifo_high() ?
>
> Thanks! and no.
>
> I'll go write a Changelog and add it to tip/sched/fifo, so that
> hopefully, sfr can stop complaining about this build fail ;-)
>
> I've even argued we should rename fifo_low() to something else, but
> failed to come up with a sensible name. The intended case is for when
> you want something above normal but don't particularly care about RT at
> all.
>
> The thing is, once you start adding priorities, even low,med,high, we're
> back to where we were. And the whole argument is that the kernel cannot
> set priorities in any sensible fashion.
Agreed. I am worried about in-kernel users setting random uclamp values too.
This series should do most of the work but there are more pieces needed on-top.
From what I see we still need to move the sched_setscheduler() from
include/linux/sched.h to kernel/sched/sched.h. And sched_setattr() too. The
latter has a single user in kernel/trace/trace_selftest.c to create a deadline
task. I think that can be easily wrapped with a similar sched_set_dl()
function and exported instead.
Happy to do the work if you nudge me after you've published this fix on tip or
your queue.
Thanks
--
Qais Yousef
WARNING: multiple messages have this Message-ID (diff)
From: Qais Yousef <qais.yousef@arm.com>
To: kbuild-all@lists.01.org
Subject: Re: [tip:sched/fifo 44/45] ERROR: modpost: "sched_setscheduler" undefined!
Date: Tue, 21 Jul 2020 11:13:58 +0100 [thread overview]
Message-ID: <20200721101357.xoa6x4xtzkqoltfk@e107158-lin> (raw)
In-Reply-To: <20200721083643.GG119549@hirez.programming.kicks-ass.net>
[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]
On 07/21/20 10:36, peterz(a)infradead.org wrote:
> On Mon, Jul 20, 2020 at 06:19:43PM -0400, Steven Rostedt wrote:
> > On Mon, 20 Jul 2020 23:49:18 +0200
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > > Steve, would this work for you, or would you prefer renaming the
> > > parameters as well?
> > >
> >
> > Yeah, that's fine. You don't have any sched_fifo_high() ?
>
> Thanks! and no.
>
> I'll go write a Changelog and add it to tip/sched/fifo, so that
> hopefully, sfr can stop complaining about this build fail ;-)
>
> I've even argued we should rename fifo_low() to something else, but
> failed to come up with a sensible name. The intended case is for when
> you want something above normal but don't particularly care about RT at
> all.
>
> The thing is, once you start adding priorities, even low,med,high, we're
> back to where we were. And the whole argument is that the kernel cannot
> set priorities in any sensible fashion.
Agreed. I am worried about in-kernel users setting random uclamp values too.
This series should do most of the work but there are more pieces needed on-top.
>From what I see we still need to move the sched_setscheduler() from
include/linux/sched.h to kernel/sched/sched.h. And sched_setattr() too. The
latter has a single user in kernel/trace/trace_selftest.c to create a deadline
task. I think that can be easily wrapped with a similar sched_set_dl()
function and exported instead.
Happy to do the work if you nudge me after you've published this fix on tip or
your queue.
Thanks
--
Qais Yousef
next prev parent reply other threads:[~2020-07-21 10:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 14:15 [tip:sched/fifo 44/45] ERROR: modpost: "sched_setscheduler" undefined! kernel test robot
2020-06-19 14:15 ` kernel test robot
2020-07-09 12:45 ` Peter Zijlstra
2020-07-09 12:45 ` Peter Zijlstra
2020-07-09 15:58 ` Steven Rostedt
2020-07-09 15:58 ` Steven Rostedt
2020-07-20 21:49 ` Peter Zijlstra
2020-07-20 21:49 ` Peter Zijlstra
2020-07-20 22:19 ` Steven Rostedt
2020-07-20 22:19 ` Steven Rostedt
2020-07-21 8:36 ` peterz
2020-07-21 8:36 ` peterz
2020-07-21 10:13 ` Qais Yousef [this message]
2020-07-21 10:13 ` Qais Yousef
2020-07-29 10:23 ` Dietmar Eggemann
2020-07-29 10:23 ` Dietmar Eggemann
2020-07-29 10:38 ` Qais Yousef
2020-07-29 10:38 ` Qais Yousef
2020-07-30 15:29 ` Qais Yousef
2020-07-30 15:29 ` Qais Yousef
2020-07-21 13:30 ` Steven Rostedt
2020-07-21 13:30 ` Steven Rostedt
2020-07-24 21:39 ` [PATCH] sched,tracing: Convert to sched_set_fifo() peterz
2020-07-24 21:39 ` peterz
2020-07-24 21:46 ` Steven Rostedt
2020-07-24 21:46 ` Steven Rostedt
2020-07-24 21:50 ` [PATCH v2] " peterz
2020-07-24 21:50 ` peterz
2020-07-24 22:18 ` Steven Rostedt
2020-07-24 22:18 ` [PATCH v2] sched, tracing: " Steven Rostedt
2020-07-25 16:58 ` [PATCH v2] sched,tracing: " Peter Zijlstra
2020-07-25 16:58 ` [PATCH v2] sched, tracing: " Peter Zijlstra
2020-07-27 20:56 ` [PATCH v2] sched,tracing: " Steven Rostedt
2020-07-27 20:56 ` [PATCH v2] sched, tracing: " Steven Rostedt
2020-07-29 10:54 ` [tip: sched/fifo] sched,tracing: " tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721101357.xoa6x4xtzkqoltfk@e107158-lin \
--to=qais.yousef@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.