From: David Gibson <david@gibson.dropbear.id.au> To: dgilbert@redhat.com, frankja@linux.ibm.com, pair@us.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com, brijesh.singh@amd.com Cc: ehabkost@redhat.com, marcel.apfelbaum@gmail.com, "Michael S. Tsirkin" <mst@redhat.com>, qemu-ppc@nongnu.org, kvm@vger.kernel.org, pasic@linux.ibm.com, qemu-s390x@nongnu.org, "David Gibson" <david@gibson.dropbear.id.au>, "David Hildenbrand" <david@redhat.com>, "Christian Borntraeger" <borntraeger@de.ibm.com>, "Richard Henderson" <rth@twiddle.net>, "Daniel P. Berrangé" <berrange@redhat.com>, mdroth@linux.vnet.ibm.com, "Thomas Huth" <thuth@redhat.com>, "Cornelia Huck" <cohuck@redhat.com>, "Richard Henderson" <richard.henderson@linaro.org> Subject: [for-5.2 v4 04/10] host trust limitation: Rework the "memory-encryption" property Date: Fri, 24 Jul 2020 12:57:38 +1000 [thread overview] Message-ID: <20200724025744.69644-5-david@gibson.dropbear.id.au> (raw) In-Reply-To: <20200724025744.69644-1-david@gibson.dropbear.id.au> Currently the "memory-encryption" property is only looked at once we get to kvm_init(). Although protection of guest memory from the hypervisor isn't something that could really ever work with TCG, it's not conceptually tied to the KVM accelerator. In addition, the way the string property is resolved to an object is almost identical to how a QOM link property is handled. So, create a new "host-trust-limitation" link property which sets this QOM interface link directly in the machine. For compatibility we keep the "memory-encryption" property, but now implemented in terms of the new property. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> --- accel/kvm/kvm-all.c | 23 +++++++---------------- hw/core/machine.c | 41 ++++++++++++++++++++++++++++++++++++----- include/hw/boards.h | 2 +- 3 files changed, 44 insertions(+), 22 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index d7d95eacc7..e2d8f47f93 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2186,25 +2186,16 @@ static int kvm_init(MachineState *ms) * if memory encryption object is specified then initialize the memory * encryption context. */ - if (ms->memory_encryption) { - Object *obj = object_resolve_path_component(object_get_objects_root(), - ms->memory_encryption); - - if (object_dynamic_cast(obj, TYPE_HOST_TRUST_LIMITATION)) { - HostTrustLimitation *htl = HOST_TRUST_LIMITATION(obj); - HostTrustLimitationClass *htlc - = HOST_TRUST_LIMITATION_GET_CLASS(htl); - - ret = htlc->kvm_init(htl); - if (ret < 0) { - goto err; - } + if (ms->htl) { + HostTrustLimitationClass *htlc = + HOST_TRUST_LIMITATION_GET_CLASS(ms->htl); - kvm_state->htl = htl; - } else { - ret = -1; + ret = htlc->kvm_init(ms->htl); + if (ret < 0) { goto err; } + + kvm_state->htl = ms->htl; } ret = kvm_arch_init(ms, s); diff --git a/hw/core/machine.c b/hw/core/machine.c index 035a1fc631..b599b0ba65 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -27,6 +27,7 @@ #include "hw/pci/pci.h" #include "hw/mem/nvdimm.h" #include "migration/vmstate.h" +#include "exec/host-trust-limitation.h" GlobalProperty hw_compat_5_0[] = { { "virtio-balloon-device", "page-poison", "false" }, @@ -422,16 +423,37 @@ static char *machine_get_memory_encryption(Object *obj, Error **errp) { MachineState *ms = MACHINE(obj); - return g_strdup(ms->memory_encryption); + if (ms->htl) { + return g_strdup(object_get_canonical_path_component(OBJECT(ms->htl))); + } + + return NULL; } static void machine_set_memory_encryption(Object *obj, const char *value, Error **errp) { - MachineState *ms = MACHINE(obj); + Object *htl = + object_resolve_path_component(object_get_objects_root(), value); + + if (!htl) { + error_setg(errp, "No such memory encryption object '%s'", value); + return; + } - g_free(ms->memory_encryption); - ms->memory_encryption = g_strdup(value); + object_property_set_link(obj, "host-trust-limitation", htl, errp); +} + +static void machine_check_host_trust_limitation(const Object *obj, + const char *name, + Object *new_target, + Error **errp) +{ + /* + * So far the only constraint is that the target has the + * TYPE_HOST_TRUST_LIMITATION interface, and that's checked by the + * QOM core + */ } static bool machine_get_nvdimm(Object *obj, Error **errp) @@ -852,6 +874,15 @@ static void machine_class_init(ObjectClass *oc, void *data) object_class_property_set_description(oc, "enforce-config-section", "Set on to enforce configuration section migration"); + object_class_property_add_link(oc, "host-trust-limitation", + TYPE_HOST_TRUST_LIMITATION, + offsetof(MachineState, htl), + machine_check_host_trust_limitation, + OBJ_PROP_LINK_STRONG); + object_class_property_set_description(oc, "host-trust-limitation", + "Set host trust limitation object to use"); + + /* For compatibility */ object_class_property_add_str(oc, "memory-encryption", machine_get_memory_encryption, machine_set_memory_encryption); object_class_property_set_description(oc, "memory-encryption", @@ -1123,7 +1154,7 @@ void machine_run_board_init(MachineState *machine) } } - if (machine->memory_encryption) { + if (machine->htl) { /* * With host trust limitation, the host can't see the real * contents of RAM, so there's no point in it trying to merge diff --git a/include/hw/boards.h b/include/hw/boards.h index 426ce5f625..c70fb8bd9f 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -278,7 +278,7 @@ struct MachineState { bool suppress_vmdesc; bool enforce_config_section; bool enable_graphics; - char *memory_encryption; + HostTrustLimitation *htl; char *ram_memdev_id; /* * convenience alias to ram_memdev_id backend memory region -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au> To: dgilbert@redhat.com, frankja@linux.ibm.com, pair@us.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com, brijesh.singh@amd.com Cc: "Thomas Huth" <thuth@redhat.com>, "Cornelia Huck" <cohuck@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, ehabkost@redhat.com, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, "David Hildenbrand" <david@redhat.com>, "Richard Henderson" <richard.henderson@linaro.org>, mdroth@linux.vnet.ibm.com, pasic@linux.ibm.com, "Christian Borntraeger" <borntraeger@de.ibm.com>, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, "Richard Henderson" <rth@twiddle.net>, "David Gibson" <david@gibson.dropbear.id.au> Subject: [for-5.2 v4 04/10] host trust limitation: Rework the "memory-encryption" property Date: Fri, 24 Jul 2020 12:57:38 +1000 [thread overview] Message-ID: <20200724025744.69644-5-david@gibson.dropbear.id.au> (raw) In-Reply-To: <20200724025744.69644-1-david@gibson.dropbear.id.au> Currently the "memory-encryption" property is only looked at once we get to kvm_init(). Although protection of guest memory from the hypervisor isn't something that could really ever work with TCG, it's not conceptually tied to the KVM accelerator. In addition, the way the string property is resolved to an object is almost identical to how a QOM link property is handled. So, create a new "host-trust-limitation" link property which sets this QOM interface link directly in the machine. For compatibility we keep the "memory-encryption" property, but now implemented in terms of the new property. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> --- accel/kvm/kvm-all.c | 23 +++++++---------------- hw/core/machine.c | 41 ++++++++++++++++++++++++++++++++++++----- include/hw/boards.h | 2 +- 3 files changed, 44 insertions(+), 22 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index d7d95eacc7..e2d8f47f93 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2186,25 +2186,16 @@ static int kvm_init(MachineState *ms) * if memory encryption object is specified then initialize the memory * encryption context. */ - if (ms->memory_encryption) { - Object *obj = object_resolve_path_component(object_get_objects_root(), - ms->memory_encryption); - - if (object_dynamic_cast(obj, TYPE_HOST_TRUST_LIMITATION)) { - HostTrustLimitation *htl = HOST_TRUST_LIMITATION(obj); - HostTrustLimitationClass *htlc - = HOST_TRUST_LIMITATION_GET_CLASS(htl); - - ret = htlc->kvm_init(htl); - if (ret < 0) { - goto err; - } + if (ms->htl) { + HostTrustLimitationClass *htlc = + HOST_TRUST_LIMITATION_GET_CLASS(ms->htl); - kvm_state->htl = htl; - } else { - ret = -1; + ret = htlc->kvm_init(ms->htl); + if (ret < 0) { goto err; } + + kvm_state->htl = ms->htl; } ret = kvm_arch_init(ms, s); diff --git a/hw/core/machine.c b/hw/core/machine.c index 035a1fc631..b599b0ba65 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -27,6 +27,7 @@ #include "hw/pci/pci.h" #include "hw/mem/nvdimm.h" #include "migration/vmstate.h" +#include "exec/host-trust-limitation.h" GlobalProperty hw_compat_5_0[] = { { "virtio-balloon-device", "page-poison", "false" }, @@ -422,16 +423,37 @@ static char *machine_get_memory_encryption(Object *obj, Error **errp) { MachineState *ms = MACHINE(obj); - return g_strdup(ms->memory_encryption); + if (ms->htl) { + return g_strdup(object_get_canonical_path_component(OBJECT(ms->htl))); + } + + return NULL; } static void machine_set_memory_encryption(Object *obj, const char *value, Error **errp) { - MachineState *ms = MACHINE(obj); + Object *htl = + object_resolve_path_component(object_get_objects_root(), value); + + if (!htl) { + error_setg(errp, "No such memory encryption object '%s'", value); + return; + } - g_free(ms->memory_encryption); - ms->memory_encryption = g_strdup(value); + object_property_set_link(obj, "host-trust-limitation", htl, errp); +} + +static void machine_check_host_trust_limitation(const Object *obj, + const char *name, + Object *new_target, + Error **errp) +{ + /* + * So far the only constraint is that the target has the + * TYPE_HOST_TRUST_LIMITATION interface, and that's checked by the + * QOM core + */ } static bool machine_get_nvdimm(Object *obj, Error **errp) @@ -852,6 +874,15 @@ static void machine_class_init(ObjectClass *oc, void *data) object_class_property_set_description(oc, "enforce-config-section", "Set on to enforce configuration section migration"); + object_class_property_add_link(oc, "host-trust-limitation", + TYPE_HOST_TRUST_LIMITATION, + offsetof(MachineState, htl), + machine_check_host_trust_limitation, + OBJ_PROP_LINK_STRONG); + object_class_property_set_description(oc, "host-trust-limitation", + "Set host trust limitation object to use"); + + /* For compatibility */ object_class_property_add_str(oc, "memory-encryption", machine_get_memory_encryption, machine_set_memory_encryption); object_class_property_set_description(oc, "memory-encryption", @@ -1123,7 +1154,7 @@ void machine_run_board_init(MachineState *machine) } } - if (machine->memory_encryption) { + if (machine->htl) { /* * With host trust limitation, the host can't see the real * contents of RAM, so there's no point in it trying to merge diff --git a/include/hw/boards.h b/include/hw/boards.h index 426ce5f625..c70fb8bd9f 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -278,7 +278,7 @@ struct MachineState { bool suppress_vmdesc; bool enforce_config_section; bool enable_graphics; - char *memory_encryption; + HostTrustLimitation *htl; char *ram_memdev_id; /* * convenience alias to ram_memdev_id backend memory region -- 2.26.2
next prev parent reply other threads:[~2020-07-24 2:57 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-24 2:57 [for-5.2 v4 00/10] Generalize memory encryption models David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-24 2:57 ` [for-5.2 v4 01/10] host trust limitation: Introduce new host trust limitation interface David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-24 2:57 ` [for-5.2 v4 02/10] host trust limitation: Handle memory encryption via interface David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-24 2:57 ` [for-5.2 v4 03/10] host trust limitation: Move side effect out of machine_set_memory_encryption() David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-24 2:57 ` David Gibson [this message] 2020-07-24 2:57 ` [for-5.2 v4 04/10] host trust limitation: Rework the "memory-encryption" property David Gibson 2020-07-24 2:57 ` [for-5.2 v4 05/10] host trust limitation: Decouple kvm_memcrypt_*() helpers from KVM David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-24 2:57 ` [for-5.2 v4 06/10] host trust limitation: Add Error ** to HostTrustLimitation::kvm_init David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-24 2:57 ` [for-5.2 v4 07/10] spapr: Add PEF based host trust limitation David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-24 2:57 ` [for-5.2 v4 08/10] spapr: PEF: block migration David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-27 15:01 ` Dr. David Alan Gilbert 2020-07-27 15:01 ` Dr. David Alan Gilbert 2020-07-24 2:57 ` [for-5.2 v4 09/10] host trust limitation: Alter virtio default properties for protected guests David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-27 15:05 ` Dr. David Alan Gilbert 2020-07-27 15:05 ` Dr. David Alan Gilbert 2020-08-13 7:43 ` Greg Kurz 2020-08-13 7:43 ` Greg Kurz 2020-08-13 8:19 ` Greg Kurz 2020-08-13 8:19 ` Greg Kurz 2020-09-07 15:10 ` Halil Pasic 2020-09-07 15:10 ` Halil Pasic 2020-09-11 2:04 ` David Gibson 2020-09-11 2:04 ` David Gibson 2020-09-11 13:49 ` Halil Pasic 2020-09-11 13:49 ` Halil Pasic 2020-07-24 2:57 ` [for-5.2 v4 10/10] s390: Recognize host-trust-limitation option David Gibson 2020-07-24 2:57 ` David Gibson 2020-07-27 15:50 ` Cornelia Huck 2020-07-27 15:50 ` Cornelia Huck 2020-08-03 7:40 ` Janosch Frank 2020-08-03 7:40 ` Janosch Frank 2020-08-06 6:14 ` David Gibson 2020-08-06 6:14 ` David Gibson 2020-08-06 7:18 ` David Hildenbrand 2020-08-06 7:18 ` David Hildenbrand 2020-08-03 7:49 ` Janosch Frank 2020-08-03 7:49 ` Janosch Frank 2020-08-03 7:54 ` David Gibson 2020-08-03 7:54 ` David Gibson 2020-08-03 8:07 ` Janosch Frank 2020-08-03 8:07 ` Janosch Frank 2020-08-03 8:14 ` David Gibson 2020-08-03 8:14 ` David Gibson 2020-08-03 8:33 ` Cornelia Huck 2020-08-03 8:33 ` Cornelia Huck 2020-09-07 15:22 ` Halil Pasic 2020-09-07 15:22 ` Halil Pasic 2020-09-10 11:36 ` Cornelia Huck 2020-09-10 11:36 ` Cornelia Huck 2020-09-10 18:29 ` Halil Pasic 2020-09-10 18:29 ` Halil Pasic 2020-09-11 0:07 ` David Gibson 2020-09-11 0:07 ` David Gibson 2020-09-11 6:25 ` Greg Kurz 2020-09-11 6:25 ` Greg Kurz 2020-09-11 12:45 ` Halil Pasic 2020-09-11 12:45 ` Halil Pasic
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200724025744.69644-5-david@gibson.dropbear.id.au \ --to=david@gibson.dropbear.id.au \ --cc=berrange@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=brijesh.singh@amd.com \ --cc=cohuck@redhat.com \ --cc=david@redhat.com \ --cc=dgilbert@redhat.com \ --cc=ehabkost@redhat.com \ --cc=frankja@linux.ibm.com \ --cc=kvm@vger.kernel.org \ --cc=marcel.apfelbaum@gmail.com \ --cc=mdroth@linux.vnet.ibm.com \ --cc=mst@redhat.com \ --cc=pair@us.ibm.com \ --cc=pasic@linux.ibm.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ --cc=qemu-s390x@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=rth@twiddle.net \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.