All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Helgaas <bjorn@helgaas.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	Mark Brown <broonie@kernel.org>
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable
Date: Mon, 27 Jul 2020 18:47:43 +0530	[thread overview]
Message-ID: <20200727131742.82289-1-vaibhavgupta40@gmail.com> (raw)
In-Reply-To: <CAHp75Vdo22ofbCktupFYbfYy6PQ609fsk5B6u2b3FpfKxs8OQg@mail.gmail.com>

Before generic upgrade, both .suspend() and .resume() were invoking
pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both
states. (Normal trend is .suspend() enables and .resume() disables the
wakeup.)

This was ambiguous and may be buggy. Instead of replicating the legacy
behavior, drop the wakeup-disable call.

Fix: f185bcc77980("spi: spi-topcliff-pch: use generic power management")
Reported by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
 drivers/spi/spi-topcliff-pch.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 281a90f1b5d8..c73a03ddf5f3 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1648,8 +1648,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev)
 
 	dev_dbg(dev, "%s ENTRY\n", __func__);
 
-	device_wakeup_disable(dev);
-
 	/* set suspend status to false */
 	pd_dev_save->board_dat->suspend_sts = false;
 
-- 
2.27.0


WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Helgaas <bjorn@helgaas.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	Vaibhav Gupta <vaibhavgupta40@gmail.com>
Subject: [Linux-kernel-mentees] [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable
Date: Mon, 27 Jul 2020 18:47:43 +0530	[thread overview]
Message-ID: <20200727131742.82289-1-vaibhavgupta40@gmail.com> (raw)
In-Reply-To: <CAHp75Vdo22ofbCktupFYbfYy6PQ609fsk5B6u2b3FpfKxs8OQg@mail.gmail.com>

Before generic upgrade, both .suspend() and .resume() were invoking
pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both
states. (Normal trend is .suspend() enables and .resume() disables the
wakeup.)

This was ambiguous and may be buggy. Instead of replicating the legacy
behavior, drop the wakeup-disable call.

Fix: f185bcc77980("spi: spi-topcliff-pch: use generic power management")
Reported by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
 drivers/spi/spi-topcliff-pch.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 281a90f1b5d8..c73a03ddf5f3 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -1648,8 +1648,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev)
 
 	dev_dbg(dev, "%s ENTRY\n", __func__);
 
-	device_wakeup_disable(dev);
-
 	/* set suspend status to false */
 	pd_dev_save->board_dat->suspend_sts = false;
 
-- 
2.27.0

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  parent reply	other threads:[~2020-07-27 13:21 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 15:57 [PATCH v1] spi: spi-topcliff-pch: use generic power management Vaibhav Gupta
2020-07-20 15:57 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-22 13:45 ` Mark Brown
2020-07-22 13:45   ` [Linux-kernel-mentees] " Mark Brown
2020-07-22 20:01   ` Vaibhav Gupta
2020-07-22 20:01     ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-24 10:51 ` Andy Shevchenko
2020-07-24 10:51   ` [Linux-kernel-mentees] " Andy Shevchenko
2020-07-24 15:16   ` Vaibhav Gupta
2020-07-24 15:16     ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-24 20:16     ` Andy Shevchenko
2020-07-24 20:16       ` [Linux-kernel-mentees] " Andy Shevchenko
2020-07-24 22:37       ` Bjorn Helgaas
2020-07-24 22:37         ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-07-25 10:42         ` Andy Shevchenko
2020-07-25 10:42           ` [Linux-kernel-mentees] " Andy Shevchenko
2020-07-25 10:44           ` Andy Shevchenko
2020-07-25 10:44             ` [Linux-kernel-mentees] " Andy Shevchenko
2020-07-27  7:06             ` Vaibhav Gupta
2020-07-27  7:06               ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-27 11:12               ` Andy Shevchenko
2020-07-27 11:12                 ` [Linux-kernel-mentees] " Andy Shevchenko
2020-07-27 13:08                 ` Vaibhav Gupta
2020-07-27 13:08                   ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-27 13:17       ` Vaibhav Gupta [this message]
2020-07-27 13:17         ` [Linux-kernel-mentees] [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable Vaibhav Gupta
2020-07-27 13:38         ` Andy Shevchenko
2020-07-27 13:38           ` [Linux-kernel-mentees] " Andy Shevchenko
2020-07-27 13:46           ` Vaibhav Gupta
2020-07-27 13:46             ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-27 14:08             ` Andy Shevchenko
2020-07-27 14:08               ` [Linux-kernel-mentees] " Andy Shevchenko
2020-07-27 14:17               ` Joe Perches
2020-07-27 14:17                 ` [Linux-kernel-mentees] " Joe Perches
2020-07-27 17:29           ` [PATCH v3] " Vaibhav Gupta
2020-07-27 17:29             ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-27 19:21             ` Andy Shevchenko
2020-07-27 19:21               ` [Linux-kernel-mentees] " Andy Shevchenko
2020-07-28 16:31             ` Mark Brown
2020-07-28 16:31               ` [Linux-kernel-mentees] " Mark Brown
2020-07-28 16:31         ` [PATCH v2] " Mark Brown
2020-07-28 16:31           ` [Linux-kernel-mentees] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727131742.82289-1-vaibhavgupta40@gmail.com \
    --to=vaibhavgupta40@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn@helgaas.com \
    --cc=broonie@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=vaibhav.varodek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.