[PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl

[PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl

[Darrick J. Wong]

From: Darrick J. Wong <darrick.wong@oracle.com>

In xfs/030, we zero the entire AGFL which makes it corrupt because the
AG superblock block is /never/ free.  In commit dcd6c2e1 ("xfs_repair:
convert to libxfs_verify_agbno") we enhanced repair to complain about
zeroed entries in the AGFL, so add that to the golden output.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
v2: point out which commit we're testing
---
 tests/xfs/030.out |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/xfs/030.out b/tests/xfs/030.out
index 4a7c4b8b..53299438 100644
--- a/tests/xfs/030.out
+++ b/tests/xfs/030.out
@@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
 Phase 2 - using <TYPEOF> log
         - zero log...
         - scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
         - found root inode chunk
 Phase 3 - for each AG...
         - scan and clear agi unlinked lists...

Re: [PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl

[Zorro Lang]

On Wed, Jul 29, 2020 at 09:14:43AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> In xfs/030, we zero the entire AGFL which makes it corrupt because the
> AG superblock block is /never/ free.  In commit dcd6c2e1 ("xfs_repair:
> convert to libxfs_verify_agbno") we enhanced repair to complain about
> zeroed entries in the AGFL, so add that to the golden output.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> v2: point out which commit we're testing

Thanks for pointing out the commit.
Reviewed-by: Zorro Lang <zlang@redhat.com>

> ---
>  tests/xfs/030.out |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/xfs/030.out b/tests/xfs/030.out
> index 4a7c4b8b..53299438 100644
> --- a/tests/xfs/030.out
> +++ b/tests/xfs/030.out
> @@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
>  Phase 2 - using <TYPEOF> log
>          - zero log...
>          - scan filesystem freespace and inode maps...
> +bad agbno AGBNO in agfl, agno 0
>          - found root inode chunk
>  Phase 3 - for each AG...
>          - scan and clear agi unlinked lists...
>