Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

From: kernel test robot <lkp@intel.com>
To: Helen Koike <helen.koike@collabora.com>,
	mchehab@kernel.org, hans.verkuil@cisco.com,
	laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi,
	linux-media@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	Boris Brezillon <bbrezillon@kernel.org>,
	Helen Koike <helen.koike@collabora.com>,
	tfiga@chromium.org, hiroh@chromium.org, nicolas@ndufresne.ca
Subject: Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations
Date: Fri, 7 Aug 2020 04:30:13 +0800	[thread overview]
Message-ID: <202008070416.5QUCzyng%lkp@intel.com> (raw)
In-Reply-To: <20200804192939.2251988-3-helen.koike@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 2719 bytes --]

Hi Helen,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.8 next-20200806]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Helen-Koike/media-v4l2-Add-extended-fmt-and-buffer-ioctls/20200805-033507
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-a013-20200806 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 076b120bebfd727b502208601012a44ab2e1028e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/v4l2-core/v4l2-ioctl.c:538:3: warning: format specifies type 'unsigned int' but the argument has type '__u64' (aka 'unsigned long long') [-Wformat]
                   e->flags, prt_names(e->field, v4l2_field_names), e->sequence);
                   ^~~~~~~~
   include/linux/printk.h:380:26: note: expanded from macro 'pr_cont'
           printk(KERN_CONT fmt, ##__VA_ARGS__)
                            ~~~    ^~~~~~~~~~~
   1 warning generated.

vim +538 drivers/media/v4l2-core/v4l2-ioctl.c

   529	
   530	static void v4l_print_ext_buffer(const void *arg, bool write_only)
   531	{
   532		const struct v4l2_ext_buffer *e = arg;
   533		const struct v4l2_ext_plane *plane;
   534		unsigned int i;
   535	
   536		pr_cont("%lld index=%d, type=%s, flags=0x%08x, field=%s, sequence=%d\n",
   537			e->timestamp, e->index, prt_names(e->type, v4l2_type_names),
 > 538			e->flags, prt_names(e->field, v4l2_field_names), e->sequence);
   539	
   540		for (i = 0; i < VIDEO_MAX_PLANES &&
   541			    e->planes[i].buffer_length; i++) {
   542			plane = &e->planes[i];
   543			pr_debug("plane %d: buffer_length=%d, plane_length=%d offset=0x%08x, memory=%s\n",
   544				 i, plane->buffer_length, plane->plane_length,
   545				 plane->offset,
   546				 prt_names(plane->memory, v4l2_memory_names));
   547		}
   548	}
   549	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36861 bytes --]