From: Sam Ravnborg <sam@ravnborg.org> To: allen <allen.chen@ite.com.tw> Cc: Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>, Hermes Wu <Hermes.Wu@ite.com.tw>, Kenneth Hung <Kenneth.Hung@ite.com.tw>, Pi-Hsun Shih <pihsun@chromium.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v1 1/2] ite-it6505 change trigger conditions Date: Mon, 10 Aug 2020 20:27:12 +0200 [thread overview] Message-ID: <20200810182712.GA408647@ravnborg.org> (raw) In-Reply-To: <1597053278-25421-2-git-send-email-allen.chen@ite.com.tw> Hi Allen. On Mon, Aug 10, 2020 at 05:53:17PM +0800, allen wrote: > it6505 changes trigger conditions. > --- > Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > index 2c50016..bf0e889 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > @@ -73,7 +73,7 @@ examples: > > dp-bridge@5c { > compatible = "ite,it6505"; > - interrupts = <152 IRQ_TYPE_EDGE_FALLING 152 0>; > + interrupts = <152 IRQ_TYPE_LEVEL_LOW 152 0>; > reg = <0x5c>; > pinctrl-names = "default"; > pinctrl-0 = <&it6505_pins>; I fail to see the need for this. The example shall describe the binding and is not necessarily a correct description of the HW. People should look in the dts file for the HW descriptions, not the binding examples. So I have dropped this patch. Sam > -- > 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: allen <allen.chen@ite.com.tw> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Kenneth Hung <Kenneth.Hung@ite.com.tw>, Pi-Hsun Shih <pihsun@chromium.org>, Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>, David Airlie <airlied@linux.ie>, open list <linux-kernel@vger.kernel.org>, "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>, Hermes Wu <Hermes.Wu@ite.com.tw>, Rob Herring <robh+dt@kernel.org> Subject: Re: [PATCH v1 1/2] ite-it6505 change trigger conditions Date: Mon, 10 Aug 2020 20:27:12 +0200 [thread overview] Message-ID: <20200810182712.GA408647@ravnborg.org> (raw) In-Reply-To: <1597053278-25421-2-git-send-email-allen.chen@ite.com.tw> Hi Allen. On Mon, Aug 10, 2020 at 05:53:17PM +0800, allen wrote: > it6505 changes trigger conditions. > --- > Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > index 2c50016..bf0e889 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > @@ -73,7 +73,7 @@ examples: > > dp-bridge@5c { > compatible = "ite,it6505"; > - interrupts = <152 IRQ_TYPE_EDGE_FALLING 152 0>; > + interrupts = <152 IRQ_TYPE_LEVEL_LOW 152 0>; > reg = <0x5c>; > pinctrl-names = "default"; > pinctrl-0 = <&it6505_pins>; I fail to see the need for this. The example shall describe the binding and is not necessarily a correct description of the HW. People should look in the dts file for the HW descriptions, not the binding examples. So I have dropped this patch. Sam > -- > 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-10 18:27 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-10 9:53 [PATCH v1 0/2] IT6505 cover letter allen 2020-08-10 9:53 ` allen 2020-08-10 9:53 ` allen 2020-08-10 9:53 ` allen 2020-08-10 9:53 ` [PATCH v1 1/2] ite-it6505 change trigger conditions allen 2020-08-10 9:53 ` allen 2020-08-10 18:27 ` Sam Ravnborg [this message] 2020-08-10 18:27 ` Sam Ravnborg 2020-08-10 9:53 ` [PATCH v1 2/2] drm/bridge: add refactored it6505 driver allen 2020-08-10 9:53 ` allen 2020-08-10 9:53 ` allen 2020-08-10 9:53 ` allen 2020-08-10 10:11 [PATCH v1 0/2] IT6505 cover letter allen 2020-08-10 10:11 ` [PATCH v1 1/2] ite-it6505 change trigger conditions allen 2020-08-10 10:11 ` allen 2020-08-24 22:32 ` Rob Herring 2020-08-24 22:32 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200810182712.GA408647@ravnborg.org \ --to=sam@ravnborg.org \ --cc=Hermes.Wu@ite.com.tw \ --cc=Jau-Chih.Tseng@ite.com.tw \ --cc=Kenneth.Hung@ite.com.tw \ --cc=airlied@linux.ie \ --cc=allen.chen@ite.com.tw \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pihsun@chromium.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.