From: Keith Busch <kbusch@kernel.org> To: David Fugate <david.fugate@linux.intel.com> Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>, Kanchan Joshi <joshi.k@samsung.com>, "Damien.LeMoal@wdc.com" <Damien.LeMoal@wdc.com>, "sagi@grimberg.me" <sagi@grimberg.me>, "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>, Nitesh Shetty <nj.shetty@samsung.com>, SelvaKumar S <selvakuma.s1@samsung.com>, Javier Gonzalez <javier.gonz@samsung.com>, david.fugate@intel.com Subject: Re: [PATCH 2/2] nvme: add emulation for zone-append Date: Thu, 20 Aug 2020 12:45:39 +0900 [thread overview] Message-ID: <20200820034539.GA12222@redsun51.ssa.fujisawa.hgst.com> (raw) In-Reply-To: <d9cc3ece0c70b51c2d40998081375ad3fa39ece2.camel@linux.intel.com> On Wed, Aug 19, 2020 at 05:43:29PM -0600, David Fugate wrote: > There were queries? My key takeaways were a maintainer NAK followed by > instructions to make the Intel drive align with the driver by > implementing NOIOB. While I disagree with the rejection as it appeared > to be based entirely on politics, I can accept it as the quirk wasn't > in the spec. For the record, the suggestion provided, which you agreed to look into, most broadly enables your hardware on Linux and was entirely to your benefit. Not quite as dramatic as a political conspiracy. You later responded with a technical argument against that suggestion; however, your reason didn't add up, and that's where you left the thread. > It's not fair to make this same "your drive should align with the > driver" demand of Samsung because we *are* talking about a spec'ed > feature here. Technical critques of their patches and real performance > degrades observed are fair game and objective; "your company did > the nastiest possible move violating the normal NVMe procedures to make > it optional" is not. Sure, but you're cherry picking comments from the discussion. The performance impact exists, and it's generally not acceptable from a maintenance point to duplicate significant code without at least trying to provide a common solution.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org> To: David Fugate <david.fugate@linux.intel.com> Cc: Jens Axboe <axboe@kernel.dk>, "Damien.LeMoal@wdc.com" <Damien.LeMoal@wdc.com>, SelvaKumar S <selvakuma.s1@samsung.com>, "sagi@grimberg.me" <sagi@grimberg.me>, Kanchan Joshi <joshi.k@samsung.com>, "johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>, Nitesh Shetty <nj.shetty@samsung.com>, david.fugate@intel.com, Javier Gonzalez <javier.gonz@samsung.com>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH 2/2] nvme: add emulation for zone-append Date: Thu, 20 Aug 2020 12:45:39 +0900 [thread overview] Message-ID: <20200820034539.GA12222@redsun51.ssa.fujisawa.hgst.com> (raw) In-Reply-To: <d9cc3ece0c70b51c2d40998081375ad3fa39ece2.camel@linux.intel.com> On Wed, Aug 19, 2020 at 05:43:29PM -0600, David Fugate wrote: > There were queries? My key takeaways were a maintainer NAK followed by > instructions to make the Intel drive align with the driver by > implementing NOIOB. While I disagree with the rejection as it appeared > to be based entirely on politics, I can accept it as the quirk wasn't > in the spec. For the record, the suggestion provided, which you agreed to look into, most broadly enables your hardware on Linux and was entirely to your benefit. Not quite as dramatic as a political conspiracy. You later responded with a technical argument against that suggestion; however, your reason didn't add up, and that's where you left the thread. > It's not fair to make this same "your drive should align with the > driver" demand of Samsung because we *are* talking about a spec'ed > feature here. Technical critques of their patches and real performance > degrades observed are fair game and objective; "your company did > the nastiest possible move violating the normal NVMe procedures to make > it optional" is not. Sure, but you're cherry picking comments from the discussion. The performance impact exists, and it's generally not acceptable from a maintenance point to duplicate significant code without at least trying to provide a common solution. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-20 3:45 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20200818053247epcas5p262c5fd7e207dfa5145011c4329cf239d@epcas5p2.samsung.com> 2020-08-18 5:29 ` [PATCH 0/2] enable append-emulation for ZNS Kanchan Joshi 2020-08-18 5:29 ` Kanchan Joshi [not found] ` <CGME20200818053252epcas5p4ee61d64bba5f6a131105e40330984f5e@epcas5p4.samsung.com> 2020-08-18 5:29 ` [PATCH 1/2] nvme: set io-scheduler requirement " Kanchan Joshi 2020-08-18 5:29 ` Kanchan Joshi 2020-08-18 7:11 ` Christoph Hellwig 2020-08-18 7:11 ` Christoph Hellwig 2020-08-19 9:26 ` Kanchan Joshi 2020-08-19 9:26 ` Kanchan Joshi 2020-08-19 9:38 ` Damien Le Moal 2020-08-19 9:38 ` Damien Le Moal 2020-08-19 10:31 ` Kanchan Joshi 2020-08-19 10:31 ` Kanchan Joshi 2020-08-19 11:17 ` Damien Le Moal 2020-08-19 11:17 ` Damien Le Moal 2020-09-07 7:00 ` Kanchan Joshi 2020-09-07 7:00 ` Kanchan Joshi 2020-09-07 8:22 ` Damien Le Moal 2020-09-07 8:22 ` Damien Le Moal 2020-09-07 11:23 ` Kanchan Joshi 2020-09-07 11:23 ` Kanchan Joshi 2020-09-07 11:37 ` Damien Le Moal 2020-09-07 11:37 ` Damien Le Moal 2020-09-07 11:54 ` Kanchan Joshi 2020-09-07 11:54 ` Kanchan Joshi 2020-09-07 12:53 ` Damien Le Moal 2020-09-07 12:53 ` Damien Le Moal [not found] ` <CGME20200818053256epcas5p46d0b66b3702192eb6617c8bba334c15f@epcas5p4.samsung.com> 2020-08-18 5:29 ` [PATCH 2/2] nvme: add emulation for zone-append Kanchan Joshi 2020-08-18 5:29 ` Kanchan Joshi 2020-08-18 7:12 ` Christoph Hellwig 2020-08-18 7:12 ` Christoph Hellwig 2020-08-18 9:50 ` Javier Gonzalez 2020-08-18 9:50 ` Javier Gonzalez 2020-08-18 10:51 ` Matias Bjørling 2020-08-18 10:51 ` Matias Bjørling 2020-08-18 18:11 ` Javier Gonzalez 2020-08-18 18:11 ` Javier Gonzalez 2020-08-18 15:50 ` Christoph Hellwig 2020-08-18 15:50 ` Christoph Hellwig 2020-08-18 18:04 ` Javier Gonzalez 2020-08-18 18:04 ` Javier Gonzalez 2020-08-19 7:40 ` Christoph Hellwig 2020-08-19 7:40 ` Christoph Hellwig 2020-08-19 8:33 ` Javier Gonzalez 2020-08-19 8:33 ` Javier Gonzalez 2020-08-19 9:14 ` Damien Le Moal 2020-08-19 9:14 ` Damien Le Moal 2020-08-19 10:43 ` Christoph Hellwig 2020-08-19 10:43 ` Christoph Hellwig 2020-08-20 6:45 ` Javier Gonzalez 2020-08-20 6:45 ` Javier Gonzalez 2020-08-19 10:49 ` Christoph Hellwig 2020-08-19 10:49 ` Christoph Hellwig 2020-08-18 16:58 ` Keith Busch 2020-08-18 16:58 ` Keith Busch 2020-08-18 17:29 ` Javier Gonzalez 2020-08-18 17:29 ` Javier Gonzalez 2020-08-18 17:39 ` Keith Busch 2020-08-18 17:39 ` Keith Busch 2020-08-18 18:13 ` Javier Gonzalez 2020-08-18 18:13 ` Javier Gonzalez 2020-08-19 19:11 ` David Fugate 2020-08-19 19:11 ` David Fugate 2020-08-19 19:25 ` Jens Axboe 2020-08-19 19:25 ` Jens Axboe 2020-08-19 21:54 ` David Fugate 2020-08-19 21:54 ` David Fugate 2020-08-19 22:10 ` Keith Busch 2020-08-19 22:10 ` Keith Busch 2020-08-19 23:43 ` David Fugate 2020-08-19 23:43 ` David Fugate 2020-08-20 3:45 ` Keith Busch [this message] 2020-08-20 3:45 ` Keith Busch 2020-08-20 23:26 ` David Fugate 2020-08-20 23:26 ` David Fugate 2020-08-20 5:51 ` Christoph Hellwig 2020-08-20 5:51 ` Christoph Hellwig 2020-08-20 6:37 ` Javier Gonzalez 2020-08-20 6:37 ` Javier Gonzalez 2020-08-20 6:52 ` Christoph Hellwig 2020-08-20 6:52 ` Christoph Hellwig 2020-08-20 8:03 ` Javier Gonzalez 2020-08-20 8:03 ` Javier Gonzalez 2020-08-19 21:42 ` Keith Busch 2020-08-19 21:42 ` Keith Busch 2020-08-20 7:37 ` Kanchan Joshi 2020-08-20 7:37 ` Kanchan Joshi 2020-08-20 8:14 ` Javier Gonzalez 2020-08-20 8:14 ` Javier Gonzalez 2020-08-20 5:29 ` Christoph Hellwig 2020-08-20 5:29 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200820034539.GA12222@redsun51.ssa.fujisawa.hgst.com \ --to=kbusch@kernel.org \ --cc=Damien.LeMoal@wdc.com \ --cc=axboe@kernel.dk \ --cc=david.fugate@intel.com \ --cc=david.fugate@linux.intel.com \ --cc=hch@lst.de \ --cc=javier.gonz@samsung.com \ --cc=johannes.thumshirn@wdc.com \ --cc=joshi.k@samsung.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=nj.shetty@samsung.com \ --cc=sagi@grimberg.me \ --cc=selvakuma.s1@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.