* [PATCH] backlight: tosa_lcd: Include the right header
@ 2020-08-26 7:09 Linus Walleij
2020-09-01 13:37 ` Daniel Thompson
2020-09-08 11:30 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2020-08-26 7:09 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, dri-devel
Cc: Robert Jarzmik, Arnd Bergmann
The Tosa backlight LCDE driver was converted to use GPIO descriptors
in 0b0cb52bd80eda76c4b9921f5cf9c1b709d44e83
("video: backlight: tosa: Use GPIO lookup table") but
still includes <linux/gpio.h> rather than <linux/gpio/consumer.h>.
Fix it.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/video/backlight/tosa_lcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c
index 113116d3585c..38765544345b 100644
--- a/drivers/video/backlight/tosa_lcd.c
+++ b/drivers/video/backlight/tosa_lcd.c
@@ -12,7 +12,7 @@
#include <linux/spi/spi.h>
#include <linux/i2c.h>
#include <linux/slab.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/delay.h>
#include <linux/lcd.h>
#include <linux/fb.h>
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] backlight: tosa_lcd: Include the right header
2020-08-26 7:09 [PATCH] backlight: tosa_lcd: Include the right header Linus Walleij
@ 2020-09-01 13:37 ` Daniel Thompson
2020-09-08 11:30 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2020-09-01 13:37 UTC (permalink / raw)
To: Linus Walleij
Cc: Jingoo Han, Robert Jarzmik, Lee Jones, Arnd Bergmann, dri-devel
On Wed, Aug 26, 2020 at 09:09:17AM +0200, Linus Walleij wrote:
> The Tosa backlight LCDE driver was converted to use GPIO descriptors
> in 0b0cb52bd80eda76c4b9921f5cf9c1b709d44e83
> ("video: backlight: tosa: Use GPIO lookup table") but
> still includes <linux/gpio.h> rather than <linux/gpio/consumer.h>.
> Fix it.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/video/backlight/tosa_lcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c
> index 113116d3585c..38765544345b 100644
> --- a/drivers/video/backlight/tosa_lcd.c
> +++ b/drivers/video/backlight/tosa_lcd.c
> @@ -12,7 +12,7 @@
> #include <linux/spi/spi.h>
> #include <linux/i2c.h>
> #include <linux/slab.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/delay.h>
> #include <linux/lcd.h>
> #include <linux/fb.h>
> --
> 2.26.2
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] backlight: tosa_lcd: Include the right header
2020-08-26 7:09 [PATCH] backlight: tosa_lcd: Include the right header Linus Walleij
2020-09-01 13:37 ` Daniel Thompson
@ 2020-09-08 11:30 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2020-09-08 11:30 UTC (permalink / raw)
To: Linus Walleij
Cc: Jingoo Han, Daniel Thompson, Robert Jarzmik, Arnd Bergmann, dri-devel
On Wed, 26 Aug 2020, Linus Walleij wrote:
> The Tosa backlight LCDE driver was converted to use GPIO descriptors
> in 0b0cb52bd80eda76c4b9921f5cf9c1b709d44e83
> ("video: backlight: tosa: Use GPIO lookup table") but
> still includes <linux/gpio.h> rather than <linux/gpio/consumer.h>.
> Fix it.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/video/backlight/tosa_lcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-08 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 7:09 [PATCH] backlight: tosa_lcd: Include the right header Linus Walleij
2020-09-01 13:37 ` Daniel Thompson
2020-09-08 11:30 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.