From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Michal Simek <michal.simek@xilinx.com>,
Sekhar Nori <nsekhar@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Heiko Stuebner <heiko@sntech.de>,
Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Peter Rosin <peda@axentia.se>, Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
Date: Wed, 2 Sep 2020 17:06:43 +0200 [thread overview]
Message-ID: <20200902150643.14839-9-krzk@kernel.org> (raw)
In-Reply-To: <20200902150643.14839-1-krzk@kernel.org>
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/muxes/i2c-mux-reg.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
index b59a62f8d7a6..0e0679f65cf7 100644
--- a/drivers/i2c/muxes/i2c-mux-reg.c
+++ b/drivers/i2c/muxes/i2c-mux-reg.c
@@ -171,13 +171,9 @@ static int i2c_mux_reg_probe(struct platform_device *pdev)
sizeof(mux->data));
} else {
ret = i2c_mux_reg_probe_dt(mux, pdev);
- if (ret == -EPROBE_DEFER)
- return ret;
-
- if (ret < 0) {
- dev_err(&pdev->dev, "Error parsing device tree");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret,
+ "Error parsing device tree");
}
parent = i2c_get_adapter(mux->data.parent);
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Michal Simek <michal.simek@xilinx.com>,
Sekhar Nori <nsekhar@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Heiko Stuebner <heiko@sntech.de>,
Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Peter Rosin <peda@axentia.se>, Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
Date: Wed, 2 Sep 2020 17:06:43 +0200 [thread overview]
Message-ID: <20200902150643.14839-9-krzk@kernel.org> (raw)
In-Reply-To: <20200902150643.14839-1-krzk@kernel.org>
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/muxes/i2c-mux-reg.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
index b59a62f8d7a6..0e0679f65cf7 100644
--- a/drivers/i2c/muxes/i2c-mux-reg.c
+++ b/drivers/i2c/muxes/i2c-mux-reg.c
@@ -171,13 +171,9 @@ static int i2c_mux_reg_probe(struct platform_device *pdev)
sizeof(mux->data));
} else {
ret = i2c_mux_reg_probe_dt(mux, pdev);
- if (ret == -EPROBE_DEFER)
- return ret;
-
- if (ret < 0) {
- dev_err(&pdev->dev, "Error parsing device tree");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret,
+ "Error parsing device tree");
}
parent = i2c_get_adapter(mux->data.parent);
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Michal Simek <michal.simek@xilinx.com>,
Sekhar Nori <nsekhar@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Heiko Stuebner <heiko@sntech.de>,
Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Peter Rosin <peda@axentia.se>, Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()
Date: Wed, 2 Sep 2020 17:06:43 +0200 [thread overview]
Message-ID: <20200902150643.14839-9-krzk@kernel.org> (raw)
In-Reply-To: <20200902150643.14839-1-krzk@kernel.org>
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/i2c/muxes/i2c-mux-reg.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
index b59a62f8d7a6..0e0679f65cf7 100644
--- a/drivers/i2c/muxes/i2c-mux-reg.c
+++ b/drivers/i2c/muxes/i2c-mux-reg.c
@@ -171,13 +171,9 @@ static int i2c_mux_reg_probe(struct platform_device *pdev)
sizeof(mux->data));
} else {
ret = i2c_mux_reg_probe_dt(mux, pdev);
- if (ret == -EPROBE_DEFER)
- return ret;
-
- if (ret < 0) {
- dev_err(&pdev->dev, "Error parsing device tree");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret,
+ "Error parsing device tree");
}
parent = i2c_get_adapter(mux->data.parent);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-02 15:09 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:06 [PATCH 1/9] i2c: stm32: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` [PATCH 2/9] i2c: xiic: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2021-06-23 8:57 ` Michal Simek
2021-06-23 8:57 ` Michal Simek
2021-06-23 8:57 ` Michal Simek
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 3/9] i2c: bcm2835: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:24 ` Florian Fainelli
2020-09-02 15:24 ` Florian Fainelli
2020-09-02 15:24 ` Florian Fainelli
2020-09-10 6:25 ` Wolfram Sang
2020-09-10 6:25 ` Wolfram Sang
2020-09-10 6:25 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 4/9] i2c: cadence: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2021-06-23 8:59 ` Michal Simek
2021-06-23 8:59 ` Michal Simek
2021-06-23 8:59 ` Michal Simek
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 5/9] i2c: davinci: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2021-06-23 16:26 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 6/9] i2c: imx: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 17:58 ` Uwe Kleine-König
2020-09-02 17:58 ` Uwe Kleine-König
2020-09-02 17:58 ` Uwe Kleine-König
2020-09-03 5:36 ` Oleksij Rempel
2020-09-03 5:36 ` Oleksij Rempel
2020-09-03 5:36 ` Oleksij Rempel
2020-09-10 6:27 ` Wolfram Sang
2020-09-10 6:27 ` Wolfram Sang
2020-09-10 6:27 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 7/9] i2c: rk3x: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-22 14:25 ` Heiko Stübner
2020-09-22 14:25 ` Heiko Stübner
2020-09-22 14:25 ` Heiko Stübner
2020-09-27 18:01 ` Wolfram Sang
2020-09-27 18:01 ` Wolfram Sang
2020-09-27 18:01 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 8/9] i2c: mux: gpmux: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 18:33 ` Peter Rosin
2020-09-02 18:33 ` Peter Rosin
2020-09-02 18:33 ` Peter Rosin
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 6:24 ` Wolfram Sang
2020-09-02 15:06 ` Krzysztof Kozlowski [this message]
2020-09-02 15:06 ` [PATCH 9/9] i2c: mux: reg: " Krzysztof Kozlowski
2020-09-02 15:06 ` Krzysztof Kozlowski
2020-09-02 18:33 ` Peter Rosin
2020-09-02 18:33 ` Peter Rosin
2020-09-02 18:33 ` Peter Rosin
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 9:36 ` [PATCH 1/9] i2c: stm32: " Alain Volmat
2020-09-10 9:36 ` Alain Volmat
2020-09-10 9:36 ` Alain Volmat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902150643.14839-9-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@rempel-privat.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nsaenzjulienne@suse.de \
--cc=nsekhar@ti.com \
--cc=peda@axentia.se \
--cc=pierre-yves.mordret@st.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.