All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	Ard Biesheuvel <ardb@kernel.org>,
	Maxim Uvarov <maxim.uvarov@linaro.org>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Atish Patra <atish.patra@wdc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Jens Wiklander <jens.wiklander@linaro.org>,
	Francois Ozog <francois.ozog@linaro.org>,
	Etienne CARRIERE <etienne.carriere@st.com>,
	Takahiro Akashi <takahiro.akashi@linaro.org>,
	Patrice CHOTARD <patrice.chotard@st.com>,
	Sumit Garg <sumit.garg@linaro.org>,
	Grant Likely <Grant.Likely@arm.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Christophe Priouzeau <christophe.priouzeau@linaro.org>,
	Rouven Czerwinski <r.czerwinski@pengutronix.de>,
	Patrick DELAUNAY <patrick.delaunay@st.com>
Subject: [PATCH RFC/RFT 0/3] efi/libstub: arm32: Remove dependency on dram_base
Date: Wed,  9 Sep 2020 18:16:20 +0300	[thread overview]
Message-ID: <20200909151623.16153-1-ardb@kernel.org> (raw)

Maxim reports boot failures on platforms that describe reserved memory
regions in DT that are disjoint from system DRAM, and which are converted
to EfiReservedMemory regions by the EFI subsystem in u-boot.

As it turns out, the whole notion of discovering the base of DRAM is
problematic, and it would be better to simply rely on the EFI memory
allocation routines instead, and derive the FDT and initrd allocation
limits from the actual placement of the kernel (which is what defines
the start of the linear region anyway)

Finally, we should be able to get rid of get_dram_base() entirely.
However, as RISC-V only just started using it, we will need to address
that at a later time.

Cc: Maxim Uvarov <maxim.uvarov@linaro.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Atish Patra <atish.patra@wdc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Jens Wiklander <jens.wiklander@linaro.org>
Cc: Francois Ozog <francois.ozog@linaro.org>
Cc: Etienne CARRIERE <etienne.carriere@st.com>
Cc: Takahiro Akashi <takahiro.akashi@linaro.org>
Cc: Patrice CHOTARD <patrice.chotard@st.com>
Cc: Sumit Garg <sumit.garg@linaro.org>
Cc: Grant Likely <Grant.Likely@arm.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Christophe Priouzeau <christophe.priouzeau@linaro.org>
Cc: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: Patrick DELAUNAY <patrick.delaunay@st.com>

Ard Biesheuvel (3):
  efi/libstub: Export efi_low_alloc_above() to other units
  efi/libstub: Use low allocation for the uncompressed kernel
  efi/libstub: base FDT and initrd placement on image address not DRAM
    base

 arch/arm/include/asm/efi.h                |   6 +-
 arch/arm64/include/asm/efi.h              |   2 +-
 drivers/firmware/efi/libstub/arm32-stub.c | 177 ++++----------------
 drivers/firmware/efi/libstub/efi-stub.c   |   2 +-
 drivers/firmware/efi/libstub/efistub.h    |   3 +
 drivers/firmware/efi/libstub/relocate.c   |   4 +-
 6 files changed, 47 insertions(+), 147 deletions(-)

-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: Etienne CARRIERE <etienne.carriere@st.com>,
	Francois Ozog <francois.ozog@linaro.org>,
	Maxim Uvarov <maxim.uvarov@linaro.org>,
	Rouven Czerwinski <r.czerwinski@pengutronix.de>,
	Takahiro Akashi <takahiro.akashi@linaro.org>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Patrice CHOTARD <patrice.chotard@st.com>,
	Patrick DELAUNAY <patrick.delaunay@st.com>,
	Jens Wiklander <jens.wiklander@linaro.org>,
	Atish Patra <atish.patra@wdc.com>,
	Grant Likely <Grant.Likely@arm.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Christophe Priouzeau <christophe.priouzeau@linaro.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH RFC/RFT 0/3] efi/libstub: arm32: Remove dependency on dram_base
Date: Wed,  9 Sep 2020 18:16:20 +0300	[thread overview]
Message-ID: <20200909151623.16153-1-ardb@kernel.org> (raw)

Maxim reports boot failures on platforms that describe reserved memory
regions in DT that are disjoint from system DRAM, and which are converted
to EfiReservedMemory regions by the EFI subsystem in u-boot.

As it turns out, the whole notion of discovering the base of DRAM is
problematic, and it would be better to simply rely on the EFI memory
allocation routines instead, and derive the FDT and initrd allocation
limits from the actual placement of the kernel (which is what defines
the start of the linear region anyway)

Finally, we should be able to get rid of get_dram_base() entirely.
However, as RISC-V only just started using it, we will need to address
that at a later time.

Cc: Maxim Uvarov <maxim.uvarov@linaro.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Atish Patra <atish.patra@wdc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Jens Wiklander <jens.wiklander@linaro.org>
Cc: Francois Ozog <francois.ozog@linaro.org>
Cc: Etienne CARRIERE <etienne.carriere@st.com>
Cc: Takahiro Akashi <takahiro.akashi@linaro.org>
Cc: Patrice CHOTARD <patrice.chotard@st.com>
Cc: Sumit Garg <sumit.garg@linaro.org>
Cc: Grant Likely <Grant.Likely@arm.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: Christophe Priouzeau <christophe.priouzeau@linaro.org>
Cc: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: Patrick DELAUNAY <patrick.delaunay@st.com>

Ard Biesheuvel (3):
  efi/libstub: Export efi_low_alloc_above() to other units
  efi/libstub: Use low allocation for the uncompressed kernel
  efi/libstub: base FDT and initrd placement on image address not DRAM
    base

 arch/arm/include/asm/efi.h                |   6 +-
 arch/arm64/include/asm/efi.h              |   2 +-
 drivers/firmware/efi/libstub/arm32-stub.c | 177 ++++----------------
 drivers/firmware/efi/libstub/efi-stub.c   |   2 +-
 drivers/firmware/efi/libstub/efistub.h    |   3 +
 drivers/firmware/efi/libstub/relocate.c   |   4 +-
 6 files changed, 47 insertions(+), 147 deletions(-)

-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2020-09-09 17:19 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 15:16 Ard Biesheuvel [this message]
2020-09-09 15:16 ` [PATCH RFC/RFT 0/3] efi/libstub: arm32: Remove dependency on dram_base Ard Biesheuvel
2020-09-09 15:16 ` [PATCH RFC/RFT 1/3] efi/libstub: Export efi_low_alloc_above() to other units Ard Biesheuvel
2020-09-09 15:16   ` Ard Biesheuvel
2020-09-09 15:16 ` [PATCH RFC/RFT 2/3] efi/libstub: Use low allocation for the uncompressed kernel Ard Biesheuvel
2020-09-09 15:16   ` Ard Biesheuvel
2020-09-09 15:16 ` [PATCH RFC/RFT 3/3] efi/libstub: base FDT and initrd placement on image address not DRAM base Ard Biesheuvel
2020-09-09 15:16   ` Ard Biesheuvel
2020-09-09 15:25 ` [PATCH RFC/RFT 0/3] efi/libstub: arm32: Remove dependency on dram_base Grant Likely
2020-09-09 15:25   ` Grant Likely
2020-09-09 15:30   ` Ard Biesheuvel
2020-09-09 15:30     ` Ard Biesheuvel
2020-09-09 20:52 ` Palmer Dabbelt
2020-09-09 20:52   ` Palmer Dabbelt
2020-09-09 21:44   ` Atish Patra
2020-09-09 21:44     ` Atish Patra
2020-09-10  1:34     ` Atish Patra
2020-09-10  1:34       ` Atish Patra
2020-09-10 10:04       ` Ard Biesheuvel
2020-09-10 10:04         ` Ard Biesheuvel
2020-09-10 14:08         ` Ard Biesheuvel
2020-09-10 14:08           ` Ard Biesheuvel
2020-09-10 23:32           ` Atish Patra
2020-09-10 23:32             ` Atish Patra
2020-09-11  2:16           ` Palmer Dabbelt
2020-09-11  2:16             ` Palmer Dabbelt
2020-09-11  7:56             ` Ard Biesheuvel
2020-09-11  7:56               ` Ard Biesheuvel
2020-09-11 10:27               ` Maxim Uvarov
2020-09-11 10:27                 ` Maxim Uvarov
2020-09-11 18:45                 ` Ard Biesheuvel
2020-09-11 18:45                   ` Ard Biesheuvel
2020-09-16 15:43                   ` Maxim Uvarov
2020-09-16 15:43                     ` Maxim Uvarov
2020-09-16 15:58                     ` Ard Biesheuvel
2020-09-16 15:58                       ` Ard Biesheuvel
2020-09-16 16:02               ` Ard Biesheuvel
2020-09-16 16:02                 ` Ard Biesheuvel
2020-09-16 22:01                 ` Atish Patra
2020-09-16 22:01                   ` Atish Patra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909151623.16153-1-ardb@kernel.org \
    --to=ardb@kernel.org \
    --cc=Grant.Likely@arm.com \
    --cc=atish.patra@wdc.com \
    --cc=christophe.priouzeau@linaro.org \
    --cc=etienne.carriere@st.com \
    --cc=francois.ozog@linaro.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jens.wiklander@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=maxim.uvarov@linaro.org \
    --cc=palmer@dabbelt.com \
    --cc=patrice.chotard@st.com \
    --cc=patrick.delaunay@st.com \
    --cc=r.czerwinski@pengutronix.de \
    --cc=sumit.garg@linaro.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.