All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dmaengine: sf-pdma: remove unused 'desc'
@ 2020-09-14  5:53 Vinod Koul
  2020-09-18  7:00 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2020-09-14  5:53 UTC (permalink / raw)
  To: dmaengine, Green Wan; +Cc: Vinod Koul, linux-kernel, Stephen Rothwell

'desc' variable is now defined but not used in sf_pdma_donebh_tasklet(),
causing this warning:

drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]

Remove this unused variable

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/sf-pdma/sf-pdma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index 754994087e5f..1e66c6990d81 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -284,7 +284,6 @@ static void sf_pdma_free_desc(struct virt_dma_desc *vdesc)
 static void sf_pdma_donebh_tasklet(unsigned long arg)
 {
 	struct sf_pdma_chan *chan = (struct sf_pdma_chan *)arg;
-	struct sf_pdma_desc *desc = chan->desc;
 	unsigned long flags;
 
 	spin_lock_irqsave(&chan->lock, flags);
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dmaengine: sf-pdma: remove unused 'desc'
  2020-09-14  5:53 [PATCH] dmaengine: sf-pdma: remove unused 'desc' Vinod Koul
@ 2020-09-18  7:00 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-09-18  7:00 UTC (permalink / raw)
  To: dmaengine, Green Wan; +Cc: linux-kernel, Stephen Rothwell

On 14-09-20, 11:23, Vinod Koul wrote:
> 'desc' variable is now defined but not used in sf_pdma_donebh_tasklet(),
> causing this warning:
> 
> drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
> drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]
> 
> Remove this unused variable

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-18  7:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14  5:53 [PATCH] dmaengine: sf-pdma: remove unused 'desc' Vinod Koul
2020-09-18  7:00 ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.