From: Matthew Wilcox <willy@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net
Subject: Re: [PATCH v2 9/9] iomap: Change calling convention for zeroing
Date: Thu, 17 Sep 2020 23:11:15 +0100 [thread overview]
Message-ID: <20200917221115.GY5449@casper.infradead.org> (raw)
In-Reply-To: <20200917220500.GR7955@magnolia>
On Thu, Sep 17, 2020 at 03:05:00PM -0700, Darrick J. Wong wrote:
> > -static loff_t
> > -iomap_zero_range_actor(struct inode *inode, loff_t pos, loff_t count,
> > - void *data, struct iomap *iomap, struct iomap *srcmap)
> > +static loff_t iomap_zero_range_actor(struct inode *inode, loff_t pos,
> > + loff_t length, void *data, struct iomap *iomap,
>
> Any reason not to change @length and the return value to s64?
Because it's an actor, passed to iomap_apply, so its types have to match.
I can change that, but it'll be a separate patch series.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net
Subject: Re: [PATCH v2 9/9] iomap: Change calling convention for zeroing
Date: Thu, 17 Sep 2020 23:11:15 +0100 [thread overview]
Message-ID: <20200917221115.GY5449@casper.infradead.org> (raw)
In-Reply-To: <20200917220500.GR7955@magnolia>
On Thu, Sep 17, 2020 at 03:05:00PM -0700, Darrick J. Wong wrote:
> > -static loff_t
> > -iomap_zero_range_actor(struct inode *inode, loff_t pos, loff_t count,
> > - void *data, struct iomap *iomap, struct iomap *srcmap)
> > +static loff_t iomap_zero_range_actor(struct inode *inode, loff_t pos,
> > + loff_t length, void *data, struct iomap *iomap,
>
> Any reason not to change @length and the return value to s64?
Because it's an actor, passed to iomap_apply, so its types have to match.
I can change that, but it'll be a separate patch series.
next prev parent reply other threads:[~2020-09-17 22:11 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 23:46 [PATCH v2 0/9] THP iomap patches for 5.10 Matthew Wilcox (Oracle)
2020-09-10 23:46 ` Matthew Wilcox (Oracle)
2020-09-10 23:46 ` [PATCH v2 1/9] iomap: Fix misplaced page flushing Matthew Wilcox (Oracle)
2020-09-10 23:46 ` Matthew Wilcox (Oracle)
2020-09-10 23:47 ` [PATCH v2 2/9] fs: Introduce i_blocks_per_page Matthew Wilcox (Oracle)
2020-09-10 23:47 ` Matthew Wilcox (Oracle)
2020-09-15 14:58 ` Dave Kleikamp
2020-09-15 14:58 ` Dave Kleikamp
2020-09-15 15:40 ` David Laight
2020-09-15 15:40 ` David Laight
2020-09-15 15:49 ` Matthew Wilcox
2020-09-15 15:49 ` Matthew Wilcox
2020-09-10 23:47 ` [PATCH v2 3/9] iomap: Use kzalloc to allocate iomap_page Matthew Wilcox (Oracle)
2020-09-10 23:47 ` Matthew Wilcox (Oracle)
2020-09-10 23:47 ` [PATCH v2 4/9] iomap: Use bitmap ops to set uptodate bits Matthew Wilcox (Oracle)
2020-09-10 23:47 ` Matthew Wilcox (Oracle)
2020-09-10 23:47 ` [PATCH v2 5/9] iomap: Support arbitrarily many blocks per page Matthew Wilcox (Oracle)
2020-09-10 23:47 ` Matthew Wilcox (Oracle)
2020-09-11 5:36 ` Christoph Hellwig
2020-09-11 5:36 ` Christoph Hellwig
2020-09-17 22:00 ` Darrick J. Wong
2020-09-17 22:00 ` Darrick J. Wong
2020-09-22 16:23 ` Qian Cai
2020-09-22 16:23 ` Qian Cai
2020-09-22 17:05 ` Matthew Wilcox
2020-09-22 17:05 ` Matthew Wilcox
2020-09-22 17:25 ` Qian Cai
2020-09-22 17:25 ` Qian Cai
2020-09-23 1:06 ` Qian Cai
2020-09-23 1:06 ` Qian Cai
2020-09-23 2:48 ` Matthew Wilcox
2020-09-23 2:48 ` Matthew Wilcox
2020-09-23 5:00 ` Darrick J. Wong
2020-09-23 5:00 ` Darrick J. Wong
2020-09-23 18:59 ` Matthew Wilcox
2020-09-23 18:59 ` Matthew Wilcox
2020-09-23 16:55 ` Qian Cai
2020-09-23 16:55 ` Qian Cai
2020-09-24 1:07 ` Matthew Wilcox
2020-09-24 1:07 ` Matthew Wilcox
2020-09-10 23:47 ` [PATCH v2 6/9] iomap: Convert read_count to read_bytes_pending Matthew Wilcox (Oracle)
2020-09-10 23:47 ` Matthew Wilcox (Oracle)
2020-09-11 5:36 ` Christoph Hellwig
2020-09-11 5:36 ` Christoph Hellwig
2020-09-17 22:02 ` Darrick J. Wong
2020-09-17 22:02 ` Darrick J. Wong
2020-09-10 23:47 ` [PATCH v2 7/9] iomap: Convert write_count to write_bytes_pending Matthew Wilcox (Oracle)
2020-09-10 23:47 ` Matthew Wilcox (Oracle)
2020-09-17 22:02 ` Darrick J. Wong
2020-09-17 22:02 ` Darrick J. Wong
2020-09-10 23:47 ` [PATCH v2 8/9] iomap: Convert iomap_write_end types Matthew Wilcox (Oracle)
2020-09-10 23:47 ` Matthew Wilcox (Oracle)
2020-09-17 22:03 ` Darrick J. Wong
2020-09-17 22:03 ` Darrick J. Wong
2020-09-10 23:47 ` [PATCH v2 9/9] iomap: Change calling convention for zeroing Matthew Wilcox (Oracle)
2020-09-10 23:47 ` Matthew Wilcox (Oracle)
2020-09-11 6:42 ` Christoph Hellwig
2020-09-11 6:42 ` Christoph Hellwig
2020-09-17 22:05 ` Darrick J. Wong
2020-09-17 22:05 ` Darrick J. Wong
2020-09-17 22:11 ` Matthew Wilcox [this message]
2020-09-17 22:11 ` Matthew Wilcox
2020-09-17 22:18 ` Darrick J. Wong
2020-09-17 22:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917221115.GY5449@casper.infradead.org \
--to=willy@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=shaggy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.