From: Will Deacon <will@kernel.org>
To: David Brazdil <dbrazdil@google.com>
Cc: kvmarm@lists.cs.columbia.edu,
Catalin Marinas <catalin.marinas@arm.com>,
Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Andrew Scull <ascull@google.com>
Subject: Re: [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu
Date: Mon, 21 Sep 2020 18:15:05 +0100 [thread overview]
Message-ID: <20200921171503.GB2822@willie-the-truck> (raw)
In-Reply-To: <20200921145320.2b2ipdj6w4morjc3@google.com>
On Mon, Sep 21, 2020 at 03:53:20PM +0100, David Brazdil wrote:
> > Cosmetic, but I think it would be cleaner just to define two variants of the
> > macro here:
> >
> > #if defined(__KVM_NVHE_HYPERVISOR__) || defined(__KVM_VHE_HYPERVISOR__)
> > .macro this_cpu_offset, dst
> > mrs \dst, tpidr_el2
> > .endm
> > #else
> > .macro this_cpu_offset, dst
> > alternative_if_not ARM64_HAS_VIRT_HOST_EXTN
> > mrs \dst, tpidr_el1
> > alternative_else
> > mrs \dst, tpidr_el2
> > alternative_endif
> > .endm
> > #endif
>
> Sure.
Ta.
> > (and should we have a shorthand __HYPERVISOR define to avoid the NVHE || VHE
> > logic?)
>
> Happy to add this but let's agree on the details.
> * name: just __HYPERVISOR or __KVM_HYPERVISOR__?
Hey, I leave the hard decisions to others!
> * defined where? I'm wary of defining it in a header file because then sombody
> will forget to add it and 'ifdef HYP' will be skipped. So I'd put this as
> another '-D__HYPERVISOR' in the build rules. Do you agree?
Hmm, that's a good point. Leave that part as-is for now then and we can
tackle it separately if it comes up again.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: David Brazdil <dbrazdil@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Marc Zyngier <maz@kernel.org>, Tejun Heo <tj@kernel.org>,
Dennis Zhou <dennis@kernel.org>, Christoph Lameter <cl@linux.com>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu
Date: Mon, 21 Sep 2020 18:15:05 +0100 [thread overview]
Message-ID: <20200921171503.GB2822@willie-the-truck> (raw)
In-Reply-To: <20200921145320.2b2ipdj6w4morjc3@google.com>
On Mon, Sep 21, 2020 at 03:53:20PM +0100, David Brazdil wrote:
> > Cosmetic, but I think it would be cleaner just to define two variants of the
> > macro here:
> >
> > #if defined(__KVM_NVHE_HYPERVISOR__) || defined(__KVM_VHE_HYPERVISOR__)
> > .macro this_cpu_offset, dst
> > mrs \dst, tpidr_el2
> > .endm
> > #else
> > .macro this_cpu_offset, dst
> > alternative_if_not ARM64_HAS_VIRT_HOST_EXTN
> > mrs \dst, tpidr_el1
> > alternative_else
> > mrs \dst, tpidr_el2
> > alternative_endif
> > .endm
> > #endif
>
> Sure.
Ta.
> > (and should we have a shorthand __HYPERVISOR define to avoid the NVHE || VHE
> > logic?)
>
> Happy to add this but let's agree on the details.
> * name: just __HYPERVISOR or __KVM_HYPERVISOR__?
Hey, I leave the hard decisions to others!
> * defined where? I'm wary of defining it in a header file because then sombody
> will forget to add it and 'ifdef HYP' will be skipped. So I'd put this as
> another '-D__HYPERVISOR' in the build rules. Do you agree?
Hmm, that's a good point. Leave that part as-is for now then and we can
tackle it separately if it comes up again.
Will
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: David Brazdil <dbrazdil@google.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org,
Marc Zyngier <maz@kernel.org>, Tejun Heo <tj@kernel.org>,
Dennis Zhou <dennis@kernel.org>, Christoph Lameter <cl@linux.com>,
kernel-team@android.com, kvmarm@lists.cs.columbia.edu,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Andrew Scull <ascull@google.com>
Subject: Re: [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu
Date: Mon, 21 Sep 2020 18:15:05 +0100 [thread overview]
Message-ID: <20200921171503.GB2822@willie-the-truck> (raw)
In-Reply-To: <20200921145320.2b2ipdj6w4morjc3@google.com>
On Mon, Sep 21, 2020 at 03:53:20PM +0100, David Brazdil wrote:
> > Cosmetic, but I think it would be cleaner just to define two variants of the
> > macro here:
> >
> > #if defined(__KVM_NVHE_HYPERVISOR__) || defined(__KVM_VHE_HYPERVISOR__)
> > .macro this_cpu_offset, dst
> > mrs \dst, tpidr_el2
> > .endm
> > #else
> > .macro this_cpu_offset, dst
> > alternative_if_not ARM64_HAS_VIRT_HOST_EXTN
> > mrs \dst, tpidr_el1
> > alternative_else
> > mrs \dst, tpidr_el2
> > alternative_endif
> > .endm
> > #endif
>
> Sure.
Ta.
> > (and should we have a shorthand __HYPERVISOR define to avoid the NVHE || VHE
> > logic?)
>
> Happy to add this but let's agree on the details.
> * name: just __HYPERVISOR or __KVM_HYPERVISOR__?
Hey, I leave the hard decisions to others!
> * defined where? I'm wary of defining it in a header file because then sombody
> will forget to add it and 'ifdef HYP' will be skipped. So I'd put this as
> another '-D__HYPERVISOR' in the build rules. Do you agree?
Hmm, that's a good point. Leave that part as-is for now then and we can
tackle it separately if it comes up again.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-21 17:15 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 17:34 [PATCH v3 00/10] Independent per-CPU data section for nVHE David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` [PATCH v3 01/11] kvm: arm64: Partially link nVHE hyp code, simplify HYPCOPY David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 8:51 ` Will Deacon
2020-09-18 8:51 ` Will Deacon
2020-09-18 8:51 ` Will Deacon
2020-09-22 17:55 ` David Brazdil
2020-09-22 17:55 ` David Brazdil
2020-09-22 17:55 ` David Brazdil
2020-09-16 17:34 ` [PATCH v3 02/11] kvm: arm64: Move nVHE hyp namespace macros to hyp_image.h David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 8:52 ` Will Deacon
2020-09-18 8:52 ` Will Deacon
2020-09-18 8:52 ` Will Deacon
2020-09-16 17:34 ` [PATCH v3 03/11] kvm: arm64: Only define __kvm_ex_table for CONFIG_KVM David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 9:00 ` Will Deacon
2020-09-18 9:00 ` Will Deacon
2020-09-18 9:00 ` Will Deacon
2020-09-16 17:34 ` [PATCH v3 04/11] kvm: arm64: Remove __hyp_this_cpu_read David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 9:00 ` Will Deacon
2020-09-18 9:00 ` Will Deacon
2020-09-18 9:00 ` Will Deacon
2020-09-21 13:43 ` David Brazdil
2020-09-21 13:43 ` David Brazdil
2020-09-21 13:43 ` David Brazdil
2020-09-16 17:34 ` [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 9:05 ` Will Deacon
2020-09-18 9:05 ` Will Deacon
2020-09-18 9:05 ` Will Deacon
2020-09-21 14:53 ` David Brazdil
2020-09-21 14:53 ` David Brazdil
2020-09-21 14:53 ` David Brazdil
2020-09-21 17:15 ` Will Deacon [this message]
2020-09-21 17:15 ` Will Deacon
2020-09-21 17:15 ` Will Deacon
2020-09-16 17:34 ` [PATCH v3 06/11] kvm: arm64: Add helpers for accessing nVHE hyp per-cpu vars David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 9:24 ` Will Deacon
2020-09-18 9:24 ` Will Deacon
2020-09-18 9:24 ` Will Deacon
2020-09-16 17:34 ` [PATCH v3 07/11] kvm: arm64: Duplicate arm64_ssbd_callback_required for nVHE hyp David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 11:59 ` Will Deacon
2020-09-18 11:59 ` Will Deacon
2020-09-18 11:59 ` Will Deacon
2020-09-22 18:07 ` David Brazdil
2020-09-22 18:07 ` David Brazdil
2020-09-22 18:07 ` David Brazdil
2020-09-16 17:34 ` [PATCH v3 08/11] kvm: arm64: Create separate instances of kvm_host_data for VHE/nVHE David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 11:58 ` Will Deacon
2020-09-18 11:58 ` Will Deacon
2020-09-18 11:58 ` Will Deacon
2020-09-16 17:34 ` [PATCH v3 09/11] kvm: arm64: Mark hyp stack pages reserved David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 12:00 ` Will Deacon
2020-09-18 12:00 ` Will Deacon
2020-09-18 12:00 ` Will Deacon
2020-09-22 18:08 ` David Brazdil
2020-09-22 18:08 ` David Brazdil
2020-09-22 18:08 ` David Brazdil
2020-09-16 17:34 ` [PATCH v3 10/11] kvm: arm64: Set up hyp percpu data for nVHE David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-18 12:22 ` Will Deacon
2020-09-18 12:22 ` Will Deacon
2020-09-18 12:22 ` Will Deacon
2020-09-22 18:34 ` David Brazdil
2020-09-22 18:34 ` David Brazdil
2020-09-22 18:34 ` David Brazdil
2020-09-16 17:34 ` [PATCH v3 11/11] kvm: arm64: Remove unnecessary hyp mappings David Brazdil
2020-09-16 17:34 ` David Brazdil
2020-09-16 17:34 ` David Brazdil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921171503.GB2822@willie-the-truck \
--to=will@kernel.org \
--cc=ascull@google.com \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=dbrazdil@google.com \
--cc=dennis@kernel.org \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.