All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, lvivier@redhat.com
Subject: Re: [PATCH v2 5/7] arm/pmu: Fix inline assembly for Clang
Date: Thu, 1 Oct 2020 14:02:42 +0200	[thread overview]
Message-ID: <20201001120242.ywmlfn3t6d277j4x@kamzik.brq.redhat.com> (raw)
In-Reply-To: <331cdf48-d406-1a86-f929-c18f102f339c@redhat.com>

On Thu, Oct 01, 2020 at 12:50:48PM +0200, Thomas Huth wrote:
> On 01/10/2020 11.14, Andrew Jones wrote:
> > On Thu, Oct 01, 2020 at 11:12:43AM +0200, Andrew Jones wrote:
> >> On Thu, Oct 01, 2020 at 09:22:32AM +0200, Thomas Huth wrote:
> >>> Clang complains here:
> >>>
> >>> arm/pmu.c:201:16: error: value size does not match register size specified by
> >>>  the constraint and modifier [-Werror,-Wasm-operand-widths]
> >>>         : [pmcr] "r" (pmcr)
> >>>                       ^
> >>> arm/pmu.c:194:18: note: use constraint modifier "w"
> >>>         "       msr     pmcr_el0, %[pmcr]\n"
> >>>                                   ^~~~~~~
> >>>                                   %w[pmcr]
> >>> arm/pmu.c:200:17: error: value size does not match register size specified by
> >>>  the constraint and modifier [-Werror,-Wasm-operand-widths]
> >>>         : [loop] "+r" (loop)
> >>>                        ^
> >>> arm/pmu.c:196:11: note: use constraint modifier "w"
> >>>         "1:     subs    %[loop], %[loop], #1\n"
> >>>                         ^~~~~~~
> >>>                         %w[loop]
> >>> arm/pmu.c:200:17: error: value size does not match register size specified by
> >>>  the constraint and modifier [-Werror,-Wasm-operand-widths]
> >>>         : [loop] "+r" (loop)
> >>>                        ^
> >>> arm/pmu.c:196:20: note: use constraint modifier "w"
> >>>         "1:     subs    %[loop], %[loop], #1\n"
> >>>                                  ^~~~~~~
> >>>                                  %w[loop]
> >>> arm/pmu.c:284:35: error: value size does not match register size specified
> >>>  by the constraint and modifier [-Werror,-Wasm-operand-widths]
> >>>         : [addr] "r" (addr), [pmcr] "r" (pmcr), [loop] "r" (loop)
> >>>                                          ^
> >>> arm/pmu.c:274:28: note: use constraint modifier "w"
> >>>         "       msr     pmcr_el0, %[pmcr]\n"
> >>>                                   ^~~~~~~
> >>>                                   %w[pmcr]
> >>> arm/pmu.c:284:54: error: value size does not match register size specified
> >>>  by the constraint and modifier [-Werror,-Wasm-operand-widths]
> >>>         : [addr] "r" (addr), [pmcr] "r" (pmcr), [loop] "r" (loop)
> >>>                                                             ^
> >>> arm/pmu.c:276:23: note: use constraint modifier "w"
> >>>         "       mov     x10, %[loop]\n"
> >>>                              ^~~~~~~
> >>>                              %w[loop]
> >>>
> >>> pmcr should be 64-bit since it is a sysreg, but for loop we can use the
> >>> "w" modifier.
> >>>
> >>> Suggested-by: Drew Jones <drjones@redhat.com>
> > 
> > Not a huge deal, but I use my official first name 'Andrew' on my tags.
> > I know, I like confusing people by flipping back and forth between
> > Andrew and Drew...
> 
> Sorry, IIRC I simply copy-n-pasted your name and e-mail address from the
> MAINTAINERS file ... maybe you should fix it there to avoid such situations?
>

Thanks for pointing that out. Patch sent.

drew 


  reply	other threads:[~2020-10-01 12:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01  7:22 [PATCH v2 0/7] Update travis CI Thomas Huth
2020-10-01  7:22 ` [PATCH v2 1/7] travis.yml: Rework the x86 64-bit tests Thomas Huth
2020-10-01  7:22 ` [PATCH v2 2/7] travis.yml: Refresh the x86 32-bit test list Thomas Huth
2020-10-01  7:22 ` [PATCH v2 3/7] travis.yml: Add the selftest-setup ppc64 test Thomas Huth
2020-10-01  7:22 ` [PATCH v2 4/7] kbuild: fix asm-offset generation to work with clang Thomas Huth
2020-10-01  9:12   ` Andrew Jones
2020-10-01  7:22 ` [PATCH v2 5/7] arm/pmu: Fix inline assembly for Clang Thomas Huth
2020-10-01  9:12   ` Andrew Jones
2020-10-01  9:14     ` Andrew Jones
2020-10-01 10:50       ` Thomas Huth
2020-10-01 12:02         ` Andrew Jones [this message]
2020-10-01  7:22 ` [PATCH v2 6/7] lib/arm64/spinlock: " Thomas Huth
2020-10-01  9:12   ` Andrew Jones
2020-10-01  7:22 ` [PATCH v2 7/7] travis.yml: Rework the aarch64 jobs Thomas Huth
2020-10-01  9:18 ` [PATCH v2 0/7] Update travis CI Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001120242.ywmlfn3t6d277j4x@kamzik.brq.redhat.com \
    --to=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.