All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Devin Bayer <dev@doubly.so>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] nft: migrate man page examples with `meter` directive to sets
Date: Thu, 1 Oct 2020 14:26:38 +0200	[thread overview]
Message-ID: <20201001122638.GA17685@salvia> (raw)
In-Reply-To: <b35b744f-a29c-d76b-6969-8cf6371c2a1a@doubly.so>

Applied with small nitpick.

On Thu, Oct 01, 2020 at 11:30:27AM +0200, Devin Bayer wrote:
> +# declare a set, bound to table "filter", in family "ip".
> +# Timeout and size are mandatory because we will add elements from packet
> path.
> +# Entries will timeout after one minute, after which they might be
> +# re-added if limit condition persists.
> +nft add set ip filter blackhole \
> +    "{ type ipv4_addr; timeout 1m; size 65536 }"
> +
> +# declare a set to store the limit per saddr.
> +# This must be separate from blackhole since the timeout is different
> +nft add set ip filter flood \
> +    "{ type ipv4_addr; flags dynamic; timeout 10s; size 128000 }"

Missing semi-colons after size.

Please, double-check that what I have applied looks correct to you.

Thanks.

  reply	other threads:[~2020-10-01 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01  9:30 [PATCH] nft: migrate man page examples with `meter` directive to sets Devin Bayer
2020-10-01 12:26 ` Pablo Neira Ayuso [this message]
2020-10-01 13:04   ` Devin Bayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001122638.GA17685@salvia \
    --to=pablo@netfilter.org \
    --cc=dev@doubly.so \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.