From: kernel test robot <lkp@intel.com>
To: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org
Cc: kbuild-all@lists.01.org,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Michael Tuexen <tuexen@fh-muenster.de>,
davem@davemloft.net
Subject: Re: [PATCHv2 net-next 17/17] sctp: enable udp tunneling socks
Date: Thu, 8 Oct 2020 23:46:07 +0800 [thread overview]
Message-ID: <202010082357.BLEOWVCz-lkp@intel.com> (raw)
In-Reply-To: <8ce0fde0d093d62e8969d1788a13921ed1516ad6.1602150362.git.lucien.xin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2814 bytes --]
Hi Xin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9faebeb2d80065926dfbc09cb73b1bb7779a89cd
config: i386-randconfig-s002-20201008 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-218-gc0e96d6d-dirty
# https://github.com/0day-ci/linux/commit/7dab31e8c96fab2089a651d5a6d06bcf92b011ad
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211
git checkout 7dab31e8c96fab2089a651d5a6d06bcf92b011ad
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
echo
echo "sparse warnings: (new ones prefixed by >>)"
echo
>> net/sctp/sysctl.c:532:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] udp_port @@ got int udp_port @@
>> net/sctp/sysctl.c:532:39: sparse: expected restricted __be16 [usertype] udp_port
>> net/sctp/sysctl.c:532:39: sparse: got int udp_port
vim +532 net/sctp/sysctl.c
500
501 static int proc_sctp_do_udp_port(struct ctl_table *ctl, int write,
502 void *buffer, size_t *lenp, loff_t *ppos)
503 {
504 struct net *net = current->nsproxy->net_ns;
505 unsigned int min = *(unsigned int *)ctl->extra1;
506 unsigned int max = *(unsigned int *)ctl->extra2;
507 struct ctl_table tbl;
508 int ret, new_value;
509
510 memset(&tbl, 0, sizeof(struct ctl_table));
511 tbl.maxlen = sizeof(unsigned int);
512
513 if (write)
514 tbl.data = &new_value;
515 else
516 tbl.data = &net->sctp.udp_port;
517
518 ret = proc_dointvec(&tbl, write, buffer, lenp, ppos);
519 if (write && ret == 0) {
520 struct sock *sk = net->sctp.ctl_sock;
521
522 if (new_value > max || new_value < min)
523 return -EINVAL;
524
525 net->sctp.udp_port = new_value;
526 sctp_udp_sock_stop(net);
527 ret = sctp_udp_sock_start(net);
528 if (ret)
529 net->sctp.udp_port = 0;
530
531 lock_sock(sk);
> 532 sctp_sk(sk)->udp_port = net->sctp.udp_port;
533 release_sock(sk);
534 }
535
536 return ret;
537 }
538
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30577 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org
Cc: kbuild-all@lists.01.org,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Michael Tuexen <tuexen@fh-muenster.de>,
davem@davemloft.net
Subject: Re: [PATCHv2 net-next 17/17] sctp: enable udp tunneling socks
Date: Thu, 08 Oct 2020 15:46:07 +0000 [thread overview]
Message-ID: <202010082357.BLEOWVCz-lkp@intel.com> (raw)
In-Reply-To: <8ce0fde0d093d62e8969d1788a13921ed1516ad6.1602150362.git.lucien.xin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2814 bytes --]
Hi Xin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9faebeb2d80065926dfbc09cb73b1bb7779a89cd
config: i386-randconfig-s002-20201008 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-218-gc0e96d6d-dirty
# https://github.com/0day-ci/linux/commit/7dab31e8c96fab2089a651d5a6d06bcf92b011ad
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211
git checkout 7dab31e8c96fab2089a651d5a6d06bcf92b011ad
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
echo
echo "sparse warnings: (new ones prefixed by >>)"
echo
>> net/sctp/sysctl.c:532:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] udp_port @@ got int udp_port @@
>> net/sctp/sysctl.c:532:39: sparse: expected restricted __be16 [usertype] udp_port
>> net/sctp/sysctl.c:532:39: sparse: got int udp_port
vim +532 net/sctp/sysctl.c
500
501 static int proc_sctp_do_udp_port(struct ctl_table *ctl, int write,
502 void *buffer, size_t *lenp, loff_t *ppos)
503 {
504 struct net *net = current->nsproxy->net_ns;
505 unsigned int min = *(unsigned int *)ctl->extra1;
506 unsigned int max = *(unsigned int *)ctl->extra2;
507 struct ctl_table tbl;
508 int ret, new_value;
509
510 memset(&tbl, 0, sizeof(struct ctl_table));
511 tbl.maxlen = sizeof(unsigned int);
512
513 if (write)
514 tbl.data = &new_value;
515 else
516 tbl.data = &net->sctp.udp_port;
517
518 ret = proc_dointvec(&tbl, write, buffer, lenp, ppos);
519 if (write && ret == 0) {
520 struct sock *sk = net->sctp.ctl_sock;
521
522 if (new_value > max || new_value < min)
523 return -EINVAL;
524
525 net->sctp.udp_port = new_value;
526 sctp_udp_sock_stop(net);
527 ret = sctp_udp_sock_start(net);
528 if (ret)
529 net->sctp.udp_port = 0;
530
531 lock_sock(sk);
> 532 sctp_sk(sk)->udp_port = net->sctp.udp_port;
533 release_sock(sk);
534 }
535
536 return ret;
537 }
538
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30577 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCHv2 net-next 17/17] sctp: enable udp tunneling socks
Date: Thu, 08 Oct 2020 23:46:07 +0800 [thread overview]
Message-ID: <202010082357.BLEOWVCz-lkp@intel.com> (raw)
In-Reply-To: <8ce0fde0d093d62e8969d1788a13921ed1516ad6.1602150362.git.lucien.xin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2891 bytes --]
Hi Xin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9faebeb2d80065926dfbc09cb73b1bb7779a89cd
config: i386-randconfig-s002-20201008 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-218-gc0e96d6d-dirty
# https://github.com/0day-ci/linux/commit/7dab31e8c96fab2089a651d5a6d06bcf92b011ad
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211
git checkout 7dab31e8c96fab2089a651d5a6d06bcf92b011ad
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
echo
echo "sparse warnings: (new ones prefixed by >>)"
echo
>> net/sctp/sysctl.c:532:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] udp_port @@ got int udp_port @@
>> net/sctp/sysctl.c:532:39: sparse: expected restricted __be16 [usertype] udp_port
>> net/sctp/sysctl.c:532:39: sparse: got int udp_port
vim +532 net/sctp/sysctl.c
500
501 static int proc_sctp_do_udp_port(struct ctl_table *ctl, int write,
502 void *buffer, size_t *lenp, loff_t *ppos)
503 {
504 struct net *net = current->nsproxy->net_ns;
505 unsigned int min = *(unsigned int *)ctl->extra1;
506 unsigned int max = *(unsigned int *)ctl->extra2;
507 struct ctl_table tbl;
508 int ret, new_value;
509
510 memset(&tbl, 0, sizeof(struct ctl_table));
511 tbl.maxlen = sizeof(unsigned int);
512
513 if (write)
514 tbl.data = &new_value;
515 else
516 tbl.data = &net->sctp.udp_port;
517
518 ret = proc_dointvec(&tbl, write, buffer, lenp, ppos);
519 if (write && ret == 0) {
520 struct sock *sk = net->sctp.ctl_sock;
521
522 if (new_value > max || new_value < min)
523 return -EINVAL;
524
525 net->sctp.udp_port = new_value;
526 sctp_udp_sock_stop(net);
527 ret = sctp_udp_sock_start(net);
528 if (ret)
529 net->sctp.udp_port = 0;
530
531 lock_sock(sk);
> 532 sctp_sk(sk)->udp_port = net->sctp.udp_port;
533 release_sock(sk);
534 }
535
536 return ret;
537 }
538
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30577 bytes --]
next prev parent reply other threads:[~2020-10-08 15:46 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 9:47 [PATCHv2 net-next 00/17] sctp: Implement RFC6951: UDP Encapsulation of SCTP Xin Long
2020-10-08 9:47 ` Xin Long
2020-10-08 9:47 ` [PATCHv2 net-next 01/17] udp: check udp sock encap_type in __udp_lib_err Xin Long
2020-10-08 9:47 ` Xin Long
2020-10-08 9:47 ` [PATCHv2 net-next 02/17] udp6: move the mss check after udp gso tunnel processing Xin Long
2020-10-08 9:47 ` Xin Long
2020-10-08 9:47 ` [PATCHv2 net-next 03/17] udp: do checksum properly in skb_udp_tunnel_segment Xin Long
2020-10-08 9:47 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 04/17] udp: support sctp over udp " Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 05/17] sctp: create udp4 sock and add its encap_rcv Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 06/17] sctp: create udp6 sock and set " Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 07/17] sctp: add encap_err_lookup for udp encap socks Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 08/17] sctp: add encap_port for netns sock asoc and transport Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 09/17] sctp: add SCTP_REMOTE_UDP_ENCAPS_PORT sockopt Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 10/17] sctp: allow changing transport encap_port by peer packets Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 11/17] sctp: add udphdr to overhead when udp_port is set Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 12/17] sctp: call sk_setup_caps in sctp_packet_transmit instead Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 13/17] sctp: support for sending packet over udp4 sock Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 14/17] sctp: support for sending packet over udp6 sock Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 15/17] sctp: add the error cause for new encapsulation port restart Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 16/17] sctp: handle the init chunk matching an existing asoc Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 9:48 ` [PATCHv2 net-next 17/17] sctp: enable udp tunneling socks Xin Long
2020-10-08 9:48 ` Xin Long
2020-10-08 15:46 ` kernel test robot [this message]
2020-10-08 15:46 ` kernel test robot
2020-10-08 15:46 ` kernel test robot
2020-10-09 2:02 ` Xin Long
2020-10-09 2:02 ` Xin Long
2020-10-09 2:02 ` Xin Long
2020-10-08 14:33 ` [PATCHv2 net-next 15/17] sctp: add the error cause for new encapsulation port restart kernel test robot
2020-10-08 14:33 ` kernel test robot
2020-10-08 14:33 ` kernel test robot
2020-10-08 13:10 ` [PATCHv2 net-next 09/17] sctp: add SCTP_REMOTE_UDP_ENCAPS_PORT sockopt kernel test robot
2020-10-08 13:10 ` kernel test robot
2020-10-08 13:10 ` kernel test robot
2020-10-08 21:18 ` [PATCHv2 net-next 06/17] sctp: create udp6 sock and set its encap_rcv kernel test robot
2020-10-08 21:18 ` kernel test robot
2020-10-08 21:18 ` kernel test robot
2020-10-09 1:59 ` Xin Long
2020-10-09 1:59 ` Xin Long
2020-10-09 1:59 ` Xin Long
2020-10-08 18:29 ` [PATCHv2 net-next 05/17] sctp: create udp4 sock and add " kernel test robot
2020-10-08 18:29 ` kernel test robot
2020-10-08 18:29 ` kernel test robot
2020-10-09 1:59 ` Xin Long
2020-10-09 1:59 ` Xin Long
2020-10-09 1:59 ` Xin Long
2020-10-08 10:01 ` [PATCHv2 net-next 04/17] udp: support sctp over udp in skb_udp_tunnel_segment Xin Long
2020-10-08 10:01 ` Xin Long
2020-10-08 10:01 ` [PATCHv2 net-next 03/17] udp: do checksum properly " Xin Long
2020-10-08 10:01 ` Xin Long
2020-10-08 12:44 ` [PATCHv2 net-next 02/17] udp6: move the mss check after udp gso tunnel processing Willem de Bruijn
2020-10-08 12:44 ` Willem de Bruijn
2020-10-09 1:48 ` Xin Long
2020-10-09 1:48 ` Xin Long
2020-10-09 13:59 ` Willem de Bruijn
2020-10-09 13:59 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010082357.BLEOWVCz-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@lists.01.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tuexen@fh-muenster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.