From: Guenter Roeck <linux@roeck-us.net> To: Anson Huang <Anson.Huang@nxp.com> Cc: linux@armlinux.org.uk, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, catalin.marinas@arm.com, will@kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, oleksandr.suvorov@toradex.com, peng.fan@nxp.com, andreas@kemnade.info, hverkuil-cisco@xs4all.nl, olof@lixom.net, krzk@kernel.org, geert+renesas@glider.be, prabhakar.mahadev-lad.rj@bp.renesas.com, aisheng.dong@nxp.com, lkundrak@v3.sk, joel@jms.id.au, bjorn.andersson@linaro.org, leoyang.li@nxp.com, vkoul@kernel.org, michael@walle.cc, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH V3 1/4] gpio: mxc: Support module build Date: Sun, 11 Oct 2020 12:03:29 -0700 [thread overview] Message-ID: <20201011190329.GA119453@roeck-us.net> (raw) In-Reply-To: <1600320829-1453-1-git-send-email-Anson.Huang@nxp.com> On Thu, Sep 17, 2020 at 01:33:46PM +0800, Anson Huang wrote: > Change config to tristate, add module device table, module author, > description and license to support module build for i.MX GPIO driver. > > As this is a SoC GPIO module, it provides common functions for most > of the peripheral devices, such as GPIO pins control, secondary > interrupt controller for GPIO pins IRQ etc., without GPIO driver, most > of the peripheral devices will NOT work properly, so GPIO module is > similar with clock, pinctrl driver that should be loaded ONCE and > never unloaded. > > Since MXC GPIO driver needs to have init function to register syscore > ops once, here still use subsys_initcall(), NOT module_platform_driver(). > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> This patch made it into linux-next, but none of the other patches in the series did. This results in a variety of boot failures in -next. Not that it is my concern, but "without GPIO driver, most of the peripheral devices will NOT work properly" makes me wonder if building this driver as module is really expected to work anywhere. Guenter > --- > no change. > --- > drivers/gpio/Kconfig | 2 +- > drivers/gpio/gpio-mxc.c | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 5cfdaf3..c7292a5 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -397,7 +397,7 @@ config GPIO_MVEBU > select REGMAP_MMIO > > config GPIO_MXC > - def_bool y > + tristate "i.MX GPIO support" > depends on ARCH_MXC || COMPILE_TEST > select GPIO_GENERIC > select GENERIC_IRQ_CHIP > diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c > index 64278a4..643f4c55 100644 > --- a/drivers/gpio/gpio-mxc.c > +++ b/drivers/gpio/gpio-mxc.c > @@ -15,6 +15,7 @@ > #include <linux/irq.h> > #include <linux/irqdomain.h> > #include <linux/irqchip/chained_irq.h> > +#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/slab.h> > #include <linux/syscore_ops.h> > @@ -158,6 +159,7 @@ static const struct of_device_id mxc_gpio_dt_ids[] = { > { .compatible = "fsl,imx7d-gpio", .data = &mxc_gpio_devtype[IMX35_GPIO], }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, mxc_gpio_dt_ids); > > /* > * MX2 has one interrupt *for all* gpio ports. The list is used > @@ -604,3 +606,7 @@ static int __init gpio_mxc_init(void) > return platform_driver_register(&mxc_gpio_driver); > } > subsys_initcall(gpio_mxc_init); > + > +MODULE_AUTHOR("Shawn Guo <shawn.guo@linaro.org>"); > +MODULE_DESCRIPTION("i.MX GPIO Driver"); > +MODULE_LICENSE("GPL");
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net> To: Anson Huang <Anson.Huang@nxp.com> Cc: peng.fan@nxp.com, geert+renesas@glider.be, catalin.marinas@arm.com, linus.walleij@linaro.org, bjorn.andersson@linaro.org, oleksandr.suvorov@toradex.com, michael@walle.cc, will@kernel.org, hverkuil-cisco@xs4all.nl, linux@armlinux.org.uk, krzk@kernel.org, bgolaszewski@baylibre.com, andreas@kemnade.info, joel@jms.id.au, Linux-imx@nxp.com, s.hauer@pengutronix.de, prabhakar.mahadev-lad.rj@bp.renesas.com, lkundrak@v3.sk, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, aisheng.dong@nxp.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, vkoul@kernel.org, kernel@pengutronix.de, olof@lixom.net, shawnguo@kernel.org Subject: Re: [PATCH V3 1/4] gpio: mxc: Support module build Date: Sun, 11 Oct 2020 12:03:29 -0700 [thread overview] Message-ID: <20201011190329.GA119453@roeck-us.net> (raw) In-Reply-To: <1600320829-1453-1-git-send-email-Anson.Huang@nxp.com> On Thu, Sep 17, 2020 at 01:33:46PM +0800, Anson Huang wrote: > Change config to tristate, add module device table, module author, > description and license to support module build for i.MX GPIO driver. > > As this is a SoC GPIO module, it provides common functions for most > of the peripheral devices, such as GPIO pins control, secondary > interrupt controller for GPIO pins IRQ etc., without GPIO driver, most > of the peripheral devices will NOT work properly, so GPIO module is > similar with clock, pinctrl driver that should be loaded ONCE and > never unloaded. > > Since MXC GPIO driver needs to have init function to register syscore > ops once, here still use subsys_initcall(), NOT module_platform_driver(). > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> This patch made it into linux-next, but none of the other patches in the series did. This results in a variety of boot failures in -next. Not that it is my concern, but "without GPIO driver, most of the peripheral devices will NOT work properly" makes me wonder if building this driver as module is really expected to work anywhere. Guenter > --- > no change. > --- > drivers/gpio/Kconfig | 2 +- > drivers/gpio/gpio-mxc.c | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 5cfdaf3..c7292a5 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -397,7 +397,7 @@ config GPIO_MVEBU > select REGMAP_MMIO > > config GPIO_MXC > - def_bool y > + tristate "i.MX GPIO support" > depends on ARCH_MXC || COMPILE_TEST > select GPIO_GENERIC > select GENERIC_IRQ_CHIP > diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c > index 64278a4..643f4c55 100644 > --- a/drivers/gpio/gpio-mxc.c > +++ b/drivers/gpio/gpio-mxc.c > @@ -15,6 +15,7 @@ > #include <linux/irq.h> > #include <linux/irqdomain.h> > #include <linux/irqchip/chained_irq.h> > +#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/slab.h> > #include <linux/syscore_ops.h> > @@ -158,6 +159,7 @@ static const struct of_device_id mxc_gpio_dt_ids[] = { > { .compatible = "fsl,imx7d-gpio", .data = &mxc_gpio_devtype[IMX35_GPIO], }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, mxc_gpio_dt_ids); > > /* > * MX2 has one interrupt *for all* gpio ports. The list is used > @@ -604,3 +606,7 @@ static int __init gpio_mxc_init(void) > return platform_driver_register(&mxc_gpio_driver); > } > subsys_initcall(gpio_mxc_init); > + > +MODULE_AUTHOR("Shawn Guo <shawn.guo@linaro.org>"); > +MODULE_DESCRIPTION("i.MX GPIO Driver"); > +MODULE_LICENSE("GPL"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-11 19:03 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-17 5:33 [PATCH V3 1/4] gpio: mxc: Support module build Anson Huang 2020-09-17 5:33 ` Anson Huang 2020-09-17 5:33 ` [PATCH V3 2/4] arm64: defconfig: Build in CONFIG_GPIO_MXC by default Anson Huang 2020-09-17 5:33 ` Anson Huang 2020-10-26 7:50 ` Shawn Guo 2020-10-26 7:50 ` Shawn Guo 2020-09-17 5:33 ` [PATCH V3 3/4] ARM: imx_v6_v7_defconfig: " Anson Huang 2020-09-17 5:33 ` Anson Huang 2020-09-17 5:33 ` [PATCH V3 4/4] ARM: multi_v7_defconfig: " Anson Huang 2020-09-17 5:33 ` Anson Huang 2020-09-29 13:05 ` [PATCH V3 1/4] gpio: mxc: Support module build Linus Walleij 2020-09-29 13:05 ` Linus Walleij 2020-10-12 11:35 ` Anson Huang 2020-10-12 11:35 ` Anson Huang 2020-10-13 13:04 ` Aisheng Dong 2020-10-13 13:04 ` Aisheng Dong 2020-10-11 19:03 ` Guenter Roeck [this message] 2020-10-11 19:03 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201011190329.GA119453@roeck-us.net \ --to=linux@roeck-us.net \ --cc=Anson.Huang@nxp.com \ --cc=Linux-imx@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=andreas@kemnade.info \ --cc=bgolaszewski@baylibre.com \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=festevam@gmail.com \ --cc=geert+renesas@glider.be \ --cc=hverkuil-cisco@xs4all.nl \ --cc=joel@jms.id.au \ --cc=kernel@pengutronix.de \ --cc=krzk@kernel.org \ --cc=leoyang.li@nxp.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=lkundrak@v3.sk \ --cc=michael@walle.cc \ --cc=oleksandr.suvorov@toradex.com \ --cc=olof@lixom.net \ --cc=peng.fan@nxp.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.