From: kernel test robot <lkp@intel.com>
To: Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Benjamin Herrenschmidt <benh@amazon.com>,
Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
osa-contribution-log@amazon.com, bpf@vger.kernel.org
Subject: Re: [PATCH v1 bpf-next 05/11] tcp: Migrate TCP_NEW_SYN_RECV requests.
Date: Wed, 2 Dec 2020 01:37:28 +0800 [thread overview]
Message-ID: <202012020136.bF0Z4Guu-lkp@intel.com> (raw)
In-Reply-To: <20201201144418.35045-6-kuniyu@amazon.co.jp>
[-- Attachment #1: Type: text/plain, Size: 4363 bytes --]
Hi Kuniyuki,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Kuniyuki-Iwashima/Socket-migration-for-SO_REUSEPORT/20201201-225221
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm-randconfig-r025-20201201 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ac40a2d8f16b8a8c68fc811d67f647740e965cb8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/9bf64de730c19cb543dbfbce6181938b27c6ebf5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kuniyuki-Iwashima/Socket-migration-for-SO_REUSEPORT/20201201-225221
git checkout 9bf64de730c19cb543dbfbce6181938b27c6ebf5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/core/sock_reuseport.c:320:14: warning: no previous prototype for function '__reuseport_select_sock' [-Wmissing-prototypes]
struct sock *__reuseport_select_sock(struct sock *sk, u32 hash,
^
net/core/sock_reuseport.c:320:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct sock *__reuseport_select_sock(struct sock *sk, u32 hash,
^
static
1 warning generated.
vim +/__reuseport_select_sock +320 net/core/sock_reuseport.c
307
308 /**
309 * reuseport_select_sock - Select a socket from an SO_REUSEPORT group.
310 * @sk: First socket in the group.
311 * @hash: When no BPF filter is available, use this hash to select.
312 * @skb: skb to run through BPF filter.
313 * @hdr_len: BPF filter expects skb data pointer at payload data. If
314 * the skb does not yet point at the payload, this parameter represents
315 * how far the pointer needs to advance to reach the payload.
316 * @migration: represents if it is selecting a listener for SYN or
317 * migrating ESTABLISHED/SYN_RECV sockets or NEW_SYN_RECV socket.
318 * Returns a socket that should receive the packet (or NULL on error).
319 */
> 320 struct sock *__reuseport_select_sock(struct sock *sk, u32 hash,
321 struct sk_buff *skb, int hdr_len,
322 u8 migration)
323 {
324 struct sock_reuseport *reuse;
325 struct bpf_prog *prog;
326 struct sock *sk2 = NULL;
327 u16 socks;
328
329 rcu_read_lock();
330 reuse = rcu_dereference(sk->sk_reuseport_cb);
331
332 /* if memory allocation failed or add call is not yet complete */
333 if (!reuse)
334 goto out;
335
336 socks = READ_ONCE(reuse->num_socks);
337 if (likely(socks)) {
338 /* paired with smp_wmb() in reuseport_add_sock() */
339 smp_rmb();
340
341 prog = rcu_dereference(reuse->prog);
342 if (!prog)
343 goto select_by_hash;
344
345 if (migration)
346 goto out;
347
348 if (!skb)
349 goto select_by_hash;
350
351 if (prog->type == BPF_PROG_TYPE_SK_REUSEPORT)
352 sk2 = bpf_run_sk_reuseport(reuse, sk, prog, skb, hash);
353 else
354 sk2 = run_bpf_filter(reuse, socks, prog, skb, hdr_len);
355
356 select_by_hash:
357 /* no bpf or invalid bpf result: fall back to hash usage */
358 if (!sk2) {
359 int i, j;
360
361 i = j = reciprocal_scale(hash, socks);
362 while (reuse->socks[i]->sk_state == TCP_ESTABLISHED) {
363 i++;
364 if (i >= reuse->num_socks)
365 i = 0;
366 if (i == j)
367 goto out;
368 }
369 sk2 = reuse->socks[i];
370 }
371 }
372
373 out:
374 rcu_read_unlock();
375 return sk2;
376 }
377
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26342 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1 bpf-next 05/11] tcp: Migrate TCP_NEW_SYN_RECV requests.
Date: Wed, 02 Dec 2020 01:37:28 +0800 [thread overview]
Message-ID: <202012020136.bF0Z4Guu-lkp@intel.com> (raw)
In-Reply-To: <20201201144418.35045-6-kuniyu@amazon.co.jp>
[-- Attachment #1: Type: text/plain, Size: 4478 bytes --]
Hi Kuniyuki,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Kuniyuki-Iwashima/Socket-migration-for-SO_REUSEPORT/20201201-225221
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm-randconfig-r025-20201201 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ac40a2d8f16b8a8c68fc811d67f647740e965cb8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/9bf64de730c19cb543dbfbce6181938b27c6ebf5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kuniyuki-Iwashima/Socket-migration-for-SO_REUSEPORT/20201201-225221
git checkout 9bf64de730c19cb543dbfbce6181938b27c6ebf5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/core/sock_reuseport.c:320:14: warning: no previous prototype for function '__reuseport_select_sock' [-Wmissing-prototypes]
struct sock *__reuseport_select_sock(struct sock *sk, u32 hash,
^
net/core/sock_reuseport.c:320:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct sock *__reuseport_select_sock(struct sock *sk, u32 hash,
^
static
1 warning generated.
vim +/__reuseport_select_sock +320 net/core/sock_reuseport.c
307
308 /**
309 * reuseport_select_sock - Select a socket from an SO_REUSEPORT group.
310 * @sk: First socket in the group.
311 * @hash: When no BPF filter is available, use this hash to select.
312 * @skb: skb to run through BPF filter.
313 * @hdr_len: BPF filter expects skb data pointer at payload data. If
314 * the skb does not yet point at the payload, this parameter represents
315 * how far the pointer needs to advance to reach the payload.
316 * @migration: represents if it is selecting a listener for SYN or
317 * migrating ESTABLISHED/SYN_RECV sockets or NEW_SYN_RECV socket.
318 * Returns a socket that should receive the packet (or NULL on error).
319 */
> 320 struct sock *__reuseport_select_sock(struct sock *sk, u32 hash,
321 struct sk_buff *skb, int hdr_len,
322 u8 migration)
323 {
324 struct sock_reuseport *reuse;
325 struct bpf_prog *prog;
326 struct sock *sk2 = NULL;
327 u16 socks;
328
329 rcu_read_lock();
330 reuse = rcu_dereference(sk->sk_reuseport_cb);
331
332 /* if memory allocation failed or add call is not yet complete */
333 if (!reuse)
334 goto out;
335
336 socks = READ_ONCE(reuse->num_socks);
337 if (likely(socks)) {
338 /* paired with smp_wmb() in reuseport_add_sock() */
339 smp_rmb();
340
341 prog = rcu_dereference(reuse->prog);
342 if (!prog)
343 goto select_by_hash;
344
345 if (migration)
346 goto out;
347
348 if (!skb)
349 goto select_by_hash;
350
351 if (prog->type == BPF_PROG_TYPE_SK_REUSEPORT)
352 sk2 = bpf_run_sk_reuseport(reuse, sk, prog, skb, hash);
353 else
354 sk2 = run_bpf_filter(reuse, socks, prog, skb, hdr_len);
355
356 select_by_hash:
357 /* no bpf or invalid bpf result: fall back to hash usage */
358 if (!sk2) {
359 int i, j;
360
361 i = j = reciprocal_scale(hash, socks);
362 while (reuse->socks[i]->sk_state == TCP_ESTABLISHED) {
363 i++;
364 if (i >= reuse->num_socks)
365 i = 0;
366 if (i == j)
367 goto out;
368 }
369 sk2 = reuse->socks[i];
370 }
371 }
372
373 out:
374 rcu_read_unlock();
375 return sk2;
376 }
377
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26342 bytes --]
next prev parent reply other threads:[~2020-12-01 17:38 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 14:44 [PATCH v1 bpf-next 00/11] Socket migration for SO_REUSEPORT Kuniyuki Iwashima
2020-12-01 14:44 ` [PATCH v1 bpf-next 01/11] tcp: Keep TCP_CLOSE sockets in the reuseport group Kuniyuki Iwashima
2020-12-05 1:31 ` Martin KaFai Lau
2020-12-06 4:38 ` Kuniyuki Iwashima
2020-12-01 14:44 ` [PATCH v1 bpf-next 02/11] bpf: Define migration types for SO_REUSEPORT Kuniyuki Iwashima
2020-12-01 14:44 ` [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues Kuniyuki Iwashima
2020-12-01 15:25 ` Eric Dumazet
2020-12-03 14:14 ` Kuniyuki Iwashima
2020-12-03 14:31 ` Eric Dumazet
2020-12-03 15:41 ` Kuniyuki Iwashima
2020-12-07 20:33 ` Martin KaFai Lau
2020-12-08 6:31 ` Kuniyuki Iwashima
2020-12-08 7:34 ` Martin KaFai Lau
2020-12-08 8:17 ` Kuniyuki Iwashima
2020-12-09 3:09 ` Martin KaFai Lau
2020-12-09 8:05 ` Kuniyuki Iwashima
2020-12-09 16:57 ` Kuniyuki Iwashima
2020-12-10 1:53 ` Martin KaFai Lau
2020-12-10 5:58 ` Kuniyuki Iwashima
2020-12-10 19:33 ` Martin KaFai Lau
2020-12-14 17:16 ` Kuniyuki Iwashima
2020-12-05 1:42 ` Martin KaFai Lau
2020-12-06 4:41 ` Kuniyuki Iwashima
[not found] ` <20201205160307.91179-1-kuniyu@amazon.co.jp>
2020-12-07 20:14 ` Martin KaFai Lau
2020-12-08 6:27 ` Kuniyuki Iwashima
2020-12-08 8:13 ` Martin KaFai Lau
2020-12-08 9:02 ` Kuniyuki Iwashima
2020-12-08 6:54 ` Martin KaFai Lau
2020-12-08 7:42 ` Kuniyuki Iwashima
2020-12-01 14:44 ` [PATCH v1 bpf-next 04/11] tcp: Migrate TFO requests causing RST during TCP_SYN_RECV Kuniyuki Iwashima
2020-12-01 15:30 ` Eric Dumazet
2020-12-01 14:44 ` [PATCH v1 bpf-next 05/11] tcp: Migrate TCP_NEW_SYN_RECV requests Kuniyuki Iwashima
2020-12-01 15:13 ` Eric Dumazet
2020-12-03 14:12 ` Kuniyuki Iwashima
2020-12-01 17:37 ` kernel test robot [this message]
2020-12-01 17:37 ` kernel test robot
2020-12-01 17:42 ` kernel test robot
2020-12-01 17:42 ` kernel test robot
2020-12-10 0:07 ` Martin KaFai Lau
2020-12-10 5:15 ` Kuniyuki Iwashima
2020-12-10 18:49 ` Martin KaFai Lau
2020-12-14 17:03 ` Kuniyuki Iwashima
2020-12-15 2:58 ` Martin KaFai Lau
2020-12-16 16:41 ` Kuniyuki Iwashima
2020-12-16 22:24 ` Martin KaFai Lau
2020-12-01 14:44 ` [PATCH v1 bpf-next 06/11] bpf: Introduce two attach types for BPF_PROG_TYPE_SK_REUSEPORT Kuniyuki Iwashima
2020-12-02 2:04 ` Andrii Nakryiko
2020-12-02 19:19 ` Martin KaFai Lau
2020-12-03 4:24 ` Martin KaFai Lau
2020-12-03 14:16 ` Kuniyuki Iwashima
2020-12-04 5:56 ` Martin KaFai Lau
2020-12-06 4:32 ` Kuniyuki Iwashima
2020-12-01 14:44 ` [PATCH v1 bpf-next 07/11] libbpf: Set expected_attach_type " Kuniyuki Iwashima
2020-12-01 14:44 ` [PATCH v1 bpf-next 08/11] bpf: Add migration to sk_reuseport_(kern|md) Kuniyuki Iwashima
2020-12-01 14:44 ` [PATCH v1 bpf-next 09/11] bpf: Support bpf_get_socket_cookie_sock() for BPF_PROG_TYPE_SK_REUSEPORT Kuniyuki Iwashima
2020-12-04 19:58 ` Martin KaFai Lau
2020-12-06 4:36 ` Kuniyuki Iwashima
2020-12-01 14:44 ` [PATCH v1 bpf-next 10/11] bpf: Call bpf_run_sk_reuseport() for socket migration Kuniyuki Iwashima
2020-12-01 14:44 ` [PATCH v1 bpf-next 11/11] bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE Kuniyuki Iwashima
2020-12-05 1:50 ` Martin KaFai Lau
2020-12-06 4:43 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012020136.bF0Z4Guu-lkp@intel.com \
--to=lkp@intel.com \
--cc=ast@kernel.org \
--cc=benh@amazon.com \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kafai@fb.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.co.jp \
--cc=osa-contribution-log@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.