From: Jim Cromie <jim.cromie@gmail.com> To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: jbaron@akamai.com, Jim Cromie <jim.cromie@gmail.com> Subject: [RFC PATCH 0/2] drm: use dynamic_debug Date: Thu, 3 Dec 2020 20:53:16 -0700 [thread overview] Message-ID: <20201204035318.332419-1-jim.cromie@gmail.com> (raw) hello gentle readers, These 2 rfc patches convert part of drm-world to use dynamic debug. 1st one addresses drm.debug category based logging. If DYNAMIC_DEBUG is configured, then CONFIG_DRM_USE_DYNAMIC_DEBUG controls whether dynamic-debug is used to avoid runtime costs of drm_debug_enabled(). We require CONFIG_JUMP_LABEL too, since we are selling its optimization. This change adds many new callsites to /proc/dynamic_debug/control; ~300 in drm, ~200 in drm_kms_helper, as well as ~1500 in i915 driver, and ~3200 in amdgpu. So there are substantial implications here. 2nd one is for i915, which I have in my laptop. `grep pr_debug` found ~90 callsites with a meaningful format-prefix-string, to demonstrate use of "format ^prefix" to control user categorized debugs. Jim Cromie (2): drm: RFC add choice to use dynamic debug in drm-debug i915: POC use dynamic_debug_exec_queries to control pr_debugs in gvt drivers/gpu/drm/Kconfig | 13 +++++ drivers/gpu/drm/drm_print.c | 75 ++++++++++++++++++++++-- drivers/gpu/drm/i915/gvt/Makefile | 1 + drivers/gpu/drm/i915/i915_params.c | 74 ++++++++++++++++++++++++ include/drm/drm_print.h | 92 ++++++++++++++++++++++-------- 5 files changed, 228 insertions(+), 27 deletions(-) -- 2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Jim Cromie <jim.cromie@gmail.com> To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jim Cromie <jim.cromie@gmail.com>, jbaron@akamai.com Subject: [RFC PATCH 0/2] drm: use dynamic_debug Date: Thu, 3 Dec 2020 20:53:16 -0700 [thread overview] Message-ID: <20201204035318.332419-1-jim.cromie@gmail.com> (raw) hello gentle readers, These 2 rfc patches convert part of drm-world to use dynamic debug. 1st one addresses drm.debug category based logging. If DYNAMIC_DEBUG is configured, then CONFIG_DRM_USE_DYNAMIC_DEBUG controls whether dynamic-debug is used to avoid runtime costs of drm_debug_enabled(). We require CONFIG_JUMP_LABEL too, since we are selling its optimization. This change adds many new callsites to /proc/dynamic_debug/control; ~300 in drm, ~200 in drm_kms_helper, as well as ~1500 in i915 driver, and ~3200 in amdgpu. So there are substantial implications here. 2nd one is for i915, which I have in my laptop. `grep pr_debug` found ~90 callsites with a meaningful format-prefix-string, to demonstrate use of "format ^prefix" to control user categorized debugs. Jim Cromie (2): drm: RFC add choice to use dynamic debug in drm-debug i915: POC use dynamic_debug_exec_queries to control pr_debugs in gvt drivers/gpu/drm/Kconfig | 13 +++++ drivers/gpu/drm/drm_print.c | 75 ++++++++++++++++++++++-- drivers/gpu/drm/i915/gvt/Makefile | 1 + drivers/gpu/drm/i915/i915_params.c | 74 ++++++++++++++++++++++++ include/drm/drm_print.h | 92 ++++++++++++++++++++++-------- 5 files changed, 228 insertions(+), 27 deletions(-) -- 2.28.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-12-04 3:54 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 3:53 Jim Cromie [this message] 2020-12-04 3:53 ` [RFC PATCH 0/2] drm: use dynamic_debug Jim Cromie 2020-12-04 3:53 ` [RFC PATCH 1/2] drm: RFC add choice to use dynamic debug in drm-debug Jim Cromie 2020-12-04 3:53 ` Jim Cromie 2020-12-04 15:42 ` Ville Syrjälä 2020-12-04 15:42 ` Ville Syrjälä 2020-12-04 19:20 ` jim.cromie 2020-12-04 19:20 ` jim.cromie 2020-12-11 15:30 ` Ville Syrjälä 2020-12-11 15:30 ` Ville Syrjälä 2020-12-17 21:31 ` jim.cromie 2020-12-17 21:31 ` jim.cromie 2020-12-04 3:53 ` [RFC PATCH 2/2] i915: POC use dynamic_debug_exec_queries to control pr_debugs in gvt Jim Cromie 2020-12-04 3:53 ` [Intel-gfx] " Jim Cromie 2020-12-04 3:53 ` Jim Cromie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201204035318.332419-1-jim.cromie@gmail.com \ --to=jim.cromie@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jbaron@akamai.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.