All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: kernel test robot <lkp@intel.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Lee Jones <lee.jones@linaro.org>,
	kbuild-all@lists.01.org, Rich Felker <dalias@libc.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Gustavo A R Silva <gustavoars@kernel.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU
Date: Sun, 6 Dec 2020 22:48:14 +0100	[thread overview]
Message-ID: <20201206214814.GA1884161@ravnborg.org> (raw)
In-Reply-To: <202012070518.yJA9Vbbo-lkp@intel.com>

commit aa1f4345b5480502a4e61addf5c59d606fdbce8f
Author: Sam Ravnborg <sam@ravnborg.org>
Date:   Mon Nov 30 22:09:29 2020 +0100

    sh: Fix set but not used warnings with !CONFIG_MMU
    
    Building fbdev drivers for sh with W=1 produces the following warning:
    
        tmiofb.c: In function ‘tmiofb_remove’:
        tmiofb.c:805:21: warning: variable ‘par’ set but not used
    
    This is with allmodconfig and ARCH=sh
    
    This boiled down to iounmap() defined as empty for !CONFIG_MMU.
    Fix this by by adding "(void)addr;" to tell the compiler the
    argument to iounmap() should be considered used.
    
    v4:
      - Fix build error of ethernet driver (kernel test robot)
        Added missing () around macro parameter
    
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Cc: kernel test robot <lkp@intel.com>
    Cc: Thomas Zimmermann <tzimmermann@suse.de>
    Cc: Lee Jones <lee.jones@linaro.org>
    Cc: Rich Felker <dalias@libc.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Geert Uytterhoeven <geert+renesas@glider.be>
    Cc: Mike Rapoport <rppt@kernel.org>
    Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>

diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
index 6d5c6463bc07..45082bcbd9aa 100644
--- a/arch/sh/include/asm/io.h
+++ b/arch/sh/include/asm/io.h
@@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size,
 #endif /* CONFIG_HAVE_IOREMAP_PROT */
 
 #else /* CONFIG_MMU */
-#define iounmap(addr)		do { } while (0)
+#define iounmap(addr)		do { (void)(addr); } while (0)
 #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
 #endif /* CONFIG_MMU */
 

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: kernel test robot <lkp@intel.com>
Cc: linux-fbdev@vger.kernel.org, Rich Felker <dalias@libc.org>,
	kbuild-all@lists.01.org,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Gustavo A R Silva <gustavoars@kernel.org>,
	dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Peter Jones <pjones@redhat.com>, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU
Date: Sun, 6 Dec 2020 22:48:14 +0100	[thread overview]
Message-ID: <20201206214814.GA1884161@ravnborg.org> (raw)
In-Reply-To: <202012070518.yJA9Vbbo-lkp@intel.com>

commit aa1f4345b5480502a4e61addf5c59d606fdbce8f
Author: Sam Ravnborg <sam@ravnborg.org>
Date:   Mon Nov 30 22:09:29 2020 +0100

    sh: Fix set but not used warnings with !CONFIG_MMU
    
    Building fbdev drivers for sh with W=1 produces the following warning:
    
        tmiofb.c: In function ‘tmiofb_remove’:
        tmiofb.c:805:21: warning: variable ‘par’ set but not used
    
    This is with allmodconfig and ARCH=sh
    
    This boiled down to iounmap() defined as empty for !CONFIG_MMU.
    Fix this by by adding "(void)addr;" to tell the compiler the
    argument to iounmap() should be considered used.
    
    v4:
      - Fix build error of ethernet driver (kernel test robot)
        Added missing () around macro parameter
    
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Cc: kernel test robot <lkp@intel.com>
    Cc: Thomas Zimmermann <tzimmermann@suse.de>
    Cc: Lee Jones <lee.jones@linaro.org>
    Cc: Rich Felker <dalias@libc.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Geert Uytterhoeven <geert+renesas@glider.be>
    Cc: Mike Rapoport <rppt@kernel.org>
    Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>

diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
index 6d5c6463bc07..45082bcbd9aa 100644
--- a/arch/sh/include/asm/io.h
+++ b/arch/sh/include/asm/io.h
@@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size,
 #endif /* CONFIG_HAVE_IOREMAP_PROT */
 
 #else /* CONFIG_MMU */
-#define iounmap(addr)		do { } while (0)
+#define iounmap(addr)		do { (void)(addr); } while (0)
 #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
 #endif /* CONFIG_MMU */
 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU
Date: Sun, 06 Dec 2020 22:48:14 +0100	[thread overview]
Message-ID: <20201206214814.GA1884161@ravnborg.org> (raw)
In-Reply-To: <202012070518.yJA9Vbbo-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]

commit aa1f4345b5480502a4e61addf5c59d606fdbce8f
Author: Sam Ravnborg <sam@ravnborg.org>
Date:   Mon Nov 30 22:09:29 2020 +0100

    sh: Fix set but not used warnings with !CONFIG_MMU
    
    Building fbdev drivers for sh with W=1 produces the following warning:
    
        tmiofb.c: In function ‘tmiofb_remove’:
        tmiofb.c:805:21: warning: variable ‘par’ set but not used
    
    This is with allmodconfig and ARCH=sh
    
    This boiled down to iounmap() defined as empty for !CONFIG_MMU.
    Fix this by by adding "(void)addr;" to tell the compiler the
    argument to iounmap() should be considered used.
    
    v4:
      - Fix build error of ethernet driver (kernel test robot)
        Added missing () around macro parameter
    
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Cc: kernel test robot <lkp@intel.com>
    Cc: Thomas Zimmermann <tzimmermann@suse.de>
    Cc: Lee Jones <lee.jones@linaro.org>
    Cc: Rich Felker <dalias@libc.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Geert Uytterhoeven <geert+renesas@glider.be>
    Cc: Mike Rapoport <rppt@kernel.org>
    Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>

diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
index 6d5c6463bc07..45082bcbd9aa 100644
--- a/arch/sh/include/asm/io.h
+++ b/arch/sh/include/asm/io.h
@@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size,
 #endif /* CONFIG_HAVE_IOREMAP_PROT */
 
 #else /* CONFIG_MMU */
-#define iounmap(addr)		do { } while (0)
+#define iounmap(addr)		do { (void)(addr); } while (0)
 #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
 #endif /* CONFIG_MMU */
 

  reply	other threads:[~2020-12-06 21:49 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06 19:02 [PATCH v3 0/13] drivers/video: W=1 warning fixes Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` Sam Ravnborg
2020-12-06 19:02 ` [PATCH v3 01/13] video: fbdev: hgafb: Fix kernel-doc warnings Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:34   ` Randy Dunlap
2020-12-06 19:34     ` Randy Dunlap
2020-12-06 19:34     ` Randy Dunlap
2020-12-06 19:02 ` [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:37   ` Randy Dunlap
2020-12-06 19:37     ` Randy Dunlap
2020-12-06 19:37     ` Randy Dunlap
2020-12-06 20:52     ` Sam Ravnborg
2020-12-06 20:52       ` Sam Ravnborg
2020-12-06 20:52       ` Sam Ravnborg
2020-12-06 21:27       ` Randy Dunlap
2020-12-06 21:27         ` Randy Dunlap
2020-12-06 21:27         ` Randy Dunlap
2020-12-07  8:16     ` Thomas Zimmermann
2020-12-07  8:16       ` Thomas Zimmermann
2020-12-07  8:16       ` Thomas Zimmermann
2020-12-07 16:43       ` Randy Dunlap
2020-12-07 16:43         ` Randy Dunlap
2020-12-07 16:43         ` Randy Dunlap
2020-12-07 17:12         ` Sam Ravnborg
2020-12-07 17:12           ` Sam Ravnborg
2020-12-07 17:12           ` Sam Ravnborg
2020-12-06 19:02 ` [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07  8:17   ` Thomas Zimmermann
2020-12-07  8:17     ` Thomas Zimmermann
2020-12-07  8:17     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07  8:18   ` Thomas Zimmermann
2020-12-07  8:18     ` Thomas Zimmermann
2020-12-07  8:18     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 21:19   ` kernel test robot
2020-12-06 21:19     ` kernel test robot
2020-12-06 21:19     ` kernel test robot
2020-12-06 21:48     ` Sam Ravnborg [this message]
2020-12-06 21:48       ` Sam Ravnborg
2020-12-06 21:48       ` Sam Ravnborg
2020-12-06 21:49       ` Sam Ravnborg
2020-12-06 21:49         ` Sam Ravnborg
2020-12-06 21:49         ` Sam Ravnborg
2020-12-07  8:19   ` Thomas Zimmermann
2020-12-07  8:19     ` Thomas Zimmermann
2020-12-07  8:19     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 06/13] video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07  8:21   ` Thomas Zimmermann
2020-12-07  8:21     ` Thomas Zimmermann
2020-12-07  8:21     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 07/13] video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07 13:48   ` Thomas Zimmermann
2020-12-07 13:48     ` Thomas Zimmermann
2020-12-07 13:48     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 08/13] video: fbdev: wmt_ge_rops: Fix function not declared warnings Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07 13:49   ` Thomas Zimmermann
2020-12-07 13:49     ` Thomas Zimmermann
2020-12-07 13:49     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 09/13] video: fbdev: goldfishfb: Fix defined but not used warning Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07 13:49   ` Thomas Zimmermann
2020-12-07 13:49     ` Thomas Zimmermann
2020-12-07 13:49     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 10/13] video: fbdev: gbefb: Fix set " Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07 13:50   ` Thomas Zimmermann
2020-12-07 13:50     ` Thomas Zimmermann
2020-12-07 13:50     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07 13:51   ` Thomas Zimmermann
2020-12-07 13:51     ` Thomas Zimmermann
2020-12-07 13:51     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 12/13] video: fbdev: controlfb: Fix set but not used warnings Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07 13:52   ` Thomas Zimmermann
2020-12-07 13:52     ` Thomas Zimmermann
2020-12-07 13:52     ` Thomas Zimmermann
2020-12-06 19:02 ` [PATCH v3 13/13] video: fbdev: sis: Drop useless call to SiS_GetResInfo() Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-06 19:02   ` Sam Ravnborg
2020-12-07 13:53   ` Thomas Zimmermann
2020-12-07 13:53     ` Thomas Zimmermann
2020-12-07 13:53     ` Thomas Zimmermann
2020-12-08 18:02 ` [PATCH v3 0/13] drivers/video: W=1 warning fixes Sam Ravnborg
2020-12-08 18:02   ` Sam Ravnborg
2020-12-08 18:02   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201206214814.GA1884161@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=a.hajda@samsung.com \
    --cc=dalias@libc.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavoars@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=peterz@infradead.org \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.