From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Chanho Park <chanho61.park@samsung.com>,
Will Deacon <will@kernel.org>, Chanho Park <parkch98@gmail.com>,
mathieu.poirier@linaro.org, suzuki.poulose@arm.com,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
John Garry <john.garry@huawei.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Khem Raj <raj.khem@gmail.com>
Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc
Date: Mon, 7 Dec 2020 14:28:40 +0100 [thread overview]
Message-ID: <20201207132840.GA4070632@krava> (raw)
In-Reply-To: <CAM9d7chU0SP79cjuZOBg1Rhe2NYaxAOnKzdQ+XQ65fenTzak0A@mail.gmail.com>
On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote:
> Hi Chanho,
>
> On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <chanho61.park@samsung.com> wrote:
> >
> > Hi Will,
> >
> > > Looks like other files just include this unconditionally, but have a
> > > comment explaining why. See util/branch.h and util/event.h. Maybe we
> > > should do the same for util/pmu.h, which is already included here?
> >
> > I found below files which perf includes <linux/perf_event.h>. Instead of
> > doing same for all, we'd better put this only for
> > tools/include/uapi/linux/perf_event.h.
>
> It's a copy of the kernel header, I'm not sure we want to add something there.
right, we want to copy that directly from kernel uapi
so let's not do any changes in here
jirka
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
John Garry <john.garry@huawei.com>,
mathieu.poirier@linaro.org, suzuki.poulose@arm.com,
Peter Zijlstra <peterz@infradead.org>,
coresight@lists.linaro.org, Chanho Park <parkch98@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Khem Raj <raj.khem@gmail.com>, Ingo Molnar <mingo@redhat.com>,
Leo Yan <leo.yan@linaro.org>,
Chanho Park <chanho61.park@samsung.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc
Date: Mon, 7 Dec 2020 14:28:40 +0100 [thread overview]
Message-ID: <20201207132840.GA4070632@krava> (raw)
In-Reply-To: <CAM9d7chU0SP79cjuZOBg1Rhe2NYaxAOnKzdQ+XQ65fenTzak0A@mail.gmail.com>
On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote:
> Hi Chanho,
>
> On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <chanho61.park@samsung.com> wrote:
> >
> > Hi Will,
> >
> > > Looks like other files just include this unconditionally, but have a
> > > comment explaining why. See util/branch.h and util/event.h. Maybe we
> > > should do the same for util/pmu.h, which is already included here?
> >
> > I found below files which perf includes <linux/perf_event.h>. Instead of
> > doing same for all, we'd better put this only for
> > tools/include/uapi/linux/perf_event.h.
>
> It's a copy of the kernel header, I'm not sure we want to add something there.
right, we want to copy that directly from kernel uapi
so let's not do any changes in here
jirka
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-07 13:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 14:45 [PATCH] perf arm pmu: fix build error on MUSL libc Chanho Park
2020-12-06 14:45 ` Chanho Park
2020-12-07 10:53 ` Will Deacon
2020-12-07 10:53 ` Will Deacon
2020-12-07 11:58 ` Chanho Park
2020-12-07 11:58 ` Chanho Park
2020-12-07 12:31 ` Namhyung Kim
2020-12-07 12:31 ` Namhyung Kim
2020-12-07 13:28 ` Jiri Olsa [this message]
2020-12-07 13:28 ` Jiri Olsa
2020-12-08 9:54 ` Chanho Park
2020-12-08 9:54 ` Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207132840.GA4070632@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=chanho61.park@samsung.com \
--cc=coresight@lists.linaro.org \
--cc=john.garry@huawei.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=parkch98@gmail.com \
--cc=peterz@infradead.org \
--cc=raj.khem@gmail.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.