From: Lukasz Luba <lukasz.luba@arm.com> To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, lukasz.luba@arm.com, orjan.eide@arm.com, robh@kernel.org, alyssa.rosenzweig@collabora.com, steven.price@arm.com, airlied@linux.ie, daniel@ffwll.ch, ionela.voinescu@arm.com Subject: [PATCH v4 0/5] Thermal devfreq cooling improvements with Energy Model Date: Thu, 10 Dec 2020 14:30:09 +0000 [thread overview] Message-ID: <20201210143014.24685-1-lukasz.luba@arm.com> (raw) Hi all, This patch set is a continuation of my previous work, which aimed to add Energy Model to all devices [1]. This series is a follow up for the patches which got merged to v5.9-rc1. It aims to change the thermal devfreq cooling and use the Energy Model instead of private power table and structures. The power model is now simplified, static power and dynamic power are removed. The new registration interface in the patch 3/5 helps to register devfreq cooling and the EM in one call. There is also small improvement, patch 2/5 is changing the way how thermal gets the device status (now uses a copy) and normalize the values. The last patch is here for consistency and will probably go through drm tree. The patch set should apply on top of thermal/testing. It does not depend on new EM API change which is queued in the pm/linux-next tree as v5.11 material. Thus, could go in parallel. That was the main motiviation for this v4. changes: v4: - patch 3/5 - removed dependency on the EM API change -- removed em_dev_register_perf_domain() and just use dev_pm_opp_of_register_em() which API has not changed -- removed a helper registration function and renamed devfreq_cooling_em_register_power() to devfreq_cooling_em_register() (was actually suggested by Ionela during review) -- moved energy_model.h to include in devfreq_cooling.c not .h, since there is no EM structure in there anymore - adjusted comments and commit messages v3 [4]: - dropped direct check of device status and used just a copy of 'status'; a separate patch set will be proposed to address this issue - modified _normalize_load() and used 1024 scale to handle ms, us, ns - removed 'em_registered' and called em_dev_unregister_perf_domain() unconditionally, so the drivers will have to make sure the right order of all unregister calls to frameworks which might use EM; this call must be last one; a proper comment added - removed 'em' pointer from struct devfreq_cooling_device, 'dev->em_pd' is used - removed of_node_get/put(), since the code can handle it - removed dfc_em_get_requested_power() (as missed to do it in v2) - collected all Reviewed-by tags v2 [3]: - renamed freq_get_state() and related to perf_idx pattern as suggested by Ionela v1 [2] Regards, Lukasz Luba Lukasz Luba (5): thermal: devfreq_cooling: change tracing function and arguments thermal: devfreq_cooling: use a copy of device status thermal: devfreq_cooling: add new registration functions with Energy Model thermal: devfreq_cooling: remove old power model and use EM drm/panfrost: Register devfreq cooling and attempt to add Energy Model drivers/gpu/drm/panfrost/panfrost_devfreq.c | 2 +- drivers/thermal/devfreq_cooling.c | 391 +++++++++----------- include/linux/devfreq_cooling.h | 27 +- include/trace/events/thermal.h | 19 +- 4 files changed, 198 insertions(+), 241 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Luba <lukasz.luba@arm.com> To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: amit.kucheria@verdurent.com, airlied@linux.ie, daniel.lezcano@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, rui.zhang@intel.com, ionela.voinescu@arm.com, orjan.eide@arm.com, lukasz.luba@arm.com Subject: [PATCH v4 0/5] Thermal devfreq cooling improvements with Energy Model Date: Thu, 10 Dec 2020 14:30:09 +0000 [thread overview] Message-ID: <20201210143014.24685-1-lukasz.luba@arm.com> (raw) Hi all, This patch set is a continuation of my previous work, which aimed to add Energy Model to all devices [1]. This series is a follow up for the patches which got merged to v5.9-rc1. It aims to change the thermal devfreq cooling and use the Energy Model instead of private power table and structures. The power model is now simplified, static power and dynamic power are removed. The new registration interface in the patch 3/5 helps to register devfreq cooling and the EM in one call. There is also small improvement, patch 2/5 is changing the way how thermal gets the device status (now uses a copy) and normalize the values. The last patch is here for consistency and will probably go through drm tree. The patch set should apply on top of thermal/testing. It does not depend on new EM API change which is queued in the pm/linux-next tree as v5.11 material. Thus, could go in parallel. That was the main motiviation for this v4. changes: v4: - patch 3/5 - removed dependency on the EM API change -- removed em_dev_register_perf_domain() and just use dev_pm_opp_of_register_em() which API has not changed -- removed a helper registration function and renamed devfreq_cooling_em_register_power() to devfreq_cooling_em_register() (was actually suggested by Ionela during review) -- moved energy_model.h to include in devfreq_cooling.c not .h, since there is no EM structure in there anymore - adjusted comments and commit messages v3 [4]: - dropped direct check of device status and used just a copy of 'status'; a separate patch set will be proposed to address this issue - modified _normalize_load() and used 1024 scale to handle ms, us, ns - removed 'em_registered' and called em_dev_unregister_perf_domain() unconditionally, so the drivers will have to make sure the right order of all unregister calls to frameworks which might use EM; this call must be last one; a proper comment added - removed 'em' pointer from struct devfreq_cooling_device, 'dev->em_pd' is used - removed of_node_get/put(), since the code can handle it - removed dfc_em_get_requested_power() (as missed to do it in v2) - collected all Reviewed-by tags v2 [3]: - renamed freq_get_state() and related to perf_idx pattern as suggested by Ionela v1 [2] Regards, Lukasz Luba Lukasz Luba (5): thermal: devfreq_cooling: change tracing function and arguments thermal: devfreq_cooling: use a copy of device status thermal: devfreq_cooling: add new registration functions with Energy Model thermal: devfreq_cooling: remove old power model and use EM drm/panfrost: Register devfreq cooling and attempt to add Energy Model drivers/gpu/drm/panfrost/panfrost_devfreq.c | 2 +- drivers/thermal/devfreq_cooling.c | 391 +++++++++----------- include/linux/devfreq_cooling.h | 27 +- include/trace/events/thermal.h | 19 +- 4 files changed, 198 insertions(+), 241 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-12-10 19:02 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-10 14:30 Lukasz Luba [this message] 2020-12-10 14:30 ` [PATCH v4 0/5] Thermal devfreq cooling improvements with Energy Model Lukasz Luba 2020-12-10 14:30 ` [PATCH v4 1/5] thermal: devfreq_cooling: change tracing function and arguments Lukasz Luba 2020-12-10 14:30 ` Lukasz Luba 2020-12-14 14:40 ` [thermal: thermal/next] " thermal-bot for Lukasz Luba 2020-12-10 14:30 ` [PATCH v4 2/5] thermal: devfreq_cooling: use a copy of device status Lukasz Luba 2020-12-10 14:30 ` Lukasz Luba 2020-12-14 14:40 ` [thermal: thermal/next] " thermal-bot for Lukasz Luba 2020-12-10 14:30 ` [PATCH v4 3/5] thermal: devfreq_cooling: add new registration functions with Energy Model Lukasz Luba 2020-12-10 14:30 ` Lukasz Luba 2020-12-14 14:40 ` [thermal: thermal/next] " thermal-bot for Lukasz Luba 2020-12-10 14:30 ` [PATCH v4 4/5] thermal: devfreq_cooling: remove old power model and use EM Lukasz Luba 2020-12-10 14:30 ` Lukasz Luba 2020-12-14 14:40 ` [thermal: thermal/next] " thermal-bot for Lukasz Luba 2020-12-10 14:30 ` [PATCH v4 5/5] drm/panfrost: Register devfreq cooling and attempt to add Energy Model Lukasz Luba 2020-12-10 14:30 ` Lukasz Luba 2020-12-14 14:40 ` [thermal: thermal/next] " thermal-bot for Lukasz Luba 2020-12-11 15:11 ` [PATCH v4 0/5] Thermal devfreq cooling improvements with " Lukasz Luba 2020-12-11 15:11 ` Lukasz Luba 2020-12-11 15:15 ` Daniel Lezcano 2020-12-11 15:15 ` Daniel Lezcano 2020-12-11 15:29 ` Lukasz Luba 2020-12-11 15:29 ` Lukasz Luba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201210143014.24685-1-lukasz.luba@arm.com \ --to=lukasz.luba@arm.com \ --cc=airlied@linux.ie \ --cc=alyssa.rosenzweig@collabora.com \ --cc=amit.kucheria@verdurent.com \ --cc=daniel.lezcano@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=ionela.voinescu@arm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=orjan.eide@arm.com \ --cc=robh@kernel.org \ --cc=rui.zhang@intel.com \ --cc=steven.price@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.