From: kernel test robot <lkp@intel.com>
To: Kashyap Desai <kashyap.desai@broadcom.com>, linux-scsi@vger.kernel.org
Cc: kbuild-all@lists.01.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, steve.hagan@broadcom.com,
peter.rivera@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com,
Kashyap Desai <kashyap.desai@broadcom.com>,
sathya.prakash@broadcom.com
Subject: Re: [PATCH 17/24] mpi3mr: add support of threaded isr
Date: Sun, 27 Dec 2020 21:51:16 +0800 [thread overview]
Message-ID: <202012272112.ZXvREaJO-lkp@intel.com> (raw)
In-Reply-To: <20201222101156.98308-18-kashyap.desai@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 3335 bytes --]
Hi Kashyap,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next v5.10 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kashyap-Desai/Introducing-mpi3mr-driver/20201222-181732
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/877f4e22deefcac84c14ed953f360f8131e02d14
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kashyap-Desai/Introducing-mpi3mr-driver/20201222-181732
git checkout 877f4e22deefcac84c14ed953f360f8131e02d14
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/mpi3mr/mpi3mr_fw.c: In function 'mpi3mr_isr_poll':
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:481:6: warning: variable 'num_admin_replies' set but not used [-Wunused-but-set-variable]
481 | u32 num_admin_replies = 0, num_op_reply = 0;
| ^~~~~~~~~~~~~~~~~
vim +/num_admin_replies +481 drivers/scsi/mpi3mr/mpi3mr_fw.c
465
466 /**
467 * mpi3mr_isr_poll - Reply queue polling routine
468 * @irq: IRQ
469 * @privdata: Interrupt info
470 *
471 * poll for pending I/O completions in a loop until pending I/Os
472 * present or controller queue depth I/Os are processed.
473 *
474 * Return: IRQ_NONE or IRQ_HANDLED
475 */
476 static irqreturn_t mpi3mr_isr_poll(int irq, void *privdata)
477 {
478 struct mpi3mr_intr_info *intr_info = privdata;
479 struct mpi3mr_ioc *mrioc;
480 u16 midx;
> 481 u32 num_admin_replies = 0, num_op_reply = 0;
482
483 if (!intr_info || !intr_info->op_reply_q)
484 return IRQ_NONE;
485
486 mrioc = intr_info->mrioc;
487 midx = intr_info->msix_index;
488
489 /* Poll for pending IOs completions */
490 do {
491 if (!mrioc->intr_enabled)
492 break;
493
494 if (!midx)
495 num_admin_replies = mpi3mr_process_admin_reply_q(mrioc);
496 if (intr_info->op_reply_q)
497 num_op_reply +=
498 mpi3mr_process_op_reply_q(mrioc, intr_info);
499
500 usleep_range(mrioc->irqpoll_sleep, 10 * mrioc->irqpoll_sleep);
501
502 } while (atomic_read(&intr_info->op_reply_q->pend_ios) &&
503 (num_op_reply < mrioc->max_host_ios));
504
505 intr_info->op_reply_q->enable_irq_poll = false;
506 enable_irq(pci_irq_vector(mrioc->pdev, midx));
507
508 return IRQ_HANDLED;
509 }
510
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71613 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 17/24] mpi3mr: add support of threaded isr
Date: Sun, 27 Dec 2020 21:51:16 +0800 [thread overview]
Message-ID: <202012272112.ZXvREaJO-lkp@intel.com> (raw)
In-Reply-To: <20201222101156.98308-18-kashyap.desai@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 3424 bytes --]
Hi Kashyap,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next v5.10 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Kashyap-Desai/Introducing-mpi3mr-driver/20201222-181732
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/877f4e22deefcac84c14ed953f360f8131e02d14
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kashyap-Desai/Introducing-mpi3mr-driver/20201222-181732
git checkout 877f4e22deefcac84c14ed953f360f8131e02d14
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/mpi3mr/mpi3mr_fw.c: In function 'mpi3mr_isr_poll':
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:481:6: warning: variable 'num_admin_replies' set but not used [-Wunused-but-set-variable]
481 | u32 num_admin_replies = 0, num_op_reply = 0;
| ^~~~~~~~~~~~~~~~~
vim +/num_admin_replies +481 drivers/scsi/mpi3mr/mpi3mr_fw.c
465
466 /**
467 * mpi3mr_isr_poll - Reply queue polling routine
468 * @irq: IRQ
469 * @privdata: Interrupt info
470 *
471 * poll for pending I/O completions in a loop until pending I/Os
472 * present or controller queue depth I/Os are processed.
473 *
474 * Return: IRQ_NONE or IRQ_HANDLED
475 */
476 static irqreturn_t mpi3mr_isr_poll(int irq, void *privdata)
477 {
478 struct mpi3mr_intr_info *intr_info = privdata;
479 struct mpi3mr_ioc *mrioc;
480 u16 midx;
> 481 u32 num_admin_replies = 0, num_op_reply = 0;
482
483 if (!intr_info || !intr_info->op_reply_q)
484 return IRQ_NONE;
485
486 mrioc = intr_info->mrioc;
487 midx = intr_info->msix_index;
488
489 /* Poll for pending IOs completions */
490 do {
491 if (!mrioc->intr_enabled)
492 break;
493
494 if (!midx)
495 num_admin_replies = mpi3mr_process_admin_reply_q(mrioc);
496 if (intr_info->op_reply_q)
497 num_op_reply +=
498 mpi3mr_process_op_reply_q(mrioc, intr_info);
499
500 usleep_range(mrioc->irqpoll_sleep, 10 * mrioc->irqpoll_sleep);
501
502 } while (atomic_read(&intr_info->op_reply_q->pend_ios) &&
503 (num_op_reply < mrioc->max_host_ios));
504
505 intr_info->op_reply_q->enable_irq_poll = false;
506 enable_irq(pci_irq_vector(mrioc->pdev, midx));
507
508 return IRQ_HANDLED;
509 }
510
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 71613 bytes --]
next prev parent reply other threads:[~2020-12-27 13:52 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 10:11 [PATCH 00/24] Introducing mpi3mr driver Kashyap Desai
2020-12-22 10:11 ` [PATCH 01/24] mpi3mr: add mpi30 Rev-R headers and Kconfig Kashyap Desai
2020-12-22 18:15 ` Bart Van Assche
2020-12-23 13:33 ` Kashyap Desai
2021-02-23 12:30 ` Hannes Reinecke
2021-03-02 18:11 ` Kashyap Desai
2020-12-22 10:11 ` [PATCH 02/24] mpi3mr: base driver code Kashyap Desai
2020-12-27 14:14 ` kernel test robot
2020-12-27 14:14 ` kernel test robot
2021-02-23 12:55 ` Hannes Reinecke
2021-03-02 18:36 ` Kashyap Desai
2020-12-22 10:11 ` [PATCH 03/24] mpi3mr: create operational request and reply queue pair Kashyap Desai
2020-12-22 18:18 ` Bart Van Assche
2020-12-23 13:16 ` Kashyap Desai
2021-02-28 13:04 ` Hannes Reinecke
2021-03-02 19:05 ` Kashyap Desai
2020-12-22 10:11 ` [PATCH 04/24] mpi3mr: add support of queue command processing Kashyap Desai
2021-02-22 15:23 ` Tomas Henzl
2021-02-25 13:24 ` Kashyap Desai
2021-02-25 14:11 ` Tomas Henzl
2021-02-28 13:22 ` Hannes Reinecke
2021-03-08 18:25 ` Kashyap Desai
2020-12-22 10:11 ` [PATCH 05/24] mpi3mr: add support of internal watchdog thread Kashyap Desai
2021-02-28 13:24 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 06/24] mpi3mr: add support of event handling part-1 Kashyap Desai
2020-12-27 13:14 ` kernel test robot
2020-12-27 13:14 ` kernel test robot
2021-02-22 15:31 ` Tomas Henzl
2021-02-25 13:36 ` Kashyap Desai
2021-03-01 6:47 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 07/24] mpi3mr: add support of event handling pcie devices part-2 Kashyap Desai
2021-03-01 6:52 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 08/24] mpi3mr: add support of event handling part-3 Kashyap Desai
2021-03-01 6:53 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 09/24] mpi3mr: add support for recovering controller Kashyap Desai
2021-03-01 6:56 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 10/24] mpi3mr: add support of timestamp sync with firmware Kashyap Desai
2021-03-01 6:57 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 11/24] mpi3mr: print ioc info for debugging Kashyap Desai
2021-03-01 6:59 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 12/24] mpi3mr: add bios_param shost template hook Kashyap Desai
2021-03-01 7:00 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 13/24] mpi3mr: implement scsi error handler hooks Kashyap Desai
2021-03-01 7:09 ` Hannes Reinecke
2021-04-16 14:12 ` Kashyap Desai
2021-04-16 14:31 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 14/24] mpi3mr: add change queue depth support Kashyap Desai
2021-03-01 7:10 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 15/24] mpi3mr: allow certain commands during pci-remove hook Kashyap Desai
2021-03-01 7:11 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 16/24] mpi3mr: hardware workaround for UNMAP commands to nvme drives Kashyap Desai
2021-03-01 7:13 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 17/24] mpi3mr: add support of threaded isr Kashyap Desai
2020-12-27 13:51 ` kernel test robot [this message]
2020-12-27 13:51 ` kernel test robot
2021-03-01 7:14 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 18/24] mpi3mr: add complete support of soft reset Kashyap Desai
2021-03-01 7:16 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 19/24] mpi3mr: print pending host ios for debug Kashyap Desai
2021-03-01 7:16 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 20/24] mpi3mr: wait for pending IO completions upon detection of VD IO timeout Kashyap Desai
2021-03-01 7:17 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 21/24] mpi3mr: add support of PM suspend and resume Kashyap Desai
2021-02-22 15:32 ` Tomas Henzl
2021-02-25 13:37 ` Kashyap Desai
2021-03-01 7:18 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 22/24] mpi3mr: add support of DSN secure fw check Kashyap Desai
2021-03-01 7:19 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 23/24] mpi3mr: add eedp dif dix support Kashyap Desai
2021-02-22 15:37 ` Tomas Henzl
2021-02-25 13:39 ` Kashyap Desai
2021-03-01 7:20 ` Hannes Reinecke
2020-12-22 10:11 ` [PATCH 24/24] mpi3mr: add event handling debug prints Kashyap Desai
2021-03-01 7:20 ` Hannes Reinecke
2021-02-22 15:39 ` [PATCH 00/24] Introducing mpi3mr driver Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012272112.ZXvREaJO-lkp@intel.com \
--to=lkp@intel.com \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=peter.rivera@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=steve.hagan@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.