From: Hans de Goede <hdegoede@redhat.com> To: Lee Jones <lee.jones@linaro.org>, MyungJoo Ham <myungjoo.ham@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Cezary Rojewski <cezary.rojewski@intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Jie Yang <yang.jie@linux.intel.com>, Mark Brown <broonie@kernel.org> Cc: Hans de Goede <hdegoede@redhat.com>, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: [PATCH 08/14] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call Date: Sun, 27 Dec 2020 22:12:26 +0100 [thread overview] Message-ID: <20201227211232.117801-9-hdegoede@redhat.com> (raw) In-Reply-To: <20201227211232.117801-1-hdegoede@redhat.com> The initial value of the GPIO should match the info->micd_modes[0].gpio value. arizona_extcon_probe() already stores the necessary flag in a mode variable, but instead of passing mode as flags to the gpiod_get() it was using a hardcoded GPIOD_OUT_LOW. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/extcon/extcon-arizona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 95acfe7620fd..145ca5cd40d5 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon/extcon-arizona.c @@ -1510,7 +1510,7 @@ static int arizona_extcon_probe(struct platform_device *pdev) */ info->micd_pol_gpio = gpiod_get_optional(arizona->dev, "wlf,micd-pol", - GPIOD_OUT_LOW); + mode); if (IS_ERR(info->micd_pol_gpio)) { ret = PTR_ERR(info->micd_pol_gpio); dev_err(arizona->dev, -- 2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com> To: Lee Jones <lee.jones@linaro.org>, MyungJoo Ham <myungjoo.ham@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Cezary Rojewski <cezary.rojewski@intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Jie Yang <yang.jie@linux.intel.com>, Mark Brown <broonie@kernel.org> Cc: Hans de Goede <hdegoede@redhat.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 08/14] extcon: arizona: Fix flags parameter to the gpiod_get("wlf, micd-pol") call Date: Sun, 27 Dec 2020 22:12:26 +0100 [thread overview] Message-ID: <20201227211232.117801-9-hdegoede@redhat.com> (raw) In-Reply-To: <20201227211232.117801-1-hdegoede@redhat.com> The initial value of the GPIO should match the info->micd_modes[0].gpio value. arizona_extcon_probe() already stores the necessary flag in a mode variable, but instead of passing mode as flags to the gpiod_get() it was using a hardcoded GPIOD_OUT_LOW. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/extcon/extcon-arizona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 95acfe7620fd..145ca5cd40d5 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon/extcon-arizona.c @@ -1510,7 +1510,7 @@ static int arizona_extcon_probe(struct platform_device *pdev) */ info->micd_pol_gpio = gpiod_get_optional(arizona->dev, "wlf,micd-pol", - GPIOD_OUT_LOW); + mode); if (IS_ERR(info->micd_pol_gpio)) { ret = PTR_ERR(info->micd_pol_gpio); dev_err(arizona->dev, -- 2.28.0
next prev parent reply other threads:[~2020-12-27 21:14 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-27 21:12 [PATCH 00/14] MFD/extcon/ASoC: Add support for Intel Bay Trail boards with WM5102 codec Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-27 21:12 ` [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-28 12:21 ` Mark Brown 2020-12-28 12:21 ` Mark Brown 2020-12-28 13:16 ` Hans de Goede 2020-12-28 13:16 ` Hans de Goede 2020-12-28 16:28 ` Mark Brown 2020-12-28 16:28 ` Mark Brown 2020-12-29 13:06 ` Charles Keepax 2020-12-29 13:06 ` Charles Keepax 2020-12-29 13:57 ` Hans de Goede 2020-12-29 13:57 ` Hans de Goede 2020-12-29 15:06 ` Charles Keepax 2020-12-29 15:06 ` Charles Keepax 2020-12-29 15:15 ` Mark Brown 2020-12-29 15:15 ` Mark Brown 2020-12-29 15:40 ` Hans de Goede 2020-12-29 15:40 ` Hans de Goede 2020-12-29 16:51 ` Richard Fitzgerald 2020-12-29 16:51 ` Richard Fitzgerald 2020-12-30 11:04 ` Hans de Goede 2020-12-30 11:04 ` Hans de Goede 2020-12-30 11:23 ` Richard Fitzgerald 2020-12-30 11:23 ` Richard Fitzgerald 2020-12-30 12:01 ` Hans de Goede 2020-12-30 12:01 ` Hans de Goede 2020-12-30 13:16 ` Mark Brown 2020-12-30 13:16 ` Mark Brown 2020-12-29 16:43 ` Richard Fitzgerald 2020-12-29 16:43 ` Richard Fitzgerald 2020-12-29 15:08 ` Mark Brown 2020-12-29 15:08 ` Mark Brown 2020-12-29 15:33 ` Hans de Goede 2020-12-29 15:33 ` Hans de Goede 2020-12-30 13:38 ` Mark Brown 2020-12-30 13:38 ` Mark Brown 2021-01-01 13:24 ` Hans de Goede 2021-01-01 13:24 ` Hans de Goede 2020-12-27 21:12 ` [PATCH 02/14] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1") Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-29 11:40 ` Charles Keepax 2020-12-29 11:40 ` Charles Keepax 2020-12-27 21:12 ` [PATCH 03/14] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-28 1:21 ` kernel test robot 2020-12-28 1:21 ` kernel test robot 2020-12-28 1:21 ` [RFC PATCH] mfd: arizona: ldoena_gpios can be static kernel test robot 2020-12-28 1:21 ` kernel test robot 2020-12-28 14:14 ` [PATCH 03/14] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI Andy Shevchenko 2020-12-28 14:14 ` Andy Shevchenko 2021-01-16 14:46 ` Hans de Goede 2021-01-16 14:46 ` Hans de Goede 2020-12-28 22:11 ` kernel test robot 2020-12-28 22:11 ` kernel test robot 2020-12-28 22:29 ` kernel test robot 2020-12-28 22:29 ` kernel test robot 2020-12-27 21:12 ` [PATCH 04/14] mfd: arizona: Allow building arizona MFD-core as module Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-29 12:00 ` Charles Keepax 2020-12-29 12:00 ` Charles Keepax 2021-01-11 19:12 ` Hans de Goede 2021-01-11 19:12 ` Hans de Goede 2020-12-27 21:12 ` [PATCH 05/14] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-27 21:12 ` [PATCH 06/14] extcon: arizona: Fix various races on driver unbind Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-29 12:10 ` Charles Keepax 2020-12-29 12:10 ` Charles Keepax 2020-12-27 21:12 ` [PATCH 07/14] extcon: arizona: Fix modalias Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-29 12:10 ` Charles Keepax 2020-12-29 12:10 ` Charles Keepax 2020-12-27 21:12 ` Hans de Goede [this message] 2020-12-27 21:12 ` [PATCH 08/14] extcon: arizona: Fix flags parameter to the gpiod_get("wlf, micd-pol") call Hans de Goede 2020-12-29 12:12 ` [PATCH 08/14] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call Charles Keepax 2020-12-29 12:12 ` Charles Keepax 2020-12-27 21:12 ` [PATCH 09/14] extcon: arizona: Add arizona_set_extcon_state() helper Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-29 12:57 ` Charles Keepax 2020-12-29 12:57 ` Charles Keepax 2020-12-27 21:12 ` [PATCH 10/14] extcon: arizona: Also report jack state through snd_soc_jack_report() Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-28 14:16 ` Andy Shevchenko 2020-12-28 14:16 ` Andy Shevchenko 2020-12-27 21:12 ` [PATCH 11/14] extcon: arizona: Use ASoC jack input-device when available Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-27 21:12 ` [PATCH 12/14] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr() Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2021-01-11 17:52 ` Pierre-Louis Bossart 2021-01-11 17:52 ` Pierre-Louis Bossart 2020-12-27 21:12 ` [PATCH 13/14] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102 Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-29 13:58 ` Charles Keepax 2020-12-29 13:58 ` Charles Keepax 2021-01-11 17:54 ` Pierre-Louis Bossart 2021-01-11 17:54 ` Pierre-Louis Bossart 2021-01-16 16:49 ` Hans de Goede 2021-01-16 16:49 ` Hans de Goede 2020-12-27 21:12 ` [PATCH 14/14] ASoC: Intel: bytcr_wm5102: Add jack detect support Hans de Goede 2020-12-27 21:12 ` Hans de Goede 2020-12-28 14:19 ` [PATCH 00/14] MFD/extcon/ASoC: Add support for Intel Bay Trail boards with WM5102 codec Andy Shevchenko 2020-12-28 14:19 ` Andy Shevchenko 2021-01-11 18:54 ` Hans de Goede 2021-01-11 18:54 ` Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201227211232.117801-9-hdegoede@redhat.com \ --to=hdegoede@redhat.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=cezary.rojewski@intel.com \ --cc=cw00.choi@samsung.com \ --cc=lee.jones@linaro.org \ --cc=liam.r.girdwood@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=myungjoo.ham@samsung.com \ --cc=patches@opensource.cirrus.com \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=yang.jie@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.