[PATCH] rxvt-unicode: use RPROVIDES instead of just PROVIDES

[PATCH] rxvt-unicode: use RPROVIDES instead of just PROVIDES

[Dmitry Baryshkov]

Change rxvt-unicode from using PROVIDES to RPROVIDES for
x-terminal-emulator, since the package provides x-terminal-emulator
functionality at runtime rather than at build time.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
index b064a63caa66..6ebd3afcb939 100644
--- a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
+++ b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
@@ -14,7 +14,7 @@ SRC_URI = "http://dist.schmorp.de/rxvt-unicode/Attic/rxvt-unicode-${PV}.tar.bz2
 
 inherit autotools pkgconfig update-alternatives
 
-PROVIDES = "virtual/x-terminal-emulator"
+RPROVIDES_${PN} = "virtual/x-terminal-emulator"
 ALTERNATIVE_${PN} = "x-terminal-emulator"
 ALTERNATIVE_TARGET[x-terminal-emulator] = "${bindir}/rxvt"
 
-- 
2.29.2

Re: [OE-core] [PATCH] rxvt-unicode: use RPROVIDES instead of just PROVIDES

[Richard Purdie]

On Mon, 2020-12-28 at 02:48 +0300, Dmitry Baryshkov wrote:
> Change rxvt-unicode from using PROVIDES to RPROVIDES for
> x-terminal-emulator, since the package provides x-terminal-emulator
> functionality at runtime rather than at build time.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
> b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
> index b064a63caa66..6ebd3afcb939 100644
> --- a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
> +++ b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
> @@ -14,7 +14,7 @@ SRC_URI = "
> http://dist.schmorp.de/rxvt-unicode/Attic/rxvt-unicode-${PV}.tar.bz2
>  
>  inherit autotools pkgconfig update-alternatives
>  
> -PROVIDES = "virtual/x-terminal-emulator"
> +RPROVIDES_${PN} = "virtual/x-terminal-emulator"
>  ALTERNATIVE_${PN} = "x-terminal-emulator"
>  ALTERNATIVE_TARGET[x-terminal-emulator] = "${bindir}/rxvt"

This isn't correct, virtual/XXX are build time namespaces designed to
be switched between with PREFERRED_PROVIDER, the package manager
doesn't do what you want/expect with this.

Cheers,

Richard

Re: [PATCH] rxvt-unicode: use RPROVIDES instead of just PROVIDES

[Dmitry Baryshkov]

Hello,

On Mon, 28 Dec 2020 at 02:48, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> Change rxvt-unicode from using PROVIDES to RPROVIDES for
> x-terminal-emulator, since the package provides x-terminal-emulator
> functionality at runtime rather than at build time.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

I'd like to ping for this patch. Is there something wrong with it?
Having "virtual/x-terminal-emulator" in PROVIDES is the wrong idea in
my opinion.
Other recipes can require virtual/x-terminal-emulator in runtime,
rather than at the build time.

> ---
>  meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
> index b064a63caa66..6ebd3afcb939 100644
> --- a/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
> +++ b/meta/recipes-sato/rxvt-unicode/rxvt-unicode.inc
> @@ -14,7 +14,7 @@ SRC_URI = "http://dist.schmorp.de/rxvt-unicode/Attic/rxvt-unicode-${PV}.tar.bz2
>
>  inherit autotools pkgconfig update-alternatives
>
> -PROVIDES = "virtual/x-terminal-emulator"
> +RPROVIDES_${PN} = "virtual/x-terminal-emulator"
>  ALTERNATIVE_${PN} = "x-terminal-emulator"
>  ALTERNATIVE_TARGET[x-terminal-emulator] = "${bindir}/rxvt"
>
> --
> 2.29.2
>


-- 
With best wishes
Dmitry

Re: [OE-core] [PATCH] rxvt-unicode: use RPROVIDES instead of just PROVIDES

[Quentin Schulz]

Hi Dmitry,

On Mon, Jan 11, 2021 at 02:24:51AM +0300, Dmitry Baryshkov wrote:
> Hello,
> 
> On Mon, 28 Dec 2020 at 02:48, Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
> >
> > Change rxvt-unicode from using PROVIDES to RPROVIDES for
> > x-terminal-emulator, since the package provides x-terminal-emulator
> > functionality at runtime rather than at build time.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> I'd like to ping for this patch. Is there something wrong with it?

Richard answered the same day you sent your patch, see:
https://lists.openembedded.org/g/openembedded-core/message/146248

Cheers,
Quentin