* [PATCH] thunderbolt: Drop duplicated 0x prefix from format string
@ 2021-01-05 9:19 Mika Westerberg
2021-01-05 10:08 ` Yehezkel Bernat
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2021-01-05 9:19 UTC (permalink / raw)
To: linux-usb
Cc: Michael Jamet, Yehezkel Bernat, Lukas Wunner, Andreas Noever,
Mika Westerberg
The tb_dbg() call is using %#x that already adds the 0x prefix so don't
duplicate it.
Fixes: 9039387e166e ("thunderbolt: Add USB4 router operation proxy for firmware connection manager")
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/thunderbolt/icm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
index 8b7f941a9bb7..b8c4159bc32d 100644
--- a/drivers/thunderbolt/icm.c
+++ b/drivers/thunderbolt/icm.c
@@ -2316,7 +2316,7 @@ static int icm_usb4_switch_nvm_authenticate_status(struct tb_switch *sw,
if (auth && auth->reply.route_hi == sw->config.route_hi &&
auth->reply.route_lo == sw->config.route_lo) {
- tb_dbg(tb, "NVM_AUTH found for %llx flags 0x%#x status %#x\n",
+ tb_dbg(tb, "NVM_AUTH found for %llx flags %#x status %#x\n",
tb_route(sw), auth->reply.hdr.flags, auth->reply.status);
if (auth->reply.hdr.flags & ICM_FLAGS_ERROR)
ret = -EIO;
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thunderbolt: Drop duplicated 0x prefix from format string
2021-01-05 9:19 [PATCH] thunderbolt: Drop duplicated 0x prefix from format string Mika Westerberg
@ 2021-01-05 10:08 ` Yehezkel Bernat
2021-01-07 12:24 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Yehezkel Bernat @ 2021-01-05 10:08 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-usb, Michael Jamet, Lukas Wunner, Andreas Noever
On Tue, Jan 5, 2021 at 11:19 AM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> The tb_dbg() call is using %#x that already adds the 0x prefix so don't
> duplicate it.
>
> Fixes: 9039387e166e ("thunderbolt: Add USB4 router operation proxy for firmware connection manager")
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/thunderbolt/icm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
> index 8b7f941a9bb7..b8c4159bc32d 100644
> --- a/drivers/thunderbolt/icm.c
> +++ b/drivers/thunderbolt/icm.c
> @@ -2316,7 +2316,7 @@ static int icm_usb4_switch_nvm_authenticate_status(struct tb_switch *sw,
>
> if (auth && auth->reply.route_hi == sw->config.route_hi &&
> auth->reply.route_lo == sw->config.route_lo) {
> - tb_dbg(tb, "NVM_AUTH found for %llx flags 0x%#x status %#x\n",
> + tb_dbg(tb, "NVM_AUTH found for %llx flags %#x status %#x\n",
> tb_route(sw), auth->reply.hdr.flags, auth->reply.status);
> if (auth->reply.hdr.flags & ICM_FLAGS_ERROR)
> ret = -EIO;
> --
> 2.29.2
>
Reviewed-by: Yehezkel Bernat <YehezkelShB@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thunderbolt: Drop duplicated 0x prefix from format string
2021-01-05 10:08 ` Yehezkel Bernat
@ 2021-01-07 12:24 ` Mika Westerberg
0 siblings, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2021-01-07 12:24 UTC (permalink / raw)
To: Yehezkel Bernat; +Cc: linux-usb, Michael Jamet, Lukas Wunner, Andreas Noever
On Tue, Jan 05, 2021 at 12:08:32PM +0200, Yehezkel Bernat wrote:
> On Tue, Jan 5, 2021 at 11:19 AM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > The tb_dbg() call is using %#x that already adds the 0x prefix so don't
> > duplicate it.
> >
> > Fixes: 9039387e166e ("thunderbolt: Add USB4 router operation proxy for firmware connection manager")
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
> > drivers/thunderbolt/icm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
> > index 8b7f941a9bb7..b8c4159bc32d 100644
> > --- a/drivers/thunderbolt/icm.c
> > +++ b/drivers/thunderbolt/icm.c
> > @@ -2316,7 +2316,7 @@ static int icm_usb4_switch_nvm_authenticate_status(struct tb_switch *sw,
> >
> > if (auth && auth->reply.route_hi == sw->config.route_hi &&
> > auth->reply.route_lo == sw->config.route_lo) {
> > - tb_dbg(tb, "NVM_AUTH found for %llx flags 0x%#x status %#x\n",
> > + tb_dbg(tb, "NVM_AUTH found for %llx flags %#x status %#x\n",
> > tb_route(sw), auth->reply.hdr.flags, auth->reply.status);
> > if (auth->reply.hdr.flags & ICM_FLAGS_ERROR)
> > ret = -EIO;
> > --
> > 2.29.2
> >
>
> Reviewed-by: Yehezkel Bernat <YehezkelShB@gmail.com>
Thanks! Applied now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-07 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 9:19 [PATCH] thunderbolt: Drop duplicated 0x prefix from format string Mika Westerberg
2021-01-05 10:08 ` Yehezkel Bernat
2021-01-07 12:24 ` Mika Westerberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.