From: Nathan Chancellor <natechancellor@gmail.com> To: Will Deacon <will@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, kernel-team@android.com, linux-kernel@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>, Catalin Marinas <catalin.marinas@arm.com>, Florian Weimer <fweimer@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Linus Torvalds <torvalds@linux-foundation.org>, Nick Desaulniers <ndesaulniers@google.com>, Russell King <linux@armlinux.org.uk>, Arnd Bergmann <arnd@kernel.org> Subject: Re: [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64 Date: Tue, 12 Jan 2021 16:06:37 -0700 [thread overview] Message-ID: <20210112230637.GA1480157@ubuntu-m3-large-x86> (raw) In-Reply-To: <20210112224832.10980-1-will@kernel.org> On Tue, Jan 12, 2021 at 10:48:32PM +0000, Will Deacon wrote: > GCC versions >= 4.9 and < 5.1 have been shown to emit memory references > beyond the stack pointer, resulting in memory corruption if an interrupt > is taken after the stack pointer has been adjusted but before the > reference has been executed. This leads to subtle, infrequent data > corruption such as the EXT4 problems reported by Russell King at the > link below. > > Life is too short for buggy compilers, so raise the minimum GCC version > required by arm64 to 5.1. > > Cc: Theodore Ts'o <tytso@mit.edu> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Florian Weimer <fweimer@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Reported-by: Russell King <linux@armlinux.org.uk> > Suggested-by: Arnd Bergmann <arnd@kernel.org> > Link: https://lore.kernel.org/r/20210105154726.GD1551@shell.armlinux.org.uk > Signed-off-by: Will Deacon <will@kernel.org> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Tested-by: Nathan Chancellor <natechancellor@gmail.com> > --- > include/linux/compiler-gcc.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index 74c6c0486eed..555ab0fddbef 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -13,6 +13,12 @@ > /* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ > #if GCC_VERSION < 40900 > # error Sorry, your version of GCC is too old - please use 4.9 or newer. > +#elif defined(CONFIG_ARM64) && GCC_VERSION < 50100 > +/* > + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 > + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk > + */ > +# error Sorry, your version of GCC is too old - please use 5.1 or newer. > #endif > > /* > -- > 2.30.0.284.gd98b1dd5eaa7-goog >
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com> To: Will Deacon <will@kernel.org> Cc: Florian Weimer <fweimer@redhat.com>, Arnd Bergmann <arnd@kernel.org>, Theodore Ts'o <tytso@mit.edu>, Peter Zijlstra <peterz@infradead.org>, Catalin Marinas <catalin.marinas@arm.com>, Nick Desaulniers <ndesaulniers@google.com>, linux-kernel@vger.kernel.org, Russell King <linux@armlinux.org.uk>, Linus Torvalds <torvalds@linux-foundation.org>, kernel-team@android.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64 Date: Tue, 12 Jan 2021 16:06:37 -0700 [thread overview] Message-ID: <20210112230637.GA1480157@ubuntu-m3-large-x86> (raw) In-Reply-To: <20210112224832.10980-1-will@kernel.org> On Tue, Jan 12, 2021 at 10:48:32PM +0000, Will Deacon wrote: > GCC versions >= 4.9 and < 5.1 have been shown to emit memory references > beyond the stack pointer, resulting in memory corruption if an interrupt > is taken after the stack pointer has been adjusted but before the > reference has been executed. This leads to subtle, infrequent data > corruption such as the EXT4 problems reported by Russell King at the > link below. > > Life is too short for buggy compilers, so raise the minimum GCC version > required by arm64 to 5.1. > > Cc: Theodore Ts'o <tytso@mit.edu> > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Florian Weimer <fweimer@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Reported-by: Russell King <linux@armlinux.org.uk> > Suggested-by: Arnd Bergmann <arnd@kernel.org> > Link: https://lore.kernel.org/r/20210105154726.GD1551@shell.armlinux.org.uk > Signed-off-by: Will Deacon <will@kernel.org> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Tested-by: Nathan Chancellor <natechancellor@gmail.com> > --- > include/linux/compiler-gcc.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index 74c6c0486eed..555ab0fddbef 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -13,6 +13,12 @@ > /* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ > #if GCC_VERSION < 40900 > # error Sorry, your version of GCC is too old - please use 4.9 or newer. > +#elif defined(CONFIG_ARM64) && GCC_VERSION < 50100 > +/* > + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 > + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk > + */ > +# error Sorry, your version of GCC is too old - please use 5.1 or newer. > #endif > > /* > -- > 2.30.0.284.gd98b1dd5eaa7-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-12 23:07 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-12 22:48 [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64 Will Deacon 2021-01-12 22:48 ` Will Deacon 2021-01-12 22:57 ` Nick Desaulniers 2021-01-12 22:57 ` Nick Desaulniers 2021-01-12 23:06 ` Nathan Chancellor [this message] 2021-01-12 23:06 ` Nathan Chancellor 2021-01-13 2:14 ` Linus Torvalds 2021-01-13 2:14 ` Linus Torvalds 2021-01-13 2:35 ` Linus Torvalds 2021-01-13 2:35 ` Linus Torvalds 2021-01-13 15:02 ` Catalin Marinas 2021-01-13 15:02 ` Catalin Marinas 2021-01-13 16:07 ` Catalin Marinas 2021-01-13 16:07 ` Catalin Marinas 2021-01-13 17:57 ` Masahiro Yamada 2021-01-13 17:57 ` Masahiro Yamada 2021-01-13 18:33 ` Joe Perches 2021-01-13 18:33 ` Joe Perches 2021-01-13 19:15 ` Linus Torvalds 2021-01-13 19:15 ` Linus Torvalds 2021-01-13 21:44 ` Russell King - ARM Linux admin 2021-01-13 21:44 ` Russell King - ARM Linux admin 2021-01-13 22:08 ` Linus Torvalds 2021-01-13 22:08 ` Linus Torvalds 2021-01-14 8:18 ` Ard Biesheuvel 2021-01-14 8:18 ` Ard Biesheuvel 2021-01-14 18:43 ` Linus Torvalds 2021-01-14 18:43 ` Linus Torvalds 2021-01-14 19:51 ` Joe Perches 2021-01-14 19:51 ` Joe Perches 2021-01-14 21:18 ` Linus Torvalds 2021-01-14 21:18 ` Linus Torvalds 2021-01-15 0:30 ` Joe Perches 2021-01-15 0:30 ` Joe Perches 2021-01-15 23:24 ` Linus Torvalds 2021-01-15 23:24 ` Linus Torvalds 2021-02-27 7:16 ` Masahiro Yamada 2021-02-27 7:16 ` Masahiro Yamada
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210112230637.GA1480157@ubuntu-m3-large-x86 \ --to=natechancellor@gmail.com \ --cc=arnd@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=fweimer@redhat.com \ --cc=kernel-team@android.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=ndesaulniers@google.com \ --cc=peterz@infradead.org \ --cc=torvalds@linux-foundation.org \ --cc=tytso@mit.edu \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.