From: kernel test robot <lkp@intel.com>
To: Ben Gardon <bgardon@google.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: kbuild-all@lists.01.org, Paolo Bonzini <pbonzini@redhat.com>,
Peter Xu <peterx@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Peter Shier <pshier@google.com>,
Peter Feiner <pfeiner@google.com>,
Junaid Shahid <junaids@google.com>,
Jim Mattson <jmattson@google.com>,
Yulei Zhang <yulei.kernel@gmail.com>
Subject: Re: [PATCH 14/24] kvm: mmu: Wrap mmu_lock lock / unlock in a function
Date: Wed, 13 Jan 2021 10:35:03 +0800 [thread overview]
Message-ID: <202101131005.UeNTg7uI-lkp@intel.com> (raw)
In-Reply-To: <20210112181041.356734-15-bgardon@google.com>
[-- Attachment #1: Type: text/plain, Size: 6173 bytes --]
Hi Ben,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.11-rc3 next-20210112]
[cannot apply to kvm/linux-next kvmarm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ben-Gardon/Allow-parallel-page-faults-with-TDP-MMU/20210113-021817
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a0d54b4f5b219fb31f0776e9f53aa137e78ae431
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/07d5ac23775a490560374edfec570f64687a6f09
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ben-Gardon/Allow-parallel-page-faults-with-TDP-MMU/20210113-021817
git checkout 07d5ac23775a490560374edfec570f64687a6f09
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/kvm/book3s_mmu_hpte.c: In function 'kvmppc_mmu_hpte_cache_map':
>> arch/powerpc/kvm/book3s_mmu_hpte.c:63:15: error: passing argument 1 of 'kvm_mmu_lock' from incompatible pointer type [-Werror=incompatible-pointer-types]
63 | kvm_mmu_lock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1498:31: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1498 | void kvm_mmu_lock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
>> arch/powerpc/kvm/book3s_mmu_hpte.c:92:17: error: passing argument 1 of 'kvm_mmu_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
92 | kvm_mmu_unlock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1499:33: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1499 | void kvm_mmu_unlock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
arch/powerpc/kvm/book3s_mmu_hpte.c: In function 'invalidate_pte':
arch/powerpc/kvm/book3s_mmu_hpte.c:110:15: error: passing argument 1 of 'kvm_mmu_lock' from incompatible pointer type [-Werror=incompatible-pointer-types]
110 | kvm_mmu_lock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1498:31: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1498 | void kvm_mmu_lock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
arch/powerpc/kvm/book3s_mmu_hpte.c:114:18: error: passing argument 1 of 'kvm_mmu_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
114 | kvm_mmu_unlock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1499:33: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1499 | void kvm_mmu_unlock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
arch/powerpc/kvm/book3s_mmu_hpte.c:127:17: error: passing argument 1 of 'kvm_mmu_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
127 | kvm_mmu_unlock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1499:33: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1499 | void kvm_mmu_unlock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
cc1: some warnings being treated as errors
vim +/kvm_mmu_lock +63 arch/powerpc/kvm/book3s_mmu_hpte.c
55
56 void kvmppc_mmu_hpte_cache_map(struct kvm_vcpu *vcpu, struct hpte_cache *pte)
57 {
58 u64 index;
59 struct kvmppc_vcpu_book3s *vcpu3s = to_book3s(vcpu);
60
61 trace_kvm_book3s_mmu_map(pte);
62
> 63 kvm_mmu_lock(vcpu3s);
64
65 /* Add to ePTE list */
66 index = kvmppc_mmu_hash_pte(pte->pte.eaddr);
67 hlist_add_head_rcu(&pte->list_pte, &vcpu3s->hpte_hash_pte[index]);
68
69 /* Add to ePTE_long list */
70 index = kvmppc_mmu_hash_pte_long(pte->pte.eaddr);
71 hlist_add_head_rcu(&pte->list_pte_long,
72 &vcpu3s->hpte_hash_pte_long[index]);
73
74 /* Add to vPTE list */
75 index = kvmppc_mmu_hash_vpte(pte->pte.vpage);
76 hlist_add_head_rcu(&pte->list_vpte, &vcpu3s->hpte_hash_vpte[index]);
77
78 /* Add to vPTE_long list */
79 index = kvmppc_mmu_hash_vpte_long(pte->pte.vpage);
80 hlist_add_head_rcu(&pte->list_vpte_long,
81 &vcpu3s->hpte_hash_vpte_long[index]);
82
83 #ifdef CONFIG_PPC_BOOK3S_64
84 /* Add to vPTE_64k list */
85 index = kvmppc_mmu_hash_vpte_64k(pte->pte.vpage);
86 hlist_add_head_rcu(&pte->list_vpte_64k,
87 &vcpu3s->hpte_hash_vpte_64k[index]);
88 #endif
89
90 vcpu3s->hpte_cache_count++;
91
> 92 kvm_mmu_unlock(vcpu3s);
93 }
94
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72483 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 14/24] kvm: mmu: Wrap mmu_lock lock / unlock in a function
Date: Wed, 13 Jan 2021 10:35:03 +0800 [thread overview]
Message-ID: <202101131005.UeNTg7uI-lkp@intel.com> (raw)
In-Reply-To: <20210112181041.356734-15-bgardon@google.com>
[-- Attachment #1: Type: text/plain, Size: 6301 bytes --]
Hi Ben,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.11-rc3 next-20210112]
[cannot apply to kvm/linux-next kvmarm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ben-Gardon/Allow-parallel-page-faults-with-TDP-MMU/20210113-021817
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a0d54b4f5b219fb31f0776e9f53aa137e78ae431
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/07d5ac23775a490560374edfec570f64687a6f09
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ben-Gardon/Allow-parallel-page-faults-with-TDP-MMU/20210113-021817
git checkout 07d5ac23775a490560374edfec570f64687a6f09
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/kvm/book3s_mmu_hpte.c: In function 'kvmppc_mmu_hpte_cache_map':
>> arch/powerpc/kvm/book3s_mmu_hpte.c:63:15: error: passing argument 1 of 'kvm_mmu_lock' from incompatible pointer type [-Werror=incompatible-pointer-types]
63 | kvm_mmu_lock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1498:31: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1498 | void kvm_mmu_lock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
>> arch/powerpc/kvm/book3s_mmu_hpte.c:92:17: error: passing argument 1 of 'kvm_mmu_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
92 | kvm_mmu_unlock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1499:33: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1499 | void kvm_mmu_unlock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
arch/powerpc/kvm/book3s_mmu_hpte.c: In function 'invalidate_pte':
arch/powerpc/kvm/book3s_mmu_hpte.c:110:15: error: passing argument 1 of 'kvm_mmu_lock' from incompatible pointer type [-Werror=incompatible-pointer-types]
110 | kvm_mmu_lock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1498:31: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1498 | void kvm_mmu_lock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
arch/powerpc/kvm/book3s_mmu_hpte.c:114:18: error: passing argument 1 of 'kvm_mmu_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
114 | kvm_mmu_unlock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1499:33: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1499 | void kvm_mmu_unlock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
arch/powerpc/kvm/book3s_mmu_hpte.c:127:17: error: passing argument 1 of 'kvm_mmu_unlock' from incompatible pointer type [-Werror=incompatible-pointer-types]
127 | kvm_mmu_unlock(vcpu3s);
| ^~~~~~
| |
| struct kvmppc_vcpu_book3s *
In file included from arch/powerpc/kvm/book3s_mmu_hpte.c:9:
include/linux/kvm_host.h:1499:33: note: expected 'struct kvm *' but argument is of type 'struct kvmppc_vcpu_book3s *'
1499 | void kvm_mmu_unlock(struct kvm *kvm);
| ~~~~~~~~~~~~^~~
cc1: some warnings being treated as errors
vim +/kvm_mmu_lock +63 arch/powerpc/kvm/book3s_mmu_hpte.c
55
56 void kvmppc_mmu_hpte_cache_map(struct kvm_vcpu *vcpu, struct hpte_cache *pte)
57 {
58 u64 index;
59 struct kvmppc_vcpu_book3s *vcpu3s = to_book3s(vcpu);
60
61 trace_kvm_book3s_mmu_map(pte);
62
> 63 kvm_mmu_lock(vcpu3s);
64
65 /* Add to ePTE list */
66 index = kvmppc_mmu_hash_pte(pte->pte.eaddr);
67 hlist_add_head_rcu(&pte->list_pte, &vcpu3s->hpte_hash_pte[index]);
68
69 /* Add to ePTE_long list */
70 index = kvmppc_mmu_hash_pte_long(pte->pte.eaddr);
71 hlist_add_head_rcu(&pte->list_pte_long,
72 &vcpu3s->hpte_hash_pte_long[index]);
73
74 /* Add to vPTE list */
75 index = kvmppc_mmu_hash_vpte(pte->pte.vpage);
76 hlist_add_head_rcu(&pte->list_vpte, &vcpu3s->hpte_hash_vpte[index]);
77
78 /* Add to vPTE_long list */
79 index = kvmppc_mmu_hash_vpte_long(pte->pte.vpage);
80 hlist_add_head_rcu(&pte->list_vpte_long,
81 &vcpu3s->hpte_hash_vpte_long[index]);
82
83 #ifdef CONFIG_PPC_BOOK3S_64
84 /* Add to vPTE_64k list */
85 index = kvmppc_mmu_hash_vpte_64k(pte->pte.vpage);
86 hlist_add_head_rcu(&pte->list_vpte_64k,
87 &vcpu3s->hpte_hash_vpte_64k[index]);
88 #endif
89
90 vcpu3s->hpte_cache_count++;
91
> 92 kvm_mmu_unlock(vcpu3s);
93 }
94
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 72483 bytes --]
next prev parent reply other threads:[~2021-01-13 2:36 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 18:10 [PATCH 00/24] Allow parallel page faults with TDP MMU Ben Gardon
2021-01-12 18:10 ` [PATCH 01/24] locking/rwlocks: Add contention detection for rwlocks Ben Gardon
2021-01-12 21:20 ` kernel test robot
2021-01-12 18:10 ` [PATCH 02/24] sched: Add needbreak " Ben Gardon
2021-01-12 18:10 ` [PATCH 03/24] sched: Add cond_resched_rwlock Ben Gardon
2021-01-12 18:10 ` [PATCH 04/24] kvm: x86/mmu: change TDP MMU yield function returns to match cond_resched Ben Gardon
2021-01-20 18:38 ` Sean Christopherson
2021-01-21 20:22 ` Paolo Bonzini
2021-01-26 14:11 ` Paolo Bonzini
2021-01-12 18:10 ` [PATCH 05/24] kvm: x86/mmu: Fix yielding in TDP MMU Ben Gardon
2021-01-20 19:28 ` Sean Christopherson
2021-01-22 1:06 ` Ben Gardon
2021-01-12 18:10 ` [PATCH 06/24] kvm: x86/mmu: Skip no-op changes in TDP MMU functions Ben Gardon
2021-01-20 19:51 ` Sean Christopherson
2021-01-25 23:51 ` Ben Gardon
2021-01-12 18:10 ` [PATCH 07/24] kvm: x86/mmu: Add comment on __tdp_mmu_set_spte Ben Gardon
2021-01-26 14:13 ` Paolo Bonzini
2021-01-12 18:10 ` [PATCH 08/24] kvm: x86/mmu: Add lockdep when setting a TDP MMU SPTE Ben Gardon
2021-01-20 19:58 ` Sean Christopherson
2021-01-26 14:13 ` Paolo Bonzini
2021-01-12 18:10 ` [PATCH 09/24] kvm: x86/mmu: Don't redundantly clear TDP MMU pt memory Ben Gardon
2021-01-20 20:06 ` Sean Christopherson
2021-01-26 14:14 ` Paolo Bonzini
2021-01-12 18:10 ` [PATCH 10/24] kvm: x86/mmu: Factor out handle disconnected pt Ben Gardon
2021-01-20 20:30 ` Sean Christopherson
2021-01-26 14:14 ` Paolo Bonzini
2021-01-12 18:10 ` [PATCH 11/24] kvm: x86/mmu: Put TDP MMU PT walks in RCU read-critical section Ben Gardon
2021-01-20 22:19 ` Sean Christopherson
2021-01-12 18:10 ` [PATCH 12/24] kvm: x86/kvm: RCU dereference tdp mmu page table links Ben Gardon
2021-01-22 18:32 ` Sean Christopherson
2021-01-26 18:17 ` Ben Gardon
2021-01-12 18:10 ` [PATCH 13/24] kvm: x86/mmu: Only free tdp_mmu pages after a grace period Ben Gardon
2021-01-12 18:10 ` [PATCH 14/24] kvm: mmu: Wrap mmu_lock lock / unlock in a function Ben Gardon
2021-01-13 2:35 ` kernel test robot [this message]
2021-01-13 2:35 ` kernel test robot
2021-01-12 18:10 ` [PATCH 15/24] kvm: mmu: Wrap mmu_lock cond_resched and needbreak Ben Gardon
2021-01-21 0:19 ` Sean Christopherson
2021-01-21 20:17 ` Paolo Bonzini
2021-01-26 14:38 ` Paolo Bonzini
2021-01-26 17:47 ` Ben Gardon
2021-01-26 17:55 ` Paolo Bonzini
2021-01-26 18:11 ` Ben Gardon
2021-01-26 20:47 ` Paolo Bonzini
2021-01-27 20:08 ` Ben Gardon
2021-01-27 20:55 ` Paolo Bonzini
2021-01-27 21:20 ` Ben Gardon
2021-01-28 8:18 ` Paolo Bonzini
2021-01-12 18:10 ` [PATCH 16/24] kvm: mmu: Wrap mmu_lock assertions Ben Gardon
2021-01-26 14:29 ` Paolo Bonzini
2021-01-12 18:10 ` [PATCH 17/24] kvm: mmu: Move mmu_lock to struct kvm_arch Ben Gardon
2021-01-12 18:10 ` [PATCH 18/24] kvm: x86/mmu: Use an rwlock for the x86 TDP MMU Ben Gardon
2021-01-21 0:45 ` Sean Christopherson
2021-01-12 18:10 ` [PATCH 19/24] kvm: x86/mmu: Protect tdp_mmu_pages with a lock Ben Gardon
2021-01-21 19:22 ` Sean Christopherson
2021-01-21 21:32 ` Sean Christopherson
2021-01-26 14:27 ` Paolo Bonzini
2021-01-26 21:47 ` Ben Gardon
2021-01-26 22:02 ` Sean Christopherson
2021-01-26 22:09 ` Sean Christopherson
2021-01-27 12:40 ` Paolo Bonzini
2021-01-26 13:37 ` Paolo Bonzini
2021-01-26 21:07 ` Ben Gardon
2021-01-12 18:10 ` [PATCH 20/24] kvm: x86/mmu: Add atomic option for setting SPTEs Ben Gardon
2021-01-13 0:05 ` kernel test robot
2021-01-13 0:05 ` kernel test robot
2021-01-26 14:21 ` Paolo Bonzini
2021-01-12 18:10 ` [PATCH 21/24] kvm: x86/mmu: Use atomic ops to set SPTEs in TDP MMU map Ben Gardon
2021-01-12 18:10 ` [PATCH 22/24] kvm: x86/mmu: Flush TLBs after zap in TDP MMU PF handler Ben Gardon
2021-01-21 0:05 ` Sean Christopherson
2021-01-12 18:10 ` [PATCH 23/24] kvm: x86/mmu: Freeze SPTEs in disconnected pages Ben Gardon
2021-01-12 18:10 ` [PATCH 24/24] kvm: x86/mmu: Allow parallel page faults for the TDP MMU Ben Gardon
2021-01-21 0:55 ` Sean Christopherson
2021-01-26 21:57 ` Ben Gardon
2021-01-27 17:14 ` Sean Christopherson
2021-01-26 13:37 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101131005.UeNTg7uI-lkp@intel.com \
--to=lkp@intel.com \
--cc=bgardon@google.com \
--cc=jmattson@google.com \
--cc=junaids@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=pfeiner@google.com \
--cc=pshier@google.com \
--cc=seanjc@google.com \
--cc=yulei.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.