All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Huaixin Chang <changhuaixin@linux.alibaba.com>
Cc: kbuild-all@lists.01.org, bsegall@google.com,
	dietmar.eggemann@arm.com, juri.lelli@redhat.com,
	khlebnikov@yandex-team.ru, linux-kernel@vger.kernel.org,
	mgorman@suse.de, mingo@redhat.com, pauld@redhead.com,
	peterz@infradead.org
Subject: Re: [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable
Date: Thu, 21 Jan 2021 06:01:53 +0800	[thread overview]
Message-ID: <202101210540.piOUr66G-lkp@intel.com> (raw)
In-Reply-To: <20210120122715.29493-3-changhuaixin@linux.alibaba.com>

[-- Attachment #1: Type: text/plain, Size: 8167 bytes --]

Hi Huaixin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on tip/master linux/master linus/master v5.11-rc4 next-20210120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 65bcf072e20ed7597caa902f170f293662b0af3c
config: x86_64-randconfig-s022-20210120 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-208-g46a52ca4-dirty
        # https://github.com/0day-ci/linux/commit/a62cc8421988be29990ad86e33e877fb8776f8bd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731
        git checkout a62cc8421988be29990ad86e33e877fb8776f8bd
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   kernel/sched/fair.c:879:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct sched_entity *se @@     got struct sched_entity [noderef] __rcu * @@
   kernel/sched/fair.c:879:34: sparse:     expected struct sched_entity *se
   kernel/sched/fair.c:879:34: sparse:     got struct sched_entity [noderef] __rcu *
   kernel/sched/fair.c:2523:13: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct task_struct *tsk @@     got struct task_struct [noderef] __rcu * @@
   kernel/sched/fair.c:2523:13: sparse:     expected struct task_struct *tsk
   kernel/sched/fair.c:2523:13: sparse:     got struct task_struct [noderef] __rcu *
   kernel/sched/fair.c:10660:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] sd @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:10660:9: sparse:     expected struct sched_domain *[assigned] sd
   kernel/sched/fair.c:10660:9: sparse:     got struct sched_domain [noderef] __rcu *parent
>> kernel/sched/fair.c:4623:6: sparse: sparse: symbol '__refill_cfs_bandwidth_runtime' was not declared. Should it be static?
   kernel/sched/fair.c:4937:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/fair.c:4937:22: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/fair.c:4937:22: sparse:    struct task_struct *
   kernel/sched/fair.c:5480:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:5480:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:5480:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:6668:20: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] sd @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:6668:20: sparse:     expected struct sched_domain *[assigned] sd
   kernel/sched/fair.c:6668:20: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:6790:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] tmp @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:6790:9: sparse:     expected struct sched_domain *[assigned] tmp
   kernel/sched/fair.c:6790:9: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:6988:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:6988:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:6988:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:7239:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:7239:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:7239:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:8210:40: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct sched_domain *child @@     got struct sched_domain [noderef] __rcu *child @@
   kernel/sched/fair.c:8210:40: sparse:     expected struct sched_domain *child
   kernel/sched/fair.c:8210:40: sparse:     got struct sched_domain [noderef] __rcu *child
   kernel/sched/fair.c:8703:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/fair.c:8703:22: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/fair.c:8703:22: sparse:    struct task_struct *
   kernel/sched/fair.c:9979:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] sd @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:9979:9: sparse:     expected struct sched_domain *[assigned] sd
   kernel/sched/fair.c:9979:9: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:9635:44: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct sched_domain *sd_parent @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:9635:44: sparse:     expected struct sched_domain *sd_parent
   kernel/sched/fair.c:9635:44: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:10057:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] sd @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:10057:9: sparse:     expected struct sched_domain *[assigned] sd
   kernel/sched/fair.c:10057:9: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:2467:9: sparse: sparse: context imbalance in 'task_numa_placement' - different lock contexts for basic block
   kernel/sched/fair.c:4593:31: sparse: sparse: marked inline, but without a definition
   kernel/sched/fair.c: note: in included file:
   kernel/sched/sched.h:1724:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct *
   kernel/sched/sched.h:1879:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:1879:9: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:1879:9: sparse:    struct task_struct *
   kernel/sched/sched.h:1724:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct *
   kernel/sched/sched.h:1724:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct *

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36569 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable
Date: Thu, 21 Jan 2021 06:01:53 +0800	[thread overview]
Message-ID: <202101210540.piOUr66G-lkp@intel.com> (raw)
In-Reply-To: <20210120122715.29493-3-changhuaixin@linux.alibaba.com>

[-- Attachment #1: Type: text/plain, Size: 8262 bytes --]

Hi Huaixin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/sched/core]
[also build test WARNING on tip/master linux/master linus/master v5.11-rc4 next-20210120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 65bcf072e20ed7597caa902f170f293662b0af3c
config: x86_64-randconfig-s022-20210120 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-208-g46a52ca4-dirty
        # https://github.com/0day-ci/linux/commit/a62cc8421988be29990ad86e33e877fb8776f8bd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731
        git checkout a62cc8421988be29990ad86e33e877fb8776f8bd
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   kernel/sched/fair.c:879:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct sched_entity *se @@     got struct sched_entity [noderef] __rcu * @@
   kernel/sched/fair.c:879:34: sparse:     expected struct sched_entity *se
   kernel/sched/fair.c:879:34: sparse:     got struct sched_entity [noderef] __rcu *
   kernel/sched/fair.c:2523:13: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct task_struct *tsk @@     got struct task_struct [noderef] __rcu * @@
   kernel/sched/fair.c:2523:13: sparse:     expected struct task_struct *tsk
   kernel/sched/fair.c:2523:13: sparse:     got struct task_struct [noderef] __rcu *
   kernel/sched/fair.c:10660:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] sd @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:10660:9: sparse:     expected struct sched_domain *[assigned] sd
   kernel/sched/fair.c:10660:9: sparse:     got struct sched_domain [noderef] __rcu *parent
>> kernel/sched/fair.c:4623:6: sparse: sparse: symbol '__refill_cfs_bandwidth_runtime' was not declared. Should it be static?
   kernel/sched/fair.c:4937:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/fair.c:4937:22: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/fair.c:4937:22: sparse:    struct task_struct *
   kernel/sched/fair.c:5480:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:5480:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:5480:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:6668:20: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] sd @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:6668:20: sparse:     expected struct sched_domain *[assigned] sd
   kernel/sched/fair.c:6668:20: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:6790:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] tmp @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:6790:9: sparse:     expected struct sched_domain *[assigned] tmp
   kernel/sched/fair.c:6790:9: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:6988:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:6988:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:6988:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:7239:38: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct task_struct *curr @@     got struct task_struct [noderef] __rcu *curr @@
   kernel/sched/fair.c:7239:38: sparse:     expected struct task_struct *curr
   kernel/sched/fair.c:7239:38: sparse:     got struct task_struct [noderef] __rcu *curr
   kernel/sched/fair.c:8210:40: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct sched_domain *child @@     got struct sched_domain [noderef] __rcu *child @@
   kernel/sched/fair.c:8210:40: sparse:     expected struct sched_domain *child
   kernel/sched/fair.c:8210:40: sparse:     got struct sched_domain [noderef] __rcu *child
   kernel/sched/fair.c:8703:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/fair.c:8703:22: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/fair.c:8703:22: sparse:    struct task_struct *
   kernel/sched/fair.c:9979:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] sd @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:9979:9: sparse:     expected struct sched_domain *[assigned] sd
   kernel/sched/fair.c:9979:9: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:9635:44: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected struct sched_domain *sd_parent @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:9635:44: sparse:     expected struct sched_domain *sd_parent
   kernel/sched/fair.c:9635:44: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:10057:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sched_domain *[assigned] sd @@     got struct sched_domain [noderef] __rcu *parent @@
   kernel/sched/fair.c:10057:9: sparse:     expected struct sched_domain *[assigned] sd
   kernel/sched/fair.c:10057:9: sparse:     got struct sched_domain [noderef] __rcu *parent
   kernel/sched/fair.c:2467:9: sparse: sparse: context imbalance in 'task_numa_placement' - different lock contexts for basic block
   kernel/sched/fair.c:4593:31: sparse: sparse: marked inline, but without a definition
   kernel/sched/fair.c: note: in included file:
   kernel/sched/sched.h:1724:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct *
   kernel/sched/sched.h:1879:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:1879:9: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:1879:9: sparse:    struct task_struct *
   kernel/sched/sched.h:1724:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct *
   kernel/sched/sched.h:1724:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct [noderef] __rcu *
   kernel/sched/sched.h:1724:25: sparse:    struct task_struct *

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36569 bytes --]

  parent reply	other threads:[~2021-01-20 22:12 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17  7:46 [PATCH 0/4] sched/fair: Burstable CFS bandwidth controller Huaixin Chang
2020-12-17  7:46 ` [PATCH 1/4] sched/fair: Introduce primitives for CFS bandwidth burst Huaixin Chang
2020-12-17 13:36   ` Peter Zijlstra
2020-12-21 13:53     ` changhuaixin
2021-01-12  9:21       ` changhuaixin
2020-12-17  7:46 ` [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable Huaixin Chang
2020-12-18  9:53   ` kernel test robot
2020-12-18  9:53     ` kernel test robot
2020-12-17  7:46 ` [PATCH 3/4] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang
2020-12-17  7:46 ` [PATCH 4/4] sched/fair: Add document for burstable CFS bandwidth control Huaixin Chang
2020-12-17 21:25 ` [PATCH 0/4] sched/fair: Burstable CFS bandwidth controller Benjamin Segall
2021-01-20 12:27 ` [PATCH v2 " Huaixin Chang
2021-01-20 12:27   ` [PATCH 1/4] sched/fair: Introduce primitives for CFS bandwidth burst Huaixin Chang
2021-01-20 12:27   ` [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable Huaixin Chang
2021-01-20 17:06     ` kernel test robot
2021-01-20 17:06       ` kernel test robot
2021-01-20 18:33     ` kernel test robot
2021-01-20 18:33       ` kernel test robot
2021-01-20 22:01     ` kernel test robot [this message]
2021-01-20 22:01       ` kernel test robot
2021-01-20 22:01     ` [RFC PATCH] sched/fair: __refill_cfs_bandwidth_runtime() can be static kernel test robot
2021-01-20 22:01       ` kernel test robot
2021-01-20 12:27   ` [PATCH 3/4] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang
2021-01-20 12:27   ` [PATCH 4/4] sched/fair: Add document for burstable CFS bandwidth control Huaixin Chang
2021-01-20 19:48     ` Randy Dunlap
2021-01-21 11:04 ` [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller Huaixin Chang
2021-01-21 11:04   ` [PATCH v3 1/4] sched/fair: Introduce primitives for CFS bandwidth burst Huaixin Chang
2021-03-10 12:39     ` Peter Zijlstra
2021-01-21 11:04   ` [PATCH v3 2/4] sched/fair: Make CFS bandwidth controller burstable Huaixin Chang
2021-03-10 13:04     ` Peter Zijlstra
2021-03-12 13:54       ` changhuaixin
2021-03-16 10:55         ` Peter Zijlstra
2021-01-21 11:04   ` [PATCH v3 3/4] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang
2021-03-10 13:10     ` Peter Zijlstra
2021-01-21 11:04   ` [PATCH v3 4/4] sched/fair: Add document for burstable CFS bandwidth control Huaixin Chang
2021-03-10 13:17     ` Peter Zijlstra
2021-01-26 10:18   ` [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller changhuaixin
2021-03-10 12:26     ` Peter Zijlstra
2021-02-09 13:17   ` Odin Ugedal
2021-02-09 10:28     ` Tejun Heo
2021-02-27 13:48     ` changhuaixin
2021-03-10 11:11       ` Odin Ugedal
2021-03-12 13:26         ` changhuaixin
2021-02-02 11:40 [PATCH " Huaixin Chang
2021-02-02 11:40 ` [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable Huaixin Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202101210540.piOUr66G-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bsegall@google.com \
    --cc=changhuaixin@linux.alibaba.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=khlebnikov@yandex-team.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=pauld@redhead.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.