From: Nathan Chancellor <natechancellor@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com, Joe Perches <joe@perches.com>,
Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>,
Pia Eichinger <pia.eichinger@st.oth-regensburg.de>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: adjust to clang-version.sh removal
Date: Thu, 21 Jan 2021 09:16:40 -0700 [thread overview]
Message-ID: <20210121161640.GA1101379@ubuntu-m3-large-x86> (raw)
In-Reply-To: <20210121160115.4676-1-lukas.bulwahn@gmail.com>
On Thu, Jan 21, 2021 at 05:01:15PM +0100, Lukas Bulwahn wrote:
> Commit 6c8ad4427f6e ("kbuild: check the minimum compiler version in
> Kconfig") removed ./scripts/clang-version.sh and moved its content to
> ./scripts/cc-version.sh.
>
> Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
>
> warning: no file matches F: scripts/clang-version.sh
>
> The CLANG/LLVM BUILD SUPPORT section in MAINTAINERS intends to track
> changes in ./scripts/clang-version.sh; as the file is removed, track
> changes in ./scripts/cc-version.sh instead now.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> applies cleanly on next-20210121
>
> Masahiro-san, please pick this quick fix-up patch.
Masahiro cannot pick this up because the patch to add clang-version.sh
to MAINTAINERS is in mmotm.
I think the better solution is for Andrew to drop the current version of
maintainers-add-a-couple-more-files-to-the-clang-llvm-section.patch
and pick up the second one I sent, which allows us to deal with this:
https://lore.kernel.org/lkml/20210114171629.592007-1-natechancellor@gmail.com/
I am not sure it is right for us to maintain cc-version.sh but I am open
to it if Masahiro agrees.
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e5d7cf38ec82..aafbea806a82 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4355,8 +4355,8 @@ B: https://github.com/ClangBuiltLinux/linux/issues
> C: irc://chat.freenode.net/clangbuiltlinux
> F: Documentation/kbuild/llvm.rst
> F: include/linux/compiler-clang.h
> +F: scripts/cc-version.sh
> F: scripts/clang-tools/
> -F: scripts/clang-version.sh
> F: scripts/lld-version.sh
> K: \b(?i:clang|llvm)\b
>
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com, Joe Perches <joe@perches.com>,
Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>,
Pia Eichinger <pia.eichinger@st.oth-regensburg.de>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: adjust to clang-version.sh removal
Date: Thu, 21 Jan 2021 16:16:40 +0000 [thread overview]
Message-ID: <20210121161640.GA1101379@ubuntu-m3-large-x86> (raw)
In-Reply-To: <20210121160115.4676-1-lukas.bulwahn@gmail.com>
On Thu, Jan 21, 2021 at 05:01:15PM +0100, Lukas Bulwahn wrote:
> Commit 6c8ad4427f6e ("kbuild: check the minimum compiler version in
> Kconfig") removed ./scripts/clang-version.sh and moved its content to
> ./scripts/cc-version.sh.
>
> Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
>
> warning: no file matches F: scripts/clang-version.sh
>
> The CLANG/LLVM BUILD SUPPORT section in MAINTAINERS intends to track
> changes in ./scripts/clang-version.sh; as the file is removed, track
> changes in ./scripts/cc-version.sh instead now.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> applies cleanly on next-20210121
>
> Masahiro-san, please pick this quick fix-up patch.
Masahiro cannot pick this up because the patch to add clang-version.sh
to MAINTAINERS is in mmotm.
I think the better solution is for Andrew to drop the current version of
maintainers-add-a-couple-more-files-to-the-clang-llvm-section.patch
and pick up the second one I sent, which allows us to deal with this:
https://lore.kernel.org/lkml/20210114171629.592007-1-natechancellor@gmail.com/
I am not sure it is right for us to maintain cc-version.sh but I am open
to it if Masahiro agrees.
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e5d7cf38ec82..aafbea806a82 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4355,8 +4355,8 @@ B: https://github.com/ClangBuiltLinux/linux/issues
> C: irc://chat.freenode.net/clangbuiltlinux
> F: Documentation/kbuild/llvm.rst
> F: include/linux/compiler-clang.h
> +F: scripts/cc-version.sh
> F: scripts/clang-tools/
> -F: scripts/clang-version.sh
> F: scripts/lld-version.sh
> K: \b(?i:clang|llvm)\b
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-01-21 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 16:01 [PATCH] MAINTAINERS: adjust to clang-version.sh removal Lukas Bulwahn
2021-01-21 16:01 ` Lukas Bulwahn
2021-01-21 16:15 ` Sedat Dilek
2021-01-21 16:15 ` Sedat Dilek
2021-01-21 16:22 ` Lukas Bulwahn
2021-01-21 16:22 ` Lukas Bulwahn
2021-01-22 12:33 ` Dan Carpenter
2021-01-22 12:33 ` Dan Carpenter
2021-01-23 2:38 ` Sedat Dilek
2021-01-23 2:38 ` Sedat Dilek
2021-01-23 9:20 ` Dan Carpenter
2021-01-23 9:20 ` Dan Carpenter
2021-01-21 16:16 ` Nathan Chancellor [this message]
2021-01-21 16:16 ` Nathan Chancellor
2021-01-21 16:20 ` Sedat Dilek
2021-01-21 16:20 ` Sedat Dilek
2021-01-21 16:25 ` Lukas Bulwahn
2021-01-21 16:25 ` Lukas Bulwahn
2021-01-21 17:26 ` Masahiro Yamada
2021-01-21 17:26 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121161640.GA1101379@ubuntu-m3-large-x86 \
--to=natechancellor@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pia.eichinger@st.oth-regensburg.de \
--cc=ralf.ramsauer@oth-regensburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.