All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: rename xlnx-zcu102.canbusN properties
@ 2021-01-18 16:25 Paolo Bonzini
  2021-01-19 16:32 ` Peter Maydell
  2021-01-22 13:21 ` Peter Maydell
  0 siblings, 2 replies; 6+ messages in thread
From: Paolo Bonzini @ 2021-01-18 16:25 UTC (permalink / raw)
  To: qemu-devel; +Cc: peter.maydell

The properties to attach a CANBUS object to the xlnx-zcu102 machine have
a period in them.  We want to use periods in properties for compound QAPI types,
and besides the "xlnx-zcu102." prefix is both unnecessary and different
from any other machine property name.  Remove it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/arm/xlnx-zcu102.c        |  4 ++--
 tests/qtest/xlnx-can-test.c | 30 +++++++++++++++---------------
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c
index 4ef0c516bf..c9713638c5 100644
--- a/hw/arm/xlnx-zcu102.c
+++ b/hw/arm/xlnx-zcu102.c
@@ -219,12 +219,12 @@ static void xlnx_zcu102_machine_instance_init(Object *obj)
     s->secure = false;
     /* Default to virt (EL2) being disabled */
     s->virt = false;
-    object_property_add_link(obj, "xlnx-zcu102.canbus0", TYPE_CAN_BUS,
+    object_property_add_link(obj, "canbus0", TYPE_CAN_BUS,
                              (Object **)&s->canbus[0],
                              object_property_allow_set_link,
                              0);
 
-    object_property_add_link(obj, "xlnx-zcu102.canbus1", TYPE_CAN_BUS,
+    object_property_add_link(obj, "canbus1", TYPE_CAN_BUS,
                              (Object **)&s->canbus[1],
                              object_property_allow_set_link,
                              0);
diff --git a/tests/qtest/xlnx-can-test.c b/tests/qtest/xlnx-can-test.c
index 3d1120005b..54de71a686 100644
--- a/tests/qtest/xlnx-can-test.c
+++ b/tests/qtest/xlnx-can-test.c
@@ -138,9 +138,9 @@ static void test_can_bus(void)
     uint8_t can_timestamp = 1;
 
     QTestState *qts = qtest_init("-machine xlnx-zcu102"
-                " -object can-bus,id=canbus0"
-                " -machine xlnx-zcu102.canbus0=canbus0"
-                " -machine xlnx-zcu102.canbus1=canbus0"
+                " -object can-bus,id=canbus"
+                " -machine canbus0=canbus"
+                " -machine canbus1=canbus"
                 );
 
     /* Configure the CAN0 and CAN1. */
@@ -175,9 +175,9 @@ static void test_can_loopback(void)
     uint32_t status = 0;
 
     QTestState *qts = qtest_init("-machine xlnx-zcu102"
-                " -object can-bus,id=canbus0"
-                " -machine xlnx-zcu102.canbus0=canbus0"
-                " -machine xlnx-zcu102.canbus1=canbus0"
+                " -object can-bus,id=canbus"
+                " -machine canbus0=canbus"
+                " -machine canbus1=canbus"
                 );
 
     /* Configure the CAN0 in loopback mode. */
@@ -223,9 +223,9 @@ static void test_can_filter(void)
     uint8_t can_timestamp = 1;
 
     QTestState *qts = qtest_init("-machine xlnx-zcu102"
-                " -object can-bus,id=canbus0"
-                " -machine xlnx-zcu102.canbus0=canbus0"
-                " -machine xlnx-zcu102.canbus1=canbus0"
+                " -object can-bus,id=canbus"
+                " -machine canbus0=canbus"
+                " -machine canbus1=canbus"
                 );
 
     /* Configure the CAN0 and CAN1. */
@@ -271,9 +271,9 @@ static void test_can_sleepmode(void)
     uint8_t can_timestamp = 1;
 
     QTestState *qts = qtest_init("-machine xlnx-zcu102"
-                " -object can-bus,id=canbus0"
-                " -machine xlnx-zcu102.canbus0=canbus0"
-                " -machine xlnx-zcu102.canbus1=canbus0"
+                " -object can-bus,id=canbus"
+                " -machine canbus0=canbus"
+                " -machine canbus1=canbus"
                 );
 
     /* Configure the CAN0. */
@@ -317,9 +317,9 @@ static void test_can_snoopmode(void)
     uint8_t can_timestamp = 1;
 
     QTestState *qts = qtest_init("-machine xlnx-zcu102"
-                " -object can-bus,id=canbus0"
-                " -machine xlnx-zcu102.canbus0=canbus0"
-                " -machine xlnx-zcu102.canbus1=canbus0"
+                " -object can-bus,id=canbus"
+                " -machine canbus0=canbus"
+                " -machine canbus1=canbus"
                 );
 
     /* Configure the CAN0. */
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties
  2021-01-18 16:25 [PATCH] arm: rename xlnx-zcu102.canbusN properties Paolo Bonzini
@ 2021-01-19 16:32 ` Peter Maydell
  2021-01-22 13:21 ` Peter Maydell
  1 sibling, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2021-01-19 16:32 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: QEMU Developers

On Mon, 18 Jan 2021 at 16:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The properties to attach a CANBUS object to the xlnx-zcu102 machine have
> a period in them.  We want to use periods in properties for compound QAPI types,
> and besides the "xlnx-zcu102." prefix is both unnecessary and different
> from any other machine property name.  Remove it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

I was wondering if we needed to go through the 2-release deprecate-and-drop
before we could rename these, but luckily for us they were only added
in this cycle so we've never released a QEMU with the current naming.

thanks
-- PMM


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties
  2021-01-18 16:25 [PATCH] arm: rename xlnx-zcu102.canbusN properties Paolo Bonzini
  2021-01-19 16:32 ` Peter Maydell
@ 2021-01-22 13:21 ` Peter Maydell
  2021-01-22 15:19   ` Edgar E. Iglesias
  2021-01-25 22:07   ` Vikram Garhwal
  1 sibling, 2 replies; 6+ messages in thread
From: Peter Maydell @ 2021-01-22 13:21 UTC (permalink / raw)
  To: Paolo Bonzini
  Cc: Edgar E. Iglesias, Alistair Francis, QEMU Developers, Vikram Garhwal

Just noticed this wasn't cc'd to the Xilinx folks. Would one
of you like to review it?

thanks
-- PMM

On Mon, 18 Jan 2021 at 16:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The properties to attach a CANBUS object to the xlnx-zcu102 machine have
> a period in them.  We want to use periods in properties for compound QAPI types,
> and besides the "xlnx-zcu102." prefix is both unnecessary and different
> from any other machine property name.  Remove it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/arm/xlnx-zcu102.c        |  4 ++--
>  tests/qtest/xlnx-can-test.c | 30 +++++++++++++++---------------
>  2 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c
> index 4ef0c516bf..c9713638c5 100644
> --- a/hw/arm/xlnx-zcu102.c
> +++ b/hw/arm/xlnx-zcu102.c
> @@ -219,12 +219,12 @@ static void xlnx_zcu102_machine_instance_init(Object *obj)
>      s->secure = false;
>      /* Default to virt (EL2) being disabled */
>      s->virt = false;
> -    object_property_add_link(obj, "xlnx-zcu102.canbus0", TYPE_CAN_BUS,
> +    object_property_add_link(obj, "canbus0", TYPE_CAN_BUS,
>                               (Object **)&s->canbus[0],
>                               object_property_allow_set_link,
>                               0);
>
> -    object_property_add_link(obj, "xlnx-zcu102.canbus1", TYPE_CAN_BUS,
> +    object_property_add_link(obj, "canbus1", TYPE_CAN_BUS,
>                               (Object **)&s->canbus[1],
>                               object_property_allow_set_link,
>                               0);
> diff --git a/tests/qtest/xlnx-can-test.c b/tests/qtest/xlnx-can-test.c
> index 3d1120005b..54de71a686 100644
> --- a/tests/qtest/xlnx-can-test.c
> +++ b/tests/qtest/xlnx-can-test.c
> @@ -138,9 +138,9 @@ static void test_can_bus(void)
>      uint8_t can_timestamp = 1;
>
>      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> -                " -object can-bus,id=canbus0"
> -                " -machine xlnx-zcu102.canbus0=canbus0"
> -                " -machine xlnx-zcu102.canbus1=canbus0"
> +                " -object can-bus,id=canbus"
> +                " -machine canbus0=canbus"
> +                " -machine canbus1=canbus"
>                  );
>
>      /* Configure the CAN0 and CAN1. */
> @@ -175,9 +175,9 @@ static void test_can_loopback(void)
>      uint32_t status = 0;
>
>      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> -                " -object can-bus,id=canbus0"
> -                " -machine xlnx-zcu102.canbus0=canbus0"
> -                " -machine xlnx-zcu102.canbus1=canbus0"
> +                " -object can-bus,id=canbus"
> +                " -machine canbus0=canbus"
> +                " -machine canbus1=canbus"
>                  );
>
>      /* Configure the CAN0 in loopback mode. */
> @@ -223,9 +223,9 @@ static void test_can_filter(void)
>      uint8_t can_timestamp = 1;
>
>      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> -                " -object can-bus,id=canbus0"
> -                " -machine xlnx-zcu102.canbus0=canbus0"
> -                " -machine xlnx-zcu102.canbus1=canbus0"
> +                " -object can-bus,id=canbus"
> +                " -machine canbus0=canbus"
> +                " -machine canbus1=canbus"
>                  );
>
>      /* Configure the CAN0 and CAN1. */
> @@ -271,9 +271,9 @@ static void test_can_sleepmode(void)
>      uint8_t can_timestamp = 1;
>
>      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> -                " -object can-bus,id=canbus0"
> -                " -machine xlnx-zcu102.canbus0=canbus0"
> -                " -machine xlnx-zcu102.canbus1=canbus0"
> +                " -object can-bus,id=canbus"
> +                " -machine canbus0=canbus"
> +                " -machine canbus1=canbus"
>                  );
>
>      /* Configure the CAN0. */
> @@ -317,9 +317,9 @@ static void test_can_snoopmode(void)
>      uint8_t can_timestamp = 1;
>
>      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> -                " -object can-bus,id=canbus0"
> -                " -machine xlnx-zcu102.canbus0=canbus0"
> -                " -machine xlnx-zcu102.canbus1=canbus0"
> +                " -object can-bus,id=canbus"
> +                " -machine canbus0=canbus"
> +                " -machine canbus1=canbus"
>                  );
>
>      /* Configure the CAN0. */
> --
> 2.26.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties
  2021-01-22 13:21 ` Peter Maydell
@ 2021-01-22 15:19   ` Edgar E. Iglesias
  2021-01-22 15:29     ` Peter Maydell
  2021-01-25 22:07   ` Vikram Garhwal
  1 sibling, 1 reply; 6+ messages in thread
From: Edgar E. Iglesias @ 2021-01-22 15:19 UTC (permalink / raw)
  To: Peter Maydell
  Cc: Paolo Bonzini, Alistair Francis, QEMU Developers, Vikram Garhwal

On Fri, Jan 22, 2021 at 01:21:53PM +0000, Peter Maydell wrote:
> Just noticed this wasn't cc'd to the Xilinx folks. Would one
> of you like to review it?

Looks good to me but we need to also update the test cases in
tests/qtest/xlnx-can-test.c.

Cheers,
Edgar




> 
> thanks
> -- PMM
> 
> On Mon, 18 Jan 2021 at 16:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > The properties to attach a CANBUS object to the xlnx-zcu102 machine have
> > a period in them.  We want to use periods in properties for compound QAPI types,
> > and besides the "xlnx-zcu102." prefix is both unnecessary and different
> > from any other machine property name.  Remove it.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >  hw/arm/xlnx-zcu102.c        |  4 ++--
> >  tests/qtest/xlnx-can-test.c | 30 +++++++++++++++---------------
> >  2 files changed, 17 insertions(+), 17 deletions(-)
> >
> > diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c
> > index 4ef0c516bf..c9713638c5 100644
> > --- a/hw/arm/xlnx-zcu102.c
> > +++ b/hw/arm/xlnx-zcu102.c
> > @@ -219,12 +219,12 @@ static void xlnx_zcu102_machine_instance_init(Object *obj)
> >      s->secure = false;
> >      /* Default to virt (EL2) being disabled */
> >      s->virt = false;
> > -    object_property_add_link(obj, "xlnx-zcu102.canbus0", TYPE_CAN_BUS,
> > +    object_property_add_link(obj, "canbus0", TYPE_CAN_BUS,
> >                               (Object **)&s->canbus[0],
> >                               object_property_allow_set_link,
> >                               0);
> >
> > -    object_property_add_link(obj, "xlnx-zcu102.canbus1", TYPE_CAN_BUS,
> > +    object_property_add_link(obj, "canbus1", TYPE_CAN_BUS,
> >                               (Object **)&s->canbus[1],
> >                               object_property_allow_set_link,
> >                               0);
> > diff --git a/tests/qtest/xlnx-can-test.c b/tests/qtest/xlnx-can-test.c
> > index 3d1120005b..54de71a686 100644
> > --- a/tests/qtest/xlnx-can-test.c
> > +++ b/tests/qtest/xlnx-can-test.c
> > @@ -138,9 +138,9 @@ static void test_can_bus(void)
> >      uint8_t can_timestamp = 1;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0 and CAN1. */
> > @@ -175,9 +175,9 @@ static void test_can_loopback(void)
> >      uint32_t status = 0;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0 in loopback mode. */
> > @@ -223,9 +223,9 @@ static void test_can_filter(void)
> >      uint8_t can_timestamp = 1;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0 and CAN1. */
> > @@ -271,9 +271,9 @@ static void test_can_sleepmode(void)
> >      uint8_t can_timestamp = 1;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0. */
> > @@ -317,9 +317,9 @@ static void test_can_snoopmode(void)
> >      uint8_t can_timestamp = 1;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0. */
> > --
> > 2.26.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties
  2021-01-22 15:19   ` Edgar E. Iglesias
@ 2021-01-22 15:29     ` Peter Maydell
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2021-01-22 15:29 UTC (permalink / raw)
  To: Edgar E. Iglesias
  Cc: Paolo Bonzini, Alistair Francis, QEMU Developers, Vikram Garhwal

On Fri, 22 Jan 2021 at 15:19, Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
>
> On Fri, Jan 22, 2021 at 01:21:53PM +0000, Peter Maydell wrote:
> > Just noticed this wasn't cc'd to the Xilinx folks. Would one
> > of you like to review it?
>
> Looks good to me but we need to also update the test cases in
> tests/qtest/xlnx-can-test.c.

...looks like the patch does that, did it miss something?

> > >  hw/arm/xlnx-zcu102.c        |  4 ++--
> > >  tests/qtest/xlnx-can-test.c | 30 +++++++++++++++---------------

thanks
-- PMM


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties
  2021-01-22 13:21 ` Peter Maydell
  2021-01-22 15:19   ` Edgar E. Iglesias
@ 2021-01-25 22:07   ` Vikram Garhwal
  1 sibling, 0 replies; 6+ messages in thread
From: Vikram Garhwal @ 2021-01-25 22:07 UTC (permalink / raw)
  To: Peter Maydell
  Cc: Paolo Bonzini, Alistair Francis, QEMU Developers, Edgar E. Iglesias

On Fri, Jan 22, 2021 at 01:21:53PM +0000, Peter Maydell wrote:
Patch looks good to me.
Reviewed-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> Just noticed this wasn't cc'd to the Xilinx folks. Would one
> of you like to review it?
>
> thanks
> -- PMM
>
> On Mon, 18 Jan 2021 at 16:25, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > The properties to attach a CANBUS object to the xlnx-zcu102 machine have
> > a period in them.  We want to use periods in properties for compound QAPI types,
> > and besides the "xlnx-zcu102." prefix is both unnecessary and different
> > from any other machine property name.  Remove it.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >  hw/arm/xlnx-zcu102.c        |  4 ++--
> >  tests/qtest/xlnx-can-test.c | 30 +++++++++++++++---------------
> >  2 files changed, 17 insertions(+), 17 deletions(-)
> >
> > diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c
> > index 4ef0c516bf..c9713638c5 100644
> > --- a/hw/arm/xlnx-zcu102.c
> > +++ b/hw/arm/xlnx-zcu102.c
> > @@ -219,12 +219,12 @@ static void xlnx_zcu102_machine_instance_init(Object *obj)
> >      s->secure = false;
> >      /* Default to virt (EL2) being disabled */
> >      s->virt = false;
> > -    object_property_add_link(obj, "xlnx-zcu102.canbus0", TYPE_CAN_BUS,
> > +    object_property_add_link(obj, "canbus0", TYPE_CAN_BUS,
> >                               (Object **)&s->canbus[0],
> >                               object_property_allow_set_link,
> >                               0);
> >
> > -    object_property_add_link(obj, "xlnx-zcu102.canbus1", TYPE_CAN_BUS,
> > +    object_property_add_link(obj, "canbus1", TYPE_CAN_BUS,
> >                               (Object **)&s->canbus[1],
> >                               object_property_allow_set_link,
> >                               0);
> > diff --git a/tests/qtest/xlnx-can-test.c b/tests/qtest/xlnx-can-test.c
> > index 3d1120005b..54de71a686 100644
> > --- a/tests/qtest/xlnx-can-test.c
> > +++ b/tests/qtest/xlnx-can-test.c
> > @@ -138,9 +138,9 @@ static void test_can_bus(void)
> >      uint8_t can_timestamp = 1;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0 and CAN1. */
> > @@ -175,9 +175,9 @@ static void test_can_loopback(void)
> >      uint32_t status = 0;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0 in loopback mode. */
> > @@ -223,9 +223,9 @@ static void test_can_filter(void)
> >      uint8_t can_timestamp = 1;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0 and CAN1. */
> > @@ -271,9 +271,9 @@ static void test_can_sleepmode(void)
> >      uint8_t can_timestamp = 1;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0. */
> > @@ -317,9 +317,9 @@ static void test_can_snoopmode(void)
> >      uint8_t can_timestamp = 1;
> >
> >      QTestState *qts = qtest_init("-machine xlnx-zcu102"
> > -                " -object can-bus,id=canbus0"
> > -                " -machine xlnx-zcu102.canbus0=canbus0"
> > -                " -machine xlnx-zcu102.canbus1=canbus0"
> > +                " -object can-bus,id=canbus"
> > +                " -machine canbus0=canbus"
> > +                " -machine canbus1=canbus"
> >                  );
> >
> >      /* Configure the CAN0. */
> > --
> > 2.26.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-25 22:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 16:25 [PATCH] arm: rename xlnx-zcu102.canbusN properties Paolo Bonzini
2021-01-19 16:32 ` Peter Maydell
2021-01-22 13:21 ` Peter Maydell
2021-01-22 15:19   ` Edgar E. Iglesias
2021-01-22 15:29     ` Peter Maydell
2021-01-25 22:07   ` Vikram Garhwal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.