* [Intel-gfx] [PATCH 0/2] HDCP 2.2 DP errata
@ 2021-01-27 8:24 Anshuman Gupta
2021-01-27 8:24 ` [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg Anshuman Gupta
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Anshuman Gupta @ 2021-01-27 8:24 UTC (permalink / raw)
To: intel-gfx
HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
as well.
Anshuman Gupta (2):
drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 56 +++++++++++++-------
include/drm/drm_hdcp.h | 5 +-
2 files changed, 41 insertions(+), 20 deletions(-)
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
2021-01-27 8:24 [Intel-gfx] [PATCH 0/2] HDCP 2.2 DP errata Anshuman Gupta
@ 2021-01-27 8:24 ` Anshuman Gupta
2021-03-24 9:35 ` Nautiyal, Ankit K
2021-01-27 8:24 ` [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16 Anshuman Gupta
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Anshuman Gupta @ 2021-01-27 8:24 UTC (permalink / raw)
To: intel-gfx
As documented in HDCP 2.2 DP Errata spec transmitter should abort the
authentication protocol in case transmitter has not received the
entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg
within {110,7,5} miliseconds.
Adding above msg timeout values and aborting the HDCP authentication
in case it timedout to read entire msg.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
Cc: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 56 +++++++++++++-------
include/drm/drm_hdcp.h | 3 ++
2 files changed, 40 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
index f372e25edab4..f7cc5cbcabc6 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
@@ -292,39 +292,42 @@ struct hdcp2_dp_msg_data {
u8 msg_id;
u32 offset;
bool msg_detectable;
+ bool msg_can_timedout;
u32 timeout;
u32 timeout2; /* Added for non_paired situation */
+ /* Timeout to read entire msg */
+ u32 msg_read_timeout;
};
static const struct hdcp2_dp_msg_data hdcp2_dp_msg_data[] = {
- { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0 },
+ { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, false, 0, 0, 0},
{ HDCP_2_2_AKE_SEND_CERT, DP_HDCP_2_2_AKE_SEND_CERT_OFFSET,
- false, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
+ false, true, HDCP_2_2_CERT_TIMEOUT_MS, 0, HDCP_2_2_DP_CERT_READ_TIMEOUT_MS},
{ HDCP_2_2_AKE_NO_STORED_KM, DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET,
- false, 0, 0 },
+ false, false, 0, 0, 0 },
{ HDCP_2_2_AKE_STORED_KM, DP_HDCP_2_2_AKE_STORED_KM_OFFSET,
- false, 0, 0 },
+ false, false, 0, 0, 0 },
{ HDCP_2_2_AKE_SEND_HPRIME, DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET,
- true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
- HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
+ true, true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
+ HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS, HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS},
{ HDCP_2_2_AKE_SEND_PAIRING_INFO,
- DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true,
- HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
- { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0 },
+ DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true, true,
+ HDCP_2_2_PAIRING_TIMEOUT_MS, 0, HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS },
+ { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, false, 0, 0, 0 },
{ HDCP_2_2_LC_SEND_LPRIME, DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET,
- false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0 },
- { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false,
- 0, 0 },
+ false, false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0, 0 },
+ { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false, false,
+ 0, 0, 0 },
{ HDCP_2_2_REP_SEND_RECVID_LIST,
- DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true,
- HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
- { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false,
- 0, 0 },
+ DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true, false,
+ HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0, 0 },
+ { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false, false,
+ 0, 0, 0 },
{ HDCP_2_2_REP_STREAM_MANAGE,
- DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false,
- 0, 0 },
+ DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false, false,
+ 0, 0, 0},
{ HDCP_2_2_REP_STREAM_READY, DP_HDCP_2_2_REP_STREAM_READY_OFFSET,
- false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
+ false, false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0, 0 },
/* local define to shovel this through the write_2_2 interface */
#define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
{ HDCP_2_2_ERRATA_DP_STREAM_TYPE,
@@ -513,6 +516,8 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
u8 *byte = buf;
ssize_t ret, bytes_to_recv, len;
const struct hdcp2_dp_msg_data *hdcp2_msg_data;
+ ktime_t msg_end;
+ bool msg_expired;
hdcp2_msg_data = get_hdcp2_dp_msg_data(msg_id);
if (!hdcp2_msg_data)
@@ -539,6 +544,11 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
len = bytes_to_recv > DP_AUX_MAX_PAYLOAD_BYTES ?
DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv;
+ /* Entire msg read timeout since initiate of msg read */
+ if (bytes_to_recv == size - 1)
+ msg_end = ktime_add_ms(ktime_get_raw(),
+ hdcp2_msg_data->msg_read_timeout);
+
ret = drm_dp_dpcd_read(&dig_port->dp.aux, offset,
(void *)byte, len);
if (ret < 0) {
@@ -551,6 +561,14 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
byte += ret;
offset += ret;
}
+
+ msg_expired = ktime_after(ktime_get_raw(), msg_end);
+ if (msg_expired && hdcp2_msg_data->msg_can_timedout) {
+ drm_dbg_kms(&i915->drm, "msg_id %d, entire msg read timeout(mSec): %d\n",
+ msg_id, hdcp2_msg_data->msg_read_timeout);
+ return -ETIMEDOUT;
+ }
+
byte = buf;
*byte = msg_id;
diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
index ac22c246542a..2b165a0f434f 100644
--- a/include/drm/drm_hdcp.h
+++ b/include/drm/drm_hdcp.h
@@ -224,9 +224,12 @@ struct hdcp2_rep_stream_ready {
/* HDCP2.2 TIMEOUTs in mSec */
#define HDCP_2_2_CERT_TIMEOUT_MS 100
+#define HDCP_2_2_DP_CERT_READ_TIMEOUT_MS 110
#define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
#define HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS 200
+#define HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS 7
#define HDCP_2_2_PAIRING_TIMEOUT_MS 200
+#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
#define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
#define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
2021-01-27 8:24 [Intel-gfx] [PATCH 0/2] HDCP 2.2 DP errata Anshuman Gupta
2021-01-27 8:24 ` [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg Anshuman Gupta
@ 2021-01-27 8:24 ` Anshuman Gupta
2021-03-24 4:45 ` Nautiyal, Ankit K
2021-01-27 12:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP 2.2 DP errata Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Anshuman Gupta @ 2021-01-27 8:24 UTC (permalink / raw)
To: intel-gfx
Fix LC_Send_L_Prime message timeout to 16 as documented
in DP HDCP 2.2 errata page 3.
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
Cc: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
include/drm/drm_hdcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
index 2b165a0f434f..0b1111e3228e 100644
--- a/include/drm/drm_hdcp.h
+++ b/include/drm/drm_hdcp.h
@@ -231,7 +231,7 @@ struct hdcp2_rep_stream_ready {
#define HDCP_2_2_PAIRING_TIMEOUT_MS 200
#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
#define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
-#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
+#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 16
#define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
#define HDCP_2_2_STREAM_READY_TIMEOUT_MS 100
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP 2.2 DP errata
2021-01-27 8:24 [Intel-gfx] [PATCH 0/2] HDCP 2.2 DP errata Anshuman Gupta
2021-01-27 8:24 ` [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg Anshuman Gupta
2021-01-27 8:24 ` [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16 Anshuman Gupta
@ 2021-01-27 12:15 ` Patchwork
2021-01-27 12:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-27 14:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-27 12:15 UTC (permalink / raw)
To: Gupta, Anshuman; +Cc: intel-gfx
== Series Details ==
Series: HDCP 2.2 DP errata
URL : https://patchwork.freedesktop.org/series/86340/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
34fca57dca70 drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
total: 0 errors, 1 warnings, 0 checks, 106 lines checked
73b045d7cdac drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for HDCP 2.2 DP errata
2021-01-27 8:24 [Intel-gfx] [PATCH 0/2] HDCP 2.2 DP errata Anshuman Gupta
` (2 preceding siblings ...)
2021-01-27 12:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP 2.2 DP errata Patchwork
@ 2021-01-27 12:46 ` Patchwork
2021-01-27 14:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-27 12:46 UTC (permalink / raw)
To: Gupta, Anshuman; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 3792 bytes --]
== Series Details ==
Series: HDCP 2.2 DP errata
URL : https://patchwork.freedesktop.org/series/86340/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9687 -> Patchwork_19514
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/index.html
Known issues
------------
Here are the changes found in Patchwork_19514 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +26 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][2] ([i915#2283])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@gem_tiled_blits@basic:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-tgl-y/igt@gem_tiled_blits@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/fi-tgl-y/igt@gem_tiled_blits@basic.html
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [PASS][6] -> [FAIL][7] ([i915#1161])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html
#### Possible fixes ####
* igt@kms_chamelium@dp-crc-fast:
- fi-icl-u2: [FAIL][8] ([i915#1161] / [i915#262]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@prime_vgem@basic-gtt:
- fi-tgl-y: [DMESG-WARN][10] ([i915#402]) -> [PASS][11] +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/fi-tgl-y/igt@prime_vgem@basic-gtt.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/fi-tgl-y/igt@prime_vgem@basic-gtt.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (45 -> 39)
------------------------------
Missing (6): fi-jsl-1 fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9687 -> Patchwork_19514
CI-20190529: 20190529
CI_DRM_9687: 7b5229b02338bfb24c3db4e76abb328d1e9cf8f1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5974: a85398dcae50930c0e27548cf8c9575ad0bf69d1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19514: 73b045d7cdace6e291536c0edf4607e45fa66c1a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
73b045d7cdac drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
34fca57dca70 drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/index.html
[-- Attachment #1.2: Type: text/html, Size: 4768 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for HDCP 2.2 DP errata
2021-01-27 8:24 [Intel-gfx] [PATCH 0/2] HDCP 2.2 DP errata Anshuman Gupta
` (3 preceding siblings ...)
2021-01-27 12:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-01-27 14:50 ` Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-01-27 14:50 UTC (permalink / raw)
To: Gupta, Anshuman; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 27038 bytes --]
== Series Details ==
Series: HDCP 2.2 DP errata
URL : https://patchwork.freedesktop.org/series/86340/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9687_full -> Patchwork_19514_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19514_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@chamelium:
- shard-iclb: NOTRUN -> [SKIP][1] ([fdo#111827])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@feature_discovery@chamelium.html
* igt@gem_ctx_persistence@clone:
- shard-hsw: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-hsw4/igt@gem_ctx_persistence@clone.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][3] -> [FAIL][4] ([i915#2846])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl2/igt@gem_exec_fair@basic-deadline.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb5/igt@gem_exec_fair@basic-pace@bcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-tglb1/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_reloc@basic-many-active@vcs0:
- shard-kbl: NOTRUN -> [FAIL][9] ([i915#2389]) +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl6/igt@gem_exec_reloc@basic-many-active@vcs0.html
* igt@gem_exec_schedule@u-fairslice@vecs0:
- shard-skl: [PASS][10] -> [DMESG-WARN][11] ([i915#1610] / [i915#2803])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl10/igt@gem_exec_schedule@u-fairslice@vecs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl5/igt@gem_exec_schedule@u-fairslice@vecs0.html
* igt@gem_render_copy@yf-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][12] ([i915#768]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@gem_render_copy@yf-tiled-to-vebox-linear.html
* igt@gem_softpin@evict-snoop-interruptible:
- shard-iclb: NOTRUN -> [SKIP][13] ([fdo#109312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@gem_softpin@evict-snoop-interruptible.html
* igt@gem_vm_create@destroy-race:
- shard-tglb: [PASS][14] -> [INCOMPLETE][15] ([i915#2912])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb1/igt@gem_vm_create@destroy-race.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-tglb2/igt@gem_vm_create@destroy-race.html
* igt@gen7_exec_parse@basic-allowed:
- shard-iclb: NOTRUN -> [SKIP][16] ([fdo#109289])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@gen7_exec_parse@basic-allowed.html
* igt@i915_hangman@engine-error@vecs0:
- shard-kbl: NOTRUN -> [SKIP][17] ([fdo#109271]) +45 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl6/igt@i915_hangman@engine-error@vecs0.html
* igt@i915_selftest@live@hangcheck:
- shard-hsw: NOTRUN -> [INCOMPLETE][18] ([i915#2782])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-hsw4/igt@i915_selftest@live@hangcheck.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#2597])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb8/igt@kms_async_flips@test-time-stamp.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-tglb3/igt@kms_async_flips@test-time-stamp.html
* igt@kms_ccs@pipe-c-crc-primary-basic:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111304])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_ccs@pipe-c-crc-primary-basic.html
* igt@kms_chamelium@dp-mode-timings:
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#109284] / [fdo#111827]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-hsw: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-hsw4/igt@kms_chamelium@vga-hpd-enable-disable-mode.html
* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [PASS][24] -> [DMESG-WARN][25] ([i915#1982]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl6/igt@kms_color@pipe-a-ctm-0-75.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_color@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-c-ctm-green-to-red:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl6/igt@kms_color_chamelium@pipe-c-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html
* igt@kms_content_protection@atomic-dpms:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109300] / [fdo#111066])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_content_protection@atomic-dpms.html
* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#54]) +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-random:
- shard-skl: NOTRUN -> [FAIL][31] ([i915#54]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html
* igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge:
- shard-hsw: NOTRUN -> [SKIP][32] ([fdo#109271]) +14 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-hsw4/igt@kms_cursor_edge_walk@pipe-d-64x64-top-edge.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109274] / [fdo#109278])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: NOTRUN -> [FAIL][34] ([i915#2346])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][35] -> [FAIL][36] ([i915#79])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#109280]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt.html
* igt@kms_hdr@bpc-switch:
- shard-skl: NOTRUN -> [FAIL][38] ([i915#1188])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_hdr@bpc-switch.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#533]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#533]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][41] ([fdo#108145] / [i915#265])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][42] -> [FAIL][43] ([fdo#108145] / [i915#265]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_cursor@pipe-d-viewport-size-64:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#109278]) +4 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_plane_cursor@pipe-d-viewport-size-64.html
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109274]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_plane_scaling@2x-scaler-multi-pipe.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#658])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#658])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#658]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#109642] / [fdo#111068] / [i915#658])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_dpms:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109441])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_psr@psr2_dpms.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][52] -> [SKIP][53] ([fdo#109441]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-skl: [PASS][54] -> [INCOMPLETE][55] ([i915#198])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-skl: NOTRUN -> [SKIP][56] ([fdo#109271]) +36 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@nouveau_crc@pipe-d-ctx-flip-detection.html
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278] / [i915#2530])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@nouveau_crc@pipe-d-ctx-flip-detection.html
#### Possible fixes ####
* igt@gem_ctx_persistence@smoketest:
- shard-iclb: [FAIL][58] ([i915#2896]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb1/igt@gem_ctx_persistence@smoketest.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb4/igt@gem_ctx_persistence@smoketest.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [FAIL][60] ([i915#2842]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl2/igt@gem_exec_fair@basic-none@vcs1.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl7/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][62] ([i915#2842]) -> [PASS][63] +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_whisper@basic-fds-priority:
- shard-iclb: [INCOMPLETE][64] ([i915#1394]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb7/igt@gem_exec_whisper@basic-fds-priority.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@gem_exec_whisper@basic-fds-priority.html
* igt@gem_softpin@noreloc-s3:
- shard-kbl: [INCOMPLETE][66] ([i915#2405]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl6/igt@gem_softpin@noreloc-s3.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl1/igt@gem_softpin@noreloc-s3.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][68] ([i915#454]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-kbl: [INCOMPLETE][70] ([i915#151]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl2/igt@i915_pm_rpm@system-suspend-modeset.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl7/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@kms_color@pipe-b-ctm-max:
- shard-skl: [DMESG-WARN][72] ([i915#1982]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl2/igt@kms_color@pipe-b-ctm-max.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl5/igt@kms_color@pipe-b-ctm-max.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
- shard-skl: [FAIL][74] ([i915#54]) -> [PASS][75] +6 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][76] ([i915#79]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [FAIL][78] ([i915#2598]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][80] ([i915#180]) -> [PASS][81] +3 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][82] ([i915#1188]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl1/igt@kms_hdr@bpc-switch-suspend.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl3/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][84] ([fdo#109441]) -> [PASS][85] +3 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* {igt@sysfs_clients@busy@vcs0}:
- shard-kbl: [FAIL][86] -> [PASS][87] +2 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl3/igt@sysfs_clients@busy@vcs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl2/igt@sysfs_clients@busy@vcs0.html
* {igt@sysfs_clients@busy@vecs0}:
- shard-apl: [FAIL][88] -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-apl4/igt@sysfs_clients@busy@vecs0.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-apl4/igt@sysfs_clients@busy@vecs0.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][90] ([i915#2681] / [i915#2684]) -> [WARN][91] ([i915#1804] / [i915#2684])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][92] ([i915#1226]) -> [SKIP][93] ([fdo#109349])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][94] ([i915#658]) -> [SKIP][95] ([i915#2920])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-iclb: [SKIP][96] ([i915#2920]) -> [SKIP][97] ([i915#658])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-iclb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101], [FAIL][102]) ([i915#2295]) -> ([FAIL][103], [FAIL][104], [FAIL][105]) ([i915#2295] / [i915#2505])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl3/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl4/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl4/igt@runner@aborted.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl4/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-kbl7/igt@runner@aborted.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl3/igt@runner@aborted.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl6/igt@runner@aborted.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-kbl1/igt@runner@aborted.html
- shard-tglb: ([FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109]) ([i915#1602] / [i915#2295] / [i915#2667]) -> ([FAIL][110], [FAIL][111], [FAIL][112]) ([i915#1602] / [i915#2295])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb1/igt@runner@aborted.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb2/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb7/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-tglb1/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-tglb2/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-tglb7/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-tglb6/igt@runner@aborted.html
- shard-skl: ([FAIL][113], [FAIL][114], [FAIL][115]) ([i915#2295]) -> ([FAIL][116], [FAIL][117]) ([i915#2295] / [i915#2426])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl6/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl1/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9687/shard-skl10/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl3/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/shard-skl5/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1394]: https://gitlab.freedesktop.org/drm/intel/issues/1394
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2896]: https://gitlab.freedesktop.org/drm/intel/issues/2896
[i915#2912]: https://gitlab.freedesktop.org/drm/intel/issues/2912
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9687 -> Patchwork_19514
CI-20190529: 20190529
CI_DRM_9687: 7b5229b02338bfb24c3db4e76abb328d1e9cf8f1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5974: a85398dcae50930c0e27548cf8c9575ad0bf69d1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19514: 73b045d7cdace6e291536c0edf4607e45fa66c1a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19514/index.html
[-- Attachment #1.2: Type: text/html, Size: 32508 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
2021-01-27 8:24 ` [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16 Anshuman Gupta
@ 2021-03-24 4:45 ` Nautiyal, Ankit K
2021-03-24 5:05 ` Gupta, Anshuman
0 siblings, 1 reply; 11+ messages in thread
From: Nautiyal, Ankit K @ 2021-03-24 4:45 UTC (permalink / raw)
To: Anshuman Gupta, intel-gfx
Change is as per the errata. LGTM.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
On 1/27/2021 1:54 PM, Anshuman Gupta wrote:
> Fix LC_Send_L_Prime message timeout to 16 as documented
> in DP HDCP 2.2 errata page 3.
>
> https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> include/drm/drm_hdcp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> index 2b165a0f434f..0b1111e3228e 100644
> --- a/include/drm/drm_hdcp.h
> +++ b/include/drm/drm_hdcp.h
> @@ -231,7 +231,7 @@ struct hdcp2_rep_stream_ready {
> #define HDCP_2_2_PAIRING_TIMEOUT_MS 200
> #define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
> #define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
> -#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
> +#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 16
> #define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
> #define HDCP_2_2_STREAM_READY_TIMEOUT_MS 100
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
2021-03-24 4:45 ` Nautiyal, Ankit K
@ 2021-03-24 5:05 ` Gupta, Anshuman
0 siblings, 0 replies; 11+ messages in thread
From: Gupta, Anshuman @ 2021-03-24 5:05 UTC (permalink / raw)
To: Nautiyal, Ankit K, intel-gfx, dri-devel, Lankhorst, Maarten
Cc: Nikula, Jani, Sean Paul
> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>
> Sent: Wednesday, March 24, 2021 10:16 AM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata
> LC_Send_L_Prime=16
>
> Change is as per the errata. LGTM.
>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Hi Maarten ,
Could you please provide your Ack to merge it via drm-intel-next, since it is a small change.
Thanks,
Anshuman Gupta.
>
> On 1/27/2021 1:54 PM, Anshuman Gupta wrote:
> > Fix LC_Send_L_Prime message timeout to 16 as documented in DP HDCP 2.2
> > errata page 3.
> >
> > https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_
> > Errata_v3_0.pdf
> >
> > Cc: Ramalingam C <ramalingam.c@intel.com>
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> > include/drm/drm_hdcp.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h index
> > 2b165a0f434f..0b1111e3228e 100644
> > --- a/include/drm/drm_hdcp.h
> > +++ b/include/drm/drm_hdcp.h
> > @@ -231,7 +231,7 @@ struct hdcp2_rep_stream_ready {
> > #define HDCP_2_2_PAIRING_TIMEOUT_MS 200
> > #define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
> > #define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
> > -#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
> > +#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 16
> > #define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
> > #define HDCP_2_2_STREAM_READY_TIMEOUT_MS 100
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16
@ 2021-03-24 5:05 ` Gupta, Anshuman
0 siblings, 0 replies; 11+ messages in thread
From: Gupta, Anshuman @ 2021-03-24 5:05 UTC (permalink / raw)
To: Nautiyal, Ankit K, intel-gfx, dri-devel, Lankhorst, Maarten; +Cc: Nikula, Jani
> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>
> Sent: Wednesday, March 24, 2021 10:16 AM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata
> LC_Send_L_Prime=16
>
> Change is as per the errata. LGTM.
>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Hi Maarten ,
Could you please provide your Ack to merge it via drm-intel-next, since it is a small change.
Thanks,
Anshuman Gupta.
>
> On 1/27/2021 1:54 PM, Anshuman Gupta wrote:
> > Fix LC_Send_L_Prime message timeout to 16 as documented in DP HDCP 2.2
> > errata page 3.
> >
> > https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_
> > Errata_v3_0.pdf
> >
> > Cc: Ramalingam C <ramalingam.c@intel.com>
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> > include/drm/drm_hdcp.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h index
> > 2b165a0f434f..0b1111e3228e 100644
> > --- a/include/drm/drm_hdcp.h
> > +++ b/include/drm/drm_hdcp.h
> > @@ -231,7 +231,7 @@ struct hdcp2_rep_stream_ready {
> > #define HDCP_2_2_PAIRING_TIMEOUT_MS 200
> > #define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
> > #define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
> > -#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
> > +#define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 16
> > #define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
> > #define HDCP_2_2_STREAM_READY_TIMEOUT_MS 100
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
2021-01-27 8:24 ` [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg Anshuman Gupta
@ 2021-03-24 9:35 ` Nautiyal, Ankit K
2021-03-24 10:07 ` Gupta, Anshuman
0 siblings, 1 reply; 11+ messages in thread
From: Nautiyal, Ankit K @ 2021-03-24 9:35 UTC (permalink / raw)
To: Anshuman Gupta, intel-gfx
Hi Anshuman,
Changes look good to me as per the Errata.
There are minor comments, inline:
On 1/27/2021 1:54 PM, Anshuman Gupta wrote:
> As documented in HDCP 2.2 DP Errata spec transmitter should abort the
> authentication protocol in case transmitter has not received the
> entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg
> within {110,7,5} miliseconds.
>
> Adding above msg timeout values and aborting the HDCP authentication
> in case it timedout to read entire msg.
>
> https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_Errata_v3_0.pdf
>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 56 +++++++++++++-------
> include/drm/drm_hdcp.h | 3 ++
> 2 files changed, 40 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> index f372e25edab4..f7cc5cbcabc6 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> @@ -292,39 +292,42 @@ struct hdcp2_dp_msg_data {
> u8 msg_id;
> u32 offset;
> bool msg_detectable;
> + bool msg_can_timedout;
Perhaps we can just check if msg_read_timedout is not 0 , instead of
adding bool msg_can_timedout.
> u32 timeout;
> u32 timeout2; /* Added for non_paired situation */
> + /* Timeout to read entire msg */
> + u32 msg_read_timeout;
> };
>
> static const struct hdcp2_dp_msg_data hdcp2_dp_msg_data[] = {
> - { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0 },
> + { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, false, 0, 0, 0},
> { HDCP_2_2_AKE_SEND_CERT, DP_HDCP_2_2_AKE_SEND_CERT_OFFSET,
> - false, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
> + false, true, HDCP_2_2_CERT_TIMEOUT_MS, 0, HDCP_2_2_DP_CERT_READ_TIMEOUT_MS},
> { HDCP_2_2_AKE_NO_STORED_KM, DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET,
> - false, 0, 0 },
> + false, false, 0, 0, 0 },
> { HDCP_2_2_AKE_STORED_KM, DP_HDCP_2_2_AKE_STORED_KM_OFFSET,
> - false, 0, 0 },
> + false, false, 0, 0, 0 },
> { HDCP_2_2_AKE_SEND_HPRIME, DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET,
> - true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
> - HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
> + true, true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
> + HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS, HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS},
> { HDCP_2_2_AKE_SEND_PAIRING_INFO,
> - DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true,
> - HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
> - { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0 },
> + DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true, true,
> + HDCP_2_2_PAIRING_TIMEOUT_MS, 0, HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS },
> + { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, false, 0, 0, 0 },
> { HDCP_2_2_LC_SEND_LPRIME, DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET,
> - false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0 },
> - { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false,
> - 0, 0 },
> + false, false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0, 0 },
> + { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET, false, false,
> + 0, 0, 0 },
> { HDCP_2_2_REP_SEND_RECVID_LIST,
> - DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true,
> - HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
> - { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false,
> - 0, 0 },
> + DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true, false,
> + HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0, 0 },
> + { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET, false, false,
> + 0, 0, 0 },
> { HDCP_2_2_REP_STREAM_MANAGE,
> - DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false,
> - 0, 0 },
> + DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false, false,
> + 0, 0, 0},
> { HDCP_2_2_REP_STREAM_READY, DP_HDCP_2_2_REP_STREAM_READY_OFFSET,
> - false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
> + false, false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0, 0 },
> /* local define to shovel this through the write_2_2 interface */
> #define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
> { HDCP_2_2_ERRATA_DP_STREAM_TYPE,
> @@ -513,6 +516,8 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
> u8 *byte = buf;
> ssize_t ret, bytes_to_recv, len;
> const struct hdcp2_dp_msg_data *hdcp2_msg_data;
> + ktime_t msg_end;
> + bool msg_expired;
>
> hdcp2_msg_data = get_hdcp2_dp_msg_data(msg_id);
> if (!hdcp2_msg_data)
> @@ -539,6 +544,11 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
> len = bytes_to_recv > DP_AUX_MAX_PAYLOAD_BYTES ?
> DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv;
>
> + /* Entire msg read timeout since initiate of msg read */
> + if (bytes_to_recv == size - 1)
IMHO, we can add the check if msg_read_timeout > 0, so as to skip for
messages that do not have timeout requirement.
> + msg_end = ktime_add_ms(ktime_get_raw(),
> + hdcp2_msg_data->msg_read_timeout);
> +
> ret = drm_dp_dpcd_read(&dig_port->dp.aux, offset,
> (void *)byte, len);
> if (ret < 0) {
> @@ -551,6 +561,14 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port *dig_port,
> byte += ret;
> offset += ret;
> }
> +
> + msg_expired = ktime_after(ktime_get_raw(), msg_end);
> + if (msg_expired && hdcp2_msg_data->msg_can_timedout) {
As mentioned before, we can use msg_read_timeout here.
Regards,
Ankit
> + drm_dbg_kms(&i915->drm, "msg_id %d, entire msg read timeout(mSec): %d\n",
> + msg_id, hdcp2_msg_data->msg_read_timeout);
> + return -ETIMEDOUT;
> + }
> +
> byte = buf;
> *byte = msg_id;
>
> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> index ac22c246542a..2b165a0f434f 100644
> --- a/include/drm/drm_hdcp.h
> +++ b/include/drm/drm_hdcp.h
> @@ -224,9 +224,12 @@ struct hdcp2_rep_stream_ready {
>
> /* HDCP2.2 TIMEOUTs in mSec */
> #define HDCP_2_2_CERT_TIMEOUT_MS 100
> +#define HDCP_2_2_DP_CERT_READ_TIMEOUT_MS 110
> #define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
> #define HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS 200
> +#define HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS 7
> #define HDCP_2_2_PAIRING_TIMEOUT_MS 200
> +#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
> #define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
> #define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
> #define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
2021-03-24 9:35 ` Nautiyal, Ankit K
@ 2021-03-24 10:07 ` Gupta, Anshuman
0 siblings, 0 replies; 11+ messages in thread
From: Gupta, Anshuman @ 2021-03-24 10:07 UTC (permalink / raw)
To: Nautiyal, Ankit K, intel-gfx
> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nautiyal@intel.com>
> Sent: Wednesday, March 24, 2021 3:06 PM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to
> read entire msg
>
> Hi Anshuman,
>
> Changes look good to me as per the Errata.
>
> There are minor comments, inline:
Thanks for review, I will address your comment but just need to clarified one thing as below
>
> On 1/27/2021 1:54 PM, Anshuman Gupta wrote:
> > As documented in HDCP 2.2 DP Errata spec transmitter should abort the
> > authentication protocol in case transmitter has not received the
> > entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg
> > within {110,7,5} miliseconds.
> >
> > Adding above msg timeout values and aborting the HDCP authentication
> > in case it timedout to read entire msg.
> >
> > https://www.digital-cp.com/sites/default/files/HDCP%202_2_DisplayPort_
> > Errata_v3_0.pdf
> >
> > Cc: Ramalingam C <ramalingam.c@intel.com>
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 56 +++++++++++++-------
> > include/drm/drm_hdcp.h | 3 ++
> > 2 files changed, 40 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > index f372e25edab4..f7cc5cbcabc6 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_hdcp.c
> > @@ -292,39 +292,42 @@ struct hdcp2_dp_msg_data {
> > u8 msg_id;
> > u32 offset;
> > bool msg_detectable;
> > + bool msg_can_timedout;
>
> Perhaps we can just check if msg_read_timedout is not 0 , instead of adding
> bool msg_can_timedout.
>
>
> > u32 timeout;
> > u32 timeout2; /* Added for non_paired situation */
> > + /* Timeout to read entire msg */
> > + u32 msg_read_timeout;
> > };
> >
> > static const struct hdcp2_dp_msg_data hdcp2_dp_msg_data[] = {
> > - { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, 0, 0 },
> > + { HDCP_2_2_AKE_INIT, DP_HDCP_2_2_AKE_INIT_OFFSET, false, false,
> 0, 0, 0},
> > { HDCP_2_2_AKE_SEND_CERT,
> DP_HDCP_2_2_AKE_SEND_CERT_OFFSET,
> > - false, HDCP_2_2_CERT_TIMEOUT_MS, 0 },
> > + false, true, HDCP_2_2_CERT_TIMEOUT_MS, 0,
> HDCP_2_2_DP_CERT_READ_TIMEOUT_MS},
> > { HDCP_2_2_AKE_NO_STORED_KM,
> DP_HDCP_2_2_AKE_NO_STORED_KM_OFFSET,
> > - false, 0, 0 },
> > + false, false, 0, 0, 0 },
> > { HDCP_2_2_AKE_STORED_KM,
> DP_HDCP_2_2_AKE_STORED_KM_OFFSET,
> > - false, 0, 0 },
> > + false, false, 0, 0, 0 },
> > { HDCP_2_2_AKE_SEND_HPRIME,
> DP_HDCP_2_2_AKE_SEND_HPRIME_OFFSET,
> > - true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
> > - HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS },
> > + true, true, HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS,
> > + HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS,
> HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS},
> > { HDCP_2_2_AKE_SEND_PAIRING_INFO,
> > - DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true,
> > - HDCP_2_2_PAIRING_TIMEOUT_MS, 0 },
> > - { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, 0, 0 },
> > + DP_HDCP_2_2_AKE_SEND_PAIRING_INFO_OFFSET, true, true,
> > + HDCP_2_2_PAIRING_TIMEOUT_MS, 0,
> HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS },
> > + { HDCP_2_2_LC_INIT, DP_HDCP_2_2_LC_INIT_OFFSET, false, false, 0, 0,
> 0 },
> > { HDCP_2_2_LC_SEND_LPRIME,
> DP_HDCP_2_2_LC_SEND_LPRIME_OFFSET,
> > - false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0 },
> > - { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET,
> false,
> > - 0, 0 },
> > + false, false, HDCP_2_2_DP_LPRIME_TIMEOUT_MS, 0, 0 },
> > + { HDCP_2_2_SKE_SEND_EKS, DP_HDCP_2_2_SKE_SEND_EKS_OFFSET,
> false, false,
> > + 0, 0, 0 },
> > { HDCP_2_2_REP_SEND_RECVID_LIST,
> > - DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true,
> > - HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0 },
> > - { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET,
> false,
> > - 0, 0 },
> > + DP_HDCP_2_2_REP_SEND_RECVID_LIST_OFFSET, true, false,
> > + HDCP_2_2_RECVID_LIST_TIMEOUT_MS, 0, 0 },
> > + { HDCP_2_2_REP_SEND_ACK, DP_HDCP_2_2_REP_SEND_ACK_OFFSET,
> false, false,
> > + 0, 0, 0 },
> > { HDCP_2_2_REP_STREAM_MANAGE,
> > - DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false,
> > - 0, 0 },
> > + DP_HDCP_2_2_REP_STREAM_MANAGE_OFFSET, false, false,
> > + 0, 0, 0},
> > { HDCP_2_2_REP_STREAM_READY,
> DP_HDCP_2_2_REP_STREAM_READY_OFFSET,
> > - false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0 },
> > + false, false, HDCP_2_2_STREAM_READY_TIMEOUT_MS, 0, 0 },
> > /* local define to shovel this through the write_2_2 interface */
> > #define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
> > { HDCP_2_2_ERRATA_DP_STREAM_TYPE,
> > @@ -513,6 +516,8 @@ int intel_dp_hdcp2_read_msg(struct intel_digital_port
> *dig_port,
> > u8 *byte = buf;
> > ssize_t ret, bytes_to_recv, len;
> > const struct hdcp2_dp_msg_data *hdcp2_msg_data;
> > + ktime_t msg_end;
> > + bool msg_expired;
> >
> > hdcp2_msg_data = get_hdcp2_dp_msg_data(msg_id);
> > if (!hdcp2_msg_data)
> > @@ -539,6 +544,11 @@ int intel_dp_hdcp2_read_msg(struct
> intel_digital_port *dig_port,
> > len = bytes_to_recv > DP_AUX_MAX_PAYLOAD_BYTES ?
> > DP_AUX_MAX_PAYLOAD_BYTES : bytes_to_recv;
> >
> > + /* Entire msg read timeout since initiate of msg read */
> > + if (bytes_to_recv == size - 1)
>
>
> IMHO, we can add the check if msg_read_timeout > 0, so as to skip for
> messages that do not have timeout requirement.
Above condition is to tick the timeout only when msg is initiated.
Sometimes we can only send DP_AUX_MAX_PAYLOAD_BYTES at a time.
So we can't add msg_read_timeout > 0 here, that will be true in case of
We are sending more then DP_AUX_MAX_PAYLOAD_BYTES Over link.
Br,
Anshuman.
>
>
> > + msg_end = ktime_add_ms(ktime_get_raw(),
> > + hdcp2_msg_data-
> >msg_read_timeout);
> > +
> > ret = drm_dp_dpcd_read(&dig_port->dp.aux, offset,
> > (void *)byte, len);
> > if (ret < 0) {
> > @@ -551,6 +561,14 @@ int intel_dp_hdcp2_read_msg(struct
> intel_digital_port *dig_port,
> > byte += ret;
> > offset += ret;
> > }
> > +
> > + msg_expired = ktime_after(ktime_get_raw(), msg_end);
> > + if (msg_expired && hdcp2_msg_data->msg_can_timedout) {
>
> As mentioned before, we can use msg_read_timeout here.
>
>
> Regards,
>
> Ankit
>
> > + drm_dbg_kms(&i915->drm, "msg_id %d, entire msg read
> timeout(mSec): %d\n",
> > + msg_id, hdcp2_msg_data->msg_read_timeout);
> > + return -ETIMEDOUT;
> > + }
> > +
> > byte = buf;
> > *byte = msg_id;
> >
> > diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> > index ac22c246542a..2b165a0f434f 100644
> > --- a/include/drm/drm_hdcp.h
> > +++ b/include/drm/drm_hdcp.h
> > @@ -224,9 +224,12 @@ struct hdcp2_rep_stream_ready {
> >
> > /* HDCP2.2 TIMEOUTs in mSec */
> > #define HDCP_2_2_CERT_TIMEOUT_MS 100
> > +#define HDCP_2_2_DP_CERT_READ_TIMEOUT_MS 110
> > #define HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS 1000
> > #define HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS 200
> > +#define HDCP_2_2_DP_HPRIME_READ_TIMEOUT_MS 7
> > #define HDCP_2_2_PAIRING_TIMEOUT_MS 200
> > +#define HDCP_2_2_DP_PAIRING_READ_TIMEOUT_MS 5
> > #define HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS 20
> > #define HDCP_2_2_DP_LPRIME_TIMEOUT_MS 7
> > #define HDCP_2_2_RECVID_LIST_TIMEOUT_MS 3000
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-03-24 10:07 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 8:24 [Intel-gfx] [PATCH 0/2] HDCP 2.2 DP errata Anshuman Gupta
2021-01-27 8:24 ` [Intel-gfx] [PATCH 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg Anshuman Gupta
2021-03-24 9:35 ` Nautiyal, Ankit K
2021-03-24 10:07 ` Gupta, Anshuman
2021-01-27 8:24 ` [Intel-gfx] [PATCH 2/2] drm/hdcp: DP HDCP2.2 errata LC_Send_L_Prime=16 Anshuman Gupta
2021-03-24 4:45 ` Nautiyal, Ankit K
2021-03-24 5:05 ` Gupta, Anshuman
2021-03-24 5:05 ` Gupta, Anshuman
2021-01-27 12:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP 2.2 DP errata Patchwork
2021-01-27 12:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-27 14:50 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.