From: Christoph Hellwig <hch@lst.de>
To: Jessica Yu <jeyu@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Andrew Donnellan <ajd@linux.ibm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
dri-devel@lists.freedesktop.org, live-patching@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 13/13] module: remove EXPORY_UNUSED_SYMBOL*
Date: Thu, 28 Jan 2021 17:09:57 +0100 [thread overview]
Message-ID: <20210128160957.GA2504@lst.de> (raw)
In-Reply-To: <YBFvcmUiHRjkucbf@gunter>
On Wed, Jan 27, 2021 at 02:49:38PM +0100, Jessica Yu wrote:
>> #ifdef CONFIG_MODULE_SIG
>> /* Signature was verified. */
>> bool sig_ok;
>> @@ -592,7 +580,6 @@ struct symsearch {
>> GPL_ONLY,
>> WILL_BE_GPL_ONLY,
>> } license;
>> - bool unused;
>> };
> Thanks for the cleanups. While we're here, I noticed that struct
> symsearch is only used internally in kernel/module.c, so I don't think
> it actually needs to be in include/linux/module.h. I don't see it used
> anywhere else. We could move maybe that to kernel/module-internal.h.
I've added a patch to just move it directly into module.c.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jessica Yu <jeyu@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Andrew Donnellan <ajd@linux.ibm.com>,
linux-kbuild@vger.kernel.org, David Airlie <airlied@linux.ie>,
Masahiro Yamada <masahiroy@kernel.org>,
Jiri Kosina <jikos@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
live-patching@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Daniel Vetter <daniel@ffwll.ch>, Miroslav Benes <mbenes@suse.cz>,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 13/13] module: remove EXPORY_UNUSED_SYMBOL*
Date: Thu, 28 Jan 2021 17:09:57 +0100 [thread overview]
Message-ID: <20210128160957.GA2504@lst.de> (raw)
In-Reply-To: <YBFvcmUiHRjkucbf@gunter>
On Wed, Jan 27, 2021 at 02:49:38PM +0100, Jessica Yu wrote:
>> #ifdef CONFIG_MODULE_SIG
>> /* Signature was verified. */
>> bool sig_ok;
>> @@ -592,7 +580,6 @@ struct symsearch {
>> GPL_ONLY,
>> WILL_BE_GPL_ONLY,
>> } license;
>> - bool unused;
>> };
> Thanks for the cleanups. While we're here, I noticed that struct
> symsearch is only used internally in kernel/module.c, so I don't think
> it actually needs to be in include/linux/module.h. I don't see it used
> anywhere else. We could move maybe that to kernel/module-internal.h.
I've added a patch to just move it directly into module.c.
next prev parent reply other threads:[~2021-01-28 16:10 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 7:49 module loader dead code removal and cleanusp Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 7:49 ` [PATCH 01/13] powerpc/powernv: remove get_cxl_module Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 9:09 ` Andrew Donnellan
2021-01-21 9:09 ` Andrew Donnellan
2021-01-21 9:09 ` Andrew Donnellan
2021-01-21 7:49 ` [PATCH 02/13] module: add a module_loaded helper Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 9:59 ` Christophe Leroy
2021-01-21 10:13 ` David Laight
2021-01-21 10:17 ` Christophe Leroy
2021-01-21 10:00 ` Christophe Leroy
2021-01-21 10:00 ` Christophe Leroy
2021-01-21 17:11 ` Christoph Hellwig
2021-01-21 17:11 ` Christoph Hellwig
2021-01-21 17:44 ` David Laight
2021-01-21 17:44 ` David Laight
2021-01-21 17:44 ` David Laight
2021-01-21 7:49 ` [PATCH 03/13] livepatch: refactor klp_init_object Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-27 12:58 ` Petr Mladek
2021-01-27 12:58 ` Petr Mladek
2021-01-27 12:58 ` Petr Mladek
2021-01-28 16:22 ` Christoph Hellwig
2021-01-28 16:22 ` Christoph Hellwig
2021-01-28 16:24 ` Christoph Hellwig
2021-01-28 16:24 ` Christoph Hellwig
2021-01-21 7:49 ` [PATCH 04/13] livepatch: move klp_find_object_module to module.c Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 21:45 ` Josh Poimboeuf
2021-01-21 21:45 ` Josh Poimboeuf
2021-01-21 21:45 ` Josh Poimboeuf
2021-01-26 14:25 ` Jessica Yu
2021-01-26 14:25 ` Jessica Yu
2021-01-26 14:25 ` Jessica Yu
2021-01-27 11:55 ` Petr Mladek
2021-01-27 11:55 ` Petr Mladek
2021-01-27 11:55 ` Petr Mladek
2021-01-21 7:49 ` [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 7:49 ` [PATCH 06/13] kallsyms: only build {,module_}kallsyms_on_each_symbol when required Christoph Hellwig
2021-01-21 7:49 ` [PATCH 06/13] kallsyms: only build {, module_}kallsyms_on_each_symbol " Christoph Hellwig
2021-01-21 7:49 ` [PATCH 07/13] module: mark module_mutex static Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 7:49 ` [PATCH 08/13] drm: remove drm_fb_helper_modinit Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 8:25 ` Daniel Vetter
2021-01-21 8:25 ` Daniel Vetter
2021-01-21 8:25 ` Daniel Vetter
2021-01-21 8:28 ` Christoph Hellwig
2021-01-21 8:28 ` Christoph Hellwig
2021-01-21 8:39 ` Daniel Vetter
2021-01-21 8:39 ` Daniel Vetter
2021-01-21 8:39 ` Daniel Vetter
2021-01-21 7:49 ` [PATCH 09/13] module: remove each_symbol_in_section Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 7:49 ` [PATCH 10/13] module: merge each_symbol_section into find_symbol Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 7:49 ` [PATCH 11/13] module: pass struct find_symbol_args to find_symbol Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 7:49 ` [PATCH 12/13] module: remove EXPORT_SYMBOL_GPL_FUTURE Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-21 7:49 ` [PATCH 13/13] module: remove EXPORY_UNUSED_SYMBOL* Christoph Hellwig
2021-01-21 7:49 ` Christoph Hellwig
2021-01-27 13:49 ` Jessica Yu
2021-01-27 13:49 ` Jessica Yu
2021-01-27 13:49 ` Jessica Yu
2021-01-28 16:09 ` Christoph Hellwig [this message]
2021-01-28 16:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128160957.GA2504@lst.de \
--to=hch@lst.de \
--cc=airlied@linux.ie \
--cc=ajd@linux.ibm.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fbarrat@linux.ibm.com \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=michal.lkml@markovi.net \
--cc=mripard@kernel.org \
--cc=pmladek@suse.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.