From: Mike Snitzer <snitzer@redhat.com>
To: Sergei Shtepa <sergei.shtepa@veeam.com>
Cc: Damien.LeMoal@wdc.com, hare@suse.de, ming.lei@redhat.com,
agk@redhat.com, corbet@lwn.net, axboe@kernel.dk, jack@suse.cz,
johannes.thumshirn@wdc.com, gregkh@linuxfoundation.org,
koct9i@gmail.com, steve@sk2.org, dm-devel@redhat.com,
linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, pavel.tide@veeam.com
Subject: Re: [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD
Date: Fri, 12 Feb 2021 11:13:05 -0500 [thread overview]
Message-ID: <20210212161305.GB19424@redhat.com> (raw)
In-Reply-To: <1612881028-7878-5-git-send-email-sergei.shtepa@veeam.com>
On Tue, Feb 09 2021 at 9:30am -0500,
Sergei Shtepa <sergei.shtepa@veeam.com> wrote:
> New ioctl DM_DEV_REMAP_CMD allow to remap bio requests
> from regular block device to dm device.
I really dislike the (ab)use of "REMAP" for this. DM is and always has
been about remapping IO. Would prefer DM_DEV_INTERPOSE_CMD
Similarly, all places documenting "remap" or variables with "remap"
changed to "interpose".
Also, any chance you'd be open to putting all these interposer specific
changes in dm-interposer.[ch] ?
(the various internal structs for DM core _should_ be available via dm-core.h)
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Sergei Shtepa <sergei.shtepa@veeam.com>
Cc: axboe@kernel.dk, Damien.LeMoal@wdc.com, pavel.tide@veeam.com,
jack@suse.cz, corbet@lwn.net, johannes.thumshirn@wdc.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
ming.lei@redhat.com, linux-block@vger.kernel.org,
dm-devel@redhat.com, gregkh@linuxfoundation.org, steve@sk2.org,
koct9i@gmail.com, agk@redhat.com
Subject: Re: [dm-devel] [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD
Date: Fri, 12 Feb 2021 11:13:05 -0500 [thread overview]
Message-ID: <20210212161305.GB19424@redhat.com> (raw)
In-Reply-To: <1612881028-7878-5-git-send-email-sergei.shtepa@veeam.com>
On Tue, Feb 09 2021 at 9:30am -0500,
Sergei Shtepa <sergei.shtepa@veeam.com> wrote:
> New ioctl DM_DEV_REMAP_CMD allow to remap bio requests
> from regular block device to dm device.
I really dislike the (ab)use of "REMAP" for this. DM is and always has
been about remapping IO. Would prefer DM_DEV_INTERPOSE_CMD
Similarly, all places documenting "remap" or variables with "remap"
changed to "interpose".
Also, any chance you'd be open to putting all these interposer specific
changes in dm-interposer.[ch] ?
(the various internal structs for DM core _should_ be available via dm-core.h)
Mike
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-02-12 16:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 14:30 [PATCH v5 0/6] block-layer interposer Sergei Shtepa
2021-02-09 14:30 ` [dm-devel] " Sergei Shtepa
2021-02-09 14:30 ` [PATCH v5 1/6] docs: device-mapper: add remap_and_filter Sergei Shtepa
2021-02-09 14:30 ` [dm-devel] " Sergei Shtepa
2021-02-09 14:30 ` [PATCH v5 2/6] block: add blk_mq_is_queue_frozen() Sergei Shtepa
2021-02-09 14:30 ` [dm-devel] " Sergei Shtepa
2021-02-09 14:30 ` [PATCH v5 3/6] block: add blk_interposer Sergei Shtepa
2021-02-09 14:30 ` [dm-devel] " Sergei Shtepa
2021-02-09 14:30 ` [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD Sergei Shtepa
2021-02-09 14:30 ` [dm-devel] " Sergei Shtepa
2021-02-10 6:54 ` kernel test robot
2021-02-12 16:13 ` Mike Snitzer [this message]
2021-02-12 16:13 ` [dm-devel] " Mike Snitzer
2021-02-09 14:30 ` [PATCH v5 5/6] dm: add 'noexcl' option for dm-linear Sergei Shtepa
2021-02-09 14:30 ` [dm-devel] " Sergei Shtepa
2021-02-11 17:51 ` Mike Snitzer
2021-02-11 17:51 ` [dm-devel] " Mike Snitzer
2021-02-12 11:34 ` Sergei Shtepa
2021-02-12 11:34 ` [dm-devel] " Sergei Shtepa
2021-02-12 16:06 ` Mike Snitzer
2021-02-12 16:06 ` [dm-devel] " Mike Snitzer
2021-02-15 10:34 ` Sergei Shtepa
2021-02-15 10:34 ` [dm-devel] " Sergei Shtepa
2021-02-15 16:08 ` Mike Snitzer
2021-02-15 16:08 ` [dm-devel] " Mike Snitzer
2021-02-24 10:46 ` Sergei Shtepa
2021-02-24 10:46 ` [dm-devel] " Sergei Shtepa
2021-02-09 14:30 ` [PATCH v5 6/6] docs: device-mapper: " Sergei Shtepa
2021-02-09 14:30 ` [dm-devel] " Sergei Shtepa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212161305.GB19424@redhat.com \
--to=snitzer@redhat.com \
--cc=Damien.LeMoal@wdc.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=dm-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=koct9i@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=pavel.tide@veeam.com \
--cc=sergei.shtepa@veeam.com \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.