* [PATCH] phy: ti: j721e-wiz: add missing of_node_put
@ 2021-02-16 8:27 angkery
2021-03-15 10:05 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: angkery @ 2021-02-16 8:27 UTC (permalink / raw)
To: kishon, vkoul, rikard.falkeborn, rogerq, yuehaibing, weiyongjun1, jsarha
Cc: linux-kernel, Junlin Yang
From: Junlin Yang <yangjunlin@yulong.com>
Fix OF node leaks by calling of_node_put in
for_each_child_of_node when the cycle returns.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
---
drivers/phy/ti/phy-j721e-wiz.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index c9cfafe..8a4be1e 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -792,6 +792,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
dev_err(dev,
"%s: Reading \"reg\" from \"%s\" failed: %d\n",
__func__, subnode->name, ret);
+ of_node_put(subnode);
return ret;
}
of_property_read_u32(subnode, "cdns,num-lanes", &num_lanes);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: ti: j721e-wiz: add missing of_node_put
2021-02-16 8:27 [PATCH] phy: ti: j721e-wiz: add missing of_node_put angkery
@ 2021-03-15 10:05 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-03-15 10:05 UTC (permalink / raw)
To: angkery
Cc: kishon, rikard.falkeborn, rogerq, yuehaibing, weiyongjun1,
jsarha, linux-kernel, Junlin Yang
On 16-02-21, 16:27, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
>
> Fix OF node leaks by calling of_node_put in
> for_each_child_of_node when the cycle returns.
>
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-15 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 8:27 [PATCH] phy: ti: j721e-wiz: add missing of_node_put angkery
2021-03-15 10:05 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.