All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] phy: rockchip-typec: add missing of_node_put
@ 2021-02-16  8:48 ` angkery
  0 siblings, 0 replies; 6+ messages in thread
From: angkery @ 2021-02-16  8:48 UTC (permalink / raw)
  To: kishon, vkoul, heiko
  Cc: linux-kernel, linux-arm-kernel, linux-rockchip, Junlin Yang

From: Junlin Yang <yangjunlin@yulong.com>

Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle returns.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
---
 drivers/phy/rockchip/phy-rockchip-typec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c
index 70a3125..d2bbdc9 100644
--- a/drivers/phy/rockchip/phy-rockchip-typec.c
+++ b/drivers/phy/rockchip/phy-rockchip-typec.c
@@ -1180,6 +1180,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
 			dev_err(dev, "failed to create phy: %pOFn\n",
 				child_np);
 			pm_runtime_disable(dev);
+			of_node_put(child_np);
 			return PTR_ERR(phy);
 		}
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] phy: rockchip-typec: add missing of_node_put
@ 2021-02-16  8:48 ` angkery
  0 siblings, 0 replies; 6+ messages in thread
From: angkery @ 2021-02-16  8:48 UTC (permalink / raw)
  To: kishon, vkoul, heiko
  Cc: linux-rockchip, linux-kernel, linux-arm-kernel, Junlin Yang

From: Junlin Yang <yangjunlin@yulong.com>

Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle returns.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
---
 drivers/phy/rockchip/phy-rockchip-typec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c
index 70a3125..d2bbdc9 100644
--- a/drivers/phy/rockchip/phy-rockchip-typec.c
+++ b/drivers/phy/rockchip/phy-rockchip-typec.c
@@ -1180,6 +1180,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
 			dev_err(dev, "failed to create phy: %pOFn\n",
 				child_np);
 			pm_runtime_disable(dev);
+			of_node_put(child_np);
 			return PTR_ERR(phy);
 		}
 
-- 
1.9.1



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] phy: rockchip-typec: add missing of_node_put
@ 2021-02-16  8:48 ` angkery
  0 siblings, 0 replies; 6+ messages in thread
From: angkery @ 2021-02-16  8:48 UTC (permalink / raw)
  To: kishon, vkoul, heiko
  Cc: linux-rockchip, linux-kernel, linux-arm-kernel, Junlin Yang

From: Junlin Yang <yangjunlin@yulong.com>

Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle returns.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
---
 drivers/phy/rockchip/phy-rockchip-typec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c
index 70a3125..d2bbdc9 100644
--- a/drivers/phy/rockchip/phy-rockchip-typec.c
+++ b/drivers/phy/rockchip/phy-rockchip-typec.c
@@ -1180,6 +1180,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
 			dev_err(dev, "failed to create phy: %pOFn\n",
 				child_np);
 			pm_runtime_disable(dev);
+			of_node_put(child_np);
 			return PTR_ERR(phy);
 		}
 
-- 
1.9.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: rockchip-typec: add missing of_node_put
  2021-02-16  8:48 ` angkery
  (?)
@ 2021-03-15 10:05   ` Vinod Koul
  -1 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2021-03-15 10:05 UTC (permalink / raw)
  To: angkery
  Cc: kishon, heiko, linux-kernel, linux-arm-kernel, linux-rockchip,
	Junlin Yang

On 16-02-21, 16:48, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
> 
> Fix OF node leaks by calling of_node_put in
> for_each_available_child_of_node when the cycle returns.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: rockchip-typec: add missing of_node_put
@ 2021-03-15 10:05   ` Vinod Koul
  0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2021-03-15 10:05 UTC (permalink / raw)
  To: angkery
  Cc: kishon, heiko, linux-kernel, linux-arm-kernel, linux-rockchip,
	Junlin Yang

On 16-02-21, 16:48, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
> 
> Fix OF node leaks by calling of_node_put in
> for_each_available_child_of_node when the cycle returns.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Applied, thanks

-- 
~Vinod

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: rockchip-typec: add missing of_node_put
@ 2021-03-15 10:05   ` Vinod Koul
  0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2021-03-15 10:05 UTC (permalink / raw)
  To: angkery
  Cc: kishon, heiko, linux-kernel, linux-arm-kernel, linux-rockchip,
	Junlin Yang

On 16-02-21, 16:48, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
> 
> Fix OF node leaks by calling of_node_put in
> for_each_available_child_of_node when the cycle returns.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-15 10:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16  8:48 [PATCH] phy: rockchip-typec: add missing of_node_put angkery
2021-02-16  8:48 ` angkery
2021-02-16  8:48 ` angkery
2021-03-15 10:05 ` Vinod Koul
2021-03-15 10:05   ` Vinod Koul
2021-03-15 10:05   ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.