* [PATCH 1/1] lib: rsa: struct udevice build warning
@ 2021-02-17 11:54 Heinrich Schuchardt
2021-02-19 4:52 ` Simon Glass
2021-02-25 13:29 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-02-17 11:54 UTC (permalink / raw)
To: u-boot
Avoid build warnings observed with gcc 10.2
In file included from lib/rsa/rsa-keyprop.c:16:
include/u-boot/rsa-mod-exp.h:65:24: warning:
?struct udevice? declared inside parameter list will not be visible
outside of this definition or declaration
65 | int rsa_mod_exp(struct udevice *dev, const uint8_t *sig,
| uint32_t sig_len,
| ^~~~~~~
include/u-boot/rsa-mod-exp.h:96:24: warning:
?struct udevice? declared inside parameter list will not be visible
outside of this definition or declaration
96 | int (*mod_exp)(struct udevice *dev, const uint8_t *sig,
|
by defining struct udevice.
Fixes: 401d1c4f5d2d ("common: Drop asm/global_data.h from common header")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
include/u-boot/rsa-mod-exp.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/u-boot/rsa-mod-exp.h b/include/u-boot/rsa-mod-exp.h
index 7b7c2915a9..fc9557c781 100644
--- a/include/u-boot/rsa-mod-exp.h
+++ b/include/u-boot/rsa-mod-exp.h
@@ -9,6 +9,8 @@
#include <errno.h>
#include <image.h>
+struct udevice;
+
/**
* struct key_prop - holder for a public key properties
*
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] lib: rsa: struct udevice build warning
2021-02-17 11:54 [PATCH 1/1] lib: rsa: struct udevice build warning Heinrich Schuchardt
@ 2021-02-19 4:52 ` Simon Glass
2021-02-25 13:29 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2021-02-19 4:52 UTC (permalink / raw)
To: u-boot
On Wed, 17 Feb 2021 at 04:54, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Avoid build warnings observed with gcc 10.2
>
> In file included from lib/rsa/rsa-keyprop.c:16:
> include/u-boot/rsa-mod-exp.h:65:24: warning:
> ?struct udevice? declared inside parameter list will not be visible
> outside of this definition or declaration
> 65 | int rsa_mod_exp(struct udevice *dev, const uint8_t *sig,
> | uint32_t sig_len,
> | ^~~~~~~
> include/u-boot/rsa-mod-exp.h:96:24: warning:
> ?struct udevice? declared inside parameter list will not be visible
> outside of this definition or declaration
> 96 | int (*mod_exp)(struct udevice *dev, const uint8_t *sig,
> |
>
> by defining struct udevice.
>
> Fixes: 401d1c4f5d2d ("common: Drop asm/global_data.h from common header")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> include/u-boot/rsa-mod-exp.h | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] lib: rsa: struct udevice build warning
2021-02-17 11:54 [PATCH 1/1] lib: rsa: struct udevice build warning Heinrich Schuchardt
2021-02-19 4:52 ` Simon Glass
@ 2021-02-25 13:29 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-02-25 13:29 UTC (permalink / raw)
To: u-boot
On Wed, Feb 17, 2021 at 12:54:31PM +0100, Heinrich Schuchardt wrote:
> Avoid build warnings observed with gcc 10.2
>
> In file included from lib/rsa/rsa-keyprop.c:16:
> include/u-boot/rsa-mod-exp.h:65:24: warning:
> ?struct udevice? declared inside parameter list will not be visible
> outside of this definition or declaration
> 65 | int rsa_mod_exp(struct udevice *dev, const uint8_t *sig,
> | uint32_t sig_len,
> | ^~~~~~~
> include/u-boot/rsa-mod-exp.h:96:24: warning:
> ?struct udevice? declared inside parameter list will not be visible
> outside of this definition or declaration
> 96 | int (*mod_exp)(struct udevice *dev, const uint8_t *sig,
> |
>
> by defining struct udevice.
>
> Fixes: 401d1c4f5d2d ("common: Drop asm/global_data.h from common header")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210225/32eab895/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-25 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-17 11:54 [PATCH 1/1] lib: rsa: struct udevice build warning Heinrich Schuchardt
2021-02-19 4:52 ` Simon Glass
2021-02-25 13:29 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.