[PATCH] drm/amd/display: Allow spatial dither to 10 bpc on all DCE

[PATCH] drm/amd/display: Allow spatial dither to 10 bpc on all DCE

[Alex Deucher]

From: Mario Kleiner <mario.kleiner.de@gmail.com>

Spatial dithering to 10 bpc depth was disabled for all DCE's.

Testing on DCE-8.3 and DCE-11.2 did not show any obvious ill
effects, but a measureable precision improvement (via colorimeter)
when displaying a fp16 framebuffer to a 10 bpc DP or HDMI connected
HDR-10 monitor.

v2: enable it for all DCEs (Alex)

Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dce/dce_opp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
index 4600231da6cb..895b015b02e8 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
@@ -216,9 +216,7 @@ static void set_spatial_dither(
 	REG_UPDATE(FMT_BIT_DEPTH_CONTROL,
 		FMT_TEMPORAL_DITHER_EN, 0);
 
-	/* no 10bpc on DCE11*/
-	if (params->flags.SPATIAL_DITHER_ENABLED == 0 ||
-		params->flags.SPATIAL_DITHER_DEPTH == 2)
+	if (params->flags.SPATIAL_DITHER_ENABLED == 0)
 		return;
 
 	/* only use FRAME_COUNTER_MAX if frameRandom == 1*/
-- 
2.29.2

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/display: Allow spatial dither to 10 bpc on all DCE

[Mario Kleiner]

[-- Attachment #1.1: Type: text/plain, Size: 1540 bytes --]

Your v2 has my
Reviewed-by: Mario Kleiner <mario.kleiner.de@gmail.com>

thanks,
-mario

On Wed, Feb 17, 2021 at 11:51 PM Alex Deucher <alexdeucher@gmail.com> wrote:

> From: Mario Kleiner <mario.kleiner.de@gmail.com>
>
> Spatial dithering to 10 bpc depth was disabled for all DCE's.
>
> Testing on DCE-8.3 and DCE-11.2 did not show any obvious ill
> effects, but a measureable precision improvement (via colorimeter)
> when displaying a fp16 framebuffer to a 10 bpc DP or HDMI connected
> HDR-10 monitor.
>
> v2: enable it for all DCEs (Alex)
>
> Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
> Cc: Alex Deucher <alexdeucher@gmail.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_opp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
> b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
> index 4600231da6cb..895b015b02e8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c
> @@ -216,9 +216,7 @@ static void set_spatial_dither(
>         REG_UPDATE(FMT_BIT_DEPTH_CONTROL,
>                 FMT_TEMPORAL_DITHER_EN, 0);
>
> -       /* no 10bpc on DCE11*/
> -       if (params->flags.SPATIAL_DITHER_ENABLED == 0 ||
> -               params->flags.SPATIAL_DITHER_DEPTH == 2)
> +       if (params->flags.SPATIAL_DITHER_ENABLED == 0)
>                 return;
>
>         /* only use FRAME_COUNTER_MAX if frameRandom == 1*/
> --
> 2.29.2
>
>

[-- Attachment #1.2: Type: text/html, Size: 2397 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx