* [Buildroot] [PATCH] package/cegui: override first _CONF_OPTS instead of appending
@ 2021-02-18 17:59 Bartosz Bilas
2021-02-19 21:48 ` Yann E. MORIN
2021-02-27 17:58 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Bilas @ 2021-02-18 17:59 UTC (permalink / raw)
To: buildroot
During the package update, there was a mistake
and we appended the options to the first CONF_OPTS
variable instead of overriding it.
Fix that by removing an append-assignment.
Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
package/cegui/cegui.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
index 23919e0151..0596d6566b 100644
--- a/package/cegui/cegui.mk
+++ b/package/cegui/cegui.mk
@@ -9,7 +9,7 @@ CEGUI_SITE = $(call github,cegui,cegui,v$(CEGUI_VERSION))
CEGUI_LICENSE = MIT
CEGUI_LICENSE_FILES = COPYING
CEGUI_INSTALL_STAGING = YES
-CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
+CEGUI_CONF_OPTS = -DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
-DCEGUI_HAS_MINIZIP_RESOURCE_PROVIDER=OFF \
-DCEGUI_BUILD_RENDERER_OGRE=OFF
CEGUI_DEPENDENCIES = glm \
--
2.30.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/cegui: override first _CONF_OPTS instead of appending
2021-02-18 17:59 [Buildroot] [PATCH] package/cegui: override first _CONF_OPTS instead of appending Bartosz Bilas
@ 2021-02-19 21:48 ` Yann E. MORIN
2021-02-27 17:58 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-02-19 21:48 UTC (permalink / raw)
To: buildroot
Bartosz, All,
On 2021-02-18 18:59 +0100, Bartosz Bilas spake thusly:
> During the package update, there was a mistake
> and we appended the options to the first CONF_OPTS
> variable instead of overriding it.
> Fix that by removing an append-assignment.
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
Applied to master, thanks, with the following tweaks;
- reference the exact commit that introduce the issue
- also move the first item to its own line
Regards,
Yann E. MORIN.
> ---
> package/cegui/cegui.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
> index 23919e0151..0596d6566b 100644
> --- a/package/cegui/cegui.mk
> +++ b/package/cegui/cegui.mk
> @@ -9,7 +9,7 @@ CEGUI_SITE = $(call github,cegui,cegui,v$(CEGUI_VERSION))
> CEGUI_LICENSE = MIT
> CEGUI_LICENSE_FILES = COPYING
> CEGUI_INSTALL_STAGING = YES
> -CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
> +CEGUI_CONF_OPTS = -DCEGUI_BUILD_XMLPARSER_XERCES=OFF \
> -DCEGUI_HAS_MINIZIP_RESOURCE_PROVIDER=OFF \
> -DCEGUI_BUILD_RENDERER_OGRE=OFF
> CEGUI_DEPENDENCIES = glm \
> --
> 2.30.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/cegui: override first _CONF_OPTS instead of appending
2021-02-18 17:59 [Buildroot] [PATCH] package/cegui: override first _CONF_OPTS instead of appending Bartosz Bilas
2021-02-19 21:48 ` Yann E. MORIN
@ 2021-02-27 17:58 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-02-27 17:58 UTC (permalink / raw)
To: buildroot
>>>>> "Bartosz" == Bartosz Bilas <b.bilas@grinn-global.com> writes:
> During the package update, there was a mistake
> and we appended the options to the first CONF_OPTS
> variable instead of overriding it.
> Fix that by removing an append-assignment.
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
Committed to 2020.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-27 17:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 17:59 [Buildroot] [PATCH] package/cegui: override first _CONF_OPTS instead of appending Bartosz Bilas
2021-02-19 21:48 ` Yann E. MORIN
2021-02-27 17:58 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.