* [PATCH 1/2] iio: magnetometer: yas530: Fix return value on errorpath
@ 2021-02-15 15:30 Linus Walleij
2021-02-21 15:45 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2021-02-15 15:30 UTC (permalink / raw)
To: Jonathan Cameron, linux-iio
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Linus Walleij, kernel test robot, Dan Carpenter, Andy Shevchenko
There was a missed return variable assignment in the
default errorpath of the switch statement in yas5xx_probe().
Fix it.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/iio/magnetometer/yamaha-yas530.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
index d46f23d82b3d..cee6207d8847 100644
--- a/drivers/iio/magnetometer/yamaha-yas530.c
+++ b/drivers/iio/magnetometer/yamaha-yas530.c
@@ -887,6 +887,7 @@ static int yas5xx_probe(struct i2c_client *i2c,
strncpy(yas5xx->name, "yas532", sizeof(yas5xx->name));
break;
default:
+ ret = -ENODEV;
dev_err(dev, "unhandled device ID %02x\n", yas5xx->devid);
goto assert_reset;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] iio: magnetometer: yas530: Fix return value on errorpath
2021-02-15 15:30 [PATCH 1/2] iio: magnetometer: yas530: Fix return value on errorpath Linus Walleij
@ 2021-02-21 15:45 ` Jonathan Cameron
2021-03-01 9:00 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2021-02-21 15:45 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, kernel test robot, Dan Carpenter,
Andy Shevchenko
On Mon, 15 Feb 2021 16:30:23 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> There was a missed return variable assignment in the
> default errorpath of the switch statement in yas5xx_probe().
> Fix it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Hi Linus,
A bit of bad timing on these. I'm running behind on pull requests for
my fixes-togreg branch so it doesn't yet have the driver.
Hence I'll pick these up in a couple of weeks once that's rebased after
I send Greg a pull request.
Give me a poke if I seem to have forgotten them.
Thanks,
Jonathan
> ---
> drivers/iio/magnetometer/yamaha-yas530.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
> index d46f23d82b3d..cee6207d8847 100644
> --- a/drivers/iio/magnetometer/yamaha-yas530.c
> +++ b/drivers/iio/magnetometer/yamaha-yas530.c
> @@ -887,6 +887,7 @@ static int yas5xx_probe(struct i2c_client *i2c,
> strncpy(yas5xx->name, "yas532", sizeof(yas5xx->name));
> break;
> default:
> + ret = -ENODEV;
> dev_err(dev, "unhandled device ID %02x\n", yas5xx->devid);
> goto assert_reset;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] iio: magnetometer: yas530: Fix return value on errorpath
2021-02-21 15:45 ` Jonathan Cameron
@ 2021-03-01 9:00 ` Linus Walleij
2021-03-22 19:51 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2021-03-01 9:00 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, kernel test robot, Dan Carpenter,
Andy Shevchenko
On Sun, Feb 21, 2021 at 4:45 PM Jonathan Cameron <jic23@kernel.org> wrote:
> A bit of bad timing on these. I'm running behind on pull requests for
> my fixes-togreg branch so it doesn't yet have the driver.
>
> Hence I'll pick these up in a couple of weeks once that's rebased after
> I send Greg a pull request.
>
> Give me a poke if I seem to have forgotten them.
No problem, the fixes are not critical in any way.
I'll track them!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] iio: magnetometer: yas530: Fix return value on errorpath
2021-03-01 9:00 ` Linus Walleij
@ 2021-03-22 19:51 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2021-03-22 19:51 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, kernel test robot, Dan Carpenter,
Andy Shevchenko
On Mon, 1 Mar 2021 10:00:35 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sun, Feb 21, 2021 at 4:45 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> > A bit of bad timing on these. I'm running behind on pull requests for
> > my fixes-togreg branch so it doesn't yet have the driver.
> >
> > Hence I'll pick these up in a couple of weeks once that's rebased after
> > I send Greg a pull request.
> >
> > Give me a poke if I seem to have forgotten them.
>
> No problem, the fixes are not critical in any way.
> I'll track them!
>
Series applied to the fixes-togreg branch of iio.git.
Apologies for the delay.
Jonathan
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-22 19:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 15:30 [PATCH 1/2] iio: magnetometer: yas530: Fix return value on errorpath Linus Walleij
2021-02-21 15:45 ` Jonathan Cameron
2021-03-01 9:00 ` Linus Walleij
2021-03-22 19:51 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.