* [PATCH] ARM: mvebu: dts: omnia: enable eMMC writes
@ 2021-02-22 15:01 Petr Štetiar
2021-02-22 16:03 ` Marek Behun
0 siblings, 1 reply; 3+ messages in thread
From: Petr Štetiar @ 2021-02-22 15:01 UTC (permalink / raw)
To: u-boot
Currently it's not possible to write anything into eMMC from U-Boot, so
fix this by disabling the default write protection.
Cc: Marek Beh?n <marek.behun@nic.cz>
Signed-off-by: Petr ?tetiar <ynezz@true.cz>
---
arch/arm/dts/armada-385-turris-omnia.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/armada-385-turris-omnia.dts b/arch/arm/dts/armada-385-turris-omnia.dts
index 5511c84849ee..5bb0b9c07e48 100644
--- a/arch/arm/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/dts/armada-385-turris-omnia.dts
@@ -85,6 +85,7 @@
bus-width = <8>;
no-1-8-v;
non-removable;
+ disable-wp;
};
usb3 at f0000 {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: mvebu: dts: omnia: enable eMMC writes
2021-02-22 15:01 [PATCH] ARM: mvebu: dts: omnia: enable eMMC writes Petr Štetiar
@ 2021-02-22 16:03 ` Marek Behun
2021-02-22 16:13 ` Marek Behun
0 siblings, 1 reply; 3+ messages in thread
From: Marek Behun @ 2021-02-22 16:03 UTC (permalink / raw)
To: u-boot
On Mon, 22 Feb 2021 16:01:10 +0100
Petr ?tetiar <ynezz@true.cz> wrote:
> Currently it's not possible to write anything into eMMC from U-Boot, so
> fix this by disabling the default write protection.
>
> Cc: Marek Beh?n <marek.behun@nic.cz>
> Signed-off-by: Petr ?tetiar <ynezz@true.cz>
> ---
> arch/arm/dts/armada-385-turris-omnia.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/dts/armada-385-turris-omnia.dts b/arch/arm/dts/armada-385-turris-omnia.dts
> index 5511c84849ee..5bb0b9c07e48 100644
> --- a/arch/arm/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/dts/armada-385-turris-omnia.dts
> @@ -85,6 +85,7 @@
> bus-width = <8>;
> no-1-8-v;
> non-removable;
> + disable-wp;
> };
>
> usb3 at f0000 {
Hi,
0. subject tag should be [PATCH u-boot-marvell] and Stefan Roese should
be in To: header
1. please make subject prefix contain turris_omnia, instead of
just omnia, and instead "enable eMMC writes" use
"disable eMMC write protection"
2. do this by changing armada-385-turris-omnia-u-boot.dtsi, instead
of changing armada-385-turris-omnia.dts. This file is meant to be
same as in Linux, u-boot specific changes should be in -u-boot.dtsi
file
Marek
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: mvebu: dts: omnia: enable eMMC writes
2021-02-22 16:03 ` Marek Behun
@ 2021-02-22 16:13 ` Marek Behun
0 siblings, 0 replies; 3+ messages in thread
From: Marek Behun @ 2021-02-22 16:13 UTC (permalink / raw)
To: u-boot
On Mon, 22 Feb 2021 17:03:22 +0100
Marek Behun <marek.behun@nic.cz> wrote:
> On Mon, 22 Feb 2021 16:01:10 +0100
> Petr ?tetiar <ynezz@true.cz> wrote:
> > --- a/arch/arm/dts/armada-385-turris-omnia.dts
> > +++ b/arch/arm/dts/armada-385-turris-omnia.dts
> > @@ -85,6 +85,7 @@
> > bus-width = <8>;
> > no-1-8-v;
> > non-removable;
> > + disable-wp;
Hmm,
Linux Documentation/devicetree/bindings/mmc/mmc-controller.yaml
says this about `disable-wp`:
When set, no physical write-protect line is present. This
property should only be specified when the controller has a
dedicated write-protect detection logic. If a GPIO is always used
for the write-protect detection logic, it is sufficient to not
specify the wp-gpios property in the absence of a write-protect
line. Not used in combination with eMMC or SDIO.
There is no wp control mechanism on Omnia. No GPIO or anything. So
according to documentation, this property should not be used here, and
U-Boot is doing something wrong when it denies writes.
Marek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-22 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 15:01 [PATCH] ARM: mvebu: dts: omnia: enable eMMC writes Petr Štetiar
2021-02-22 16:03 ` Marek Behun
2021-02-22 16:13 ` Marek Behun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.