From: kernel test robot <lkp@intel.com>
To: Matthias Kaehlcke <mka@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: kbuild-all@01.org,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
Peter Chen <peter.chen@nxp.com>, Michal Simek <monstr@monstr.eu>,
Stephen Boyd <swboyd@chromium.org>,
linux-kernel@vger.kernel.org, Bastien Nocera <hadess@hadess.net>
Subject: Re: [PATCH v6 2/5] USB: misc: Add onboard_usb_hub driver
Date: Sun, 7 Mar 2021 16:52:23 +0800 [thread overview]
Message-ID: <202103071634.JfTrItam-lkp@intel.com> (raw)
In-Reply-To: <20210305113832.v6.2.I7c9a1f1d6ced41dd8310e8a03da666a32364e790@changeid>
[-- Attachment #1: Type: text/plain, Size: 3454 bytes --]
Hi Matthias,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on robh/for-next char-misc/char-misc-testing driver-core/driver-core-testing linus/master v5.12-rc2 next-20210305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210307-113654
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/63d87372b7498dc22220963eb5cd672e929b9514
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210307-113654
git checkout 63d87372b7498dc22220963eb5cd672e929b9514
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/dev_printk.h:14,
from include/linux/device.h:15,
from drivers/usb/misc/onboard_usb_hub.c:8:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/usb/misc/onboard_usb_hub.c: At top level:
>> drivers/usb/misc/onboard_usb_hub.c:273:6: error: redefinition of 'of_is_onboard_usb_hub'
273 | bool of_is_onboard_usb_hub(const struct device_node *np)
| ^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/usb/misc/onboard_usb_hub.c:21:
include/linux/usb/onboard_hub.h:9:20: note: previous definition of 'of_is_onboard_usb_hub' was here
9 | static inline bool of_is_onboard_usb_hub(const struct device_node *np)
| ^~~~~~~~~~~~~~~~~~~~~
vim +/of_is_onboard_usb_hub +273 drivers/usb/misc/onboard_usb_hub.c
272
> 273 bool of_is_onboard_usb_hub(const struct device_node *np)
274 {
275 return !!of_match_node(onboard_hub_match, np);
276 }
277 EXPORT_SYMBOL_GPL(of_is_onboard_usb_hub);
278
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 59788 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v6 2/5] USB: misc: Add onboard_usb_hub driver
Date: Sun, 07 Mar 2021 16:52:23 +0800 [thread overview]
Message-ID: <202103071634.JfTrItam-lkp@intel.com> (raw)
In-Reply-To: <20210305113832.v6.2.I7c9a1f1d6ced41dd8310e8a03da666a32364e790@changeid>
[-- Attachment #1: Type: text/plain, Size: 3524 bytes --]
Hi Matthias,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on robh/for-next char-misc/char-misc-testing driver-core/driver-core-testing linus/master v5.12-rc2 next-20210305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210307-113654
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/63d87372b7498dc22220963eb5cd672e929b9514
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210307-113654
git checkout 63d87372b7498dc22220963eb5cd672e929b9514
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/dev_printk.h:14,
from include/linux/device.h:15,
from drivers/usb/misc/onboard_usb_hub.c:8:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/usb/misc/onboard_usb_hub.c: At top level:
>> drivers/usb/misc/onboard_usb_hub.c:273:6: error: redefinition of 'of_is_onboard_usb_hub'
273 | bool of_is_onboard_usb_hub(const struct device_node *np)
| ^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/usb/misc/onboard_usb_hub.c:21:
include/linux/usb/onboard_hub.h:9:20: note: previous definition of 'of_is_onboard_usb_hub' was here
9 | static inline bool of_is_onboard_usb_hub(const struct device_node *np)
| ^~~~~~~~~~~~~~~~~~~~~
vim +/of_is_onboard_usb_hub +273 drivers/usb/misc/onboard_usb_hub.c
272
> 273 bool of_is_onboard_usb_hub(const struct device_node *np)
274 {
275 return !!of_match_node(onboard_hub_match, np);
276 }
277 EXPORT_SYMBOL_GPL(of_is_onboard_usb_hub);
278
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 59788 bytes --]
next prev parent reply other threads:[~2021-03-07 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 19:38 [PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2021-03-05 19:38 ` [PATCH v6 1/5] dt-bindings: usb: Add binding for Realtek RTS5411 hub controller Matthias Kaehlcke
2021-03-06 19:28 ` Rob Herring
2021-03-06 19:43 ` Rob Herring
2021-03-05 19:38 ` [PATCH v6 2/5] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2021-03-07 8:52 ` kernel test robot [this message]
2021-03-07 8:52 ` kernel test robot
2021-03-05 19:38 ` [PATCH v6 3/5] of/platform: Add stubs for of_platform_device_create/destroy() Matthias Kaehlcke
2021-03-08 22:32 ` Rob Herring
2021-03-09 17:20 ` Matthias Kaehlcke
2021-03-05 19:38 ` [PATCH v6 4/5] usb: host: xhci-plat: Create platform device for onboard hubs in probe() Matthias Kaehlcke
2021-03-05 19:38 ` [PATCH v6 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Matthias Kaehlcke
2021-04-05 20:18 [PATCH v6 0/5] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2021-04-05 20:18 ` [PATCH v6 2/5] " Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103071634.JfTrItam-lkp@intel.com \
--to=lkp@intel.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=monstr@monstr.eu \
--cc=peter.chen@nxp.com \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.