All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Javier González" <javier@javigon.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	kbusch@kernel.org, sagi@grimberg.me, minwoo.im.dev@gmail.com
Subject: Re: [PATCH V6 1/2] nvme: enable char device per namespace
Date: Tue, 9 Mar 2021 22:18:41 +0100	[thread overview]
Message-ID: <20210309211841.tl5pq75iihilil5o@mpHalley.localdomain> (raw)
In-Reply-To: <20210309150531.GA15052@lst.de>

On 09.03.2021 16:05, Christoph Hellwig wrote:
>On Tue, Mar 09, 2021 at 01:42:23PM +0100, Javier González wrote:
>>> - nvme_cdev_fops implements file operations that directly on a nvme_ns,
>>>   so they are path specific
>>
>> This is correct.
>>
>>> - we allow opening them even for a hidden controller
>>
>> This is also correct.
>>
>>> - there does not seem to be a char device node for ns_head at all.
>>
>> Also correct.
>>
>> We tried to keep it simple in the first iteration. Am I understanding
>> that you see necessary to have per ns_head char devices?
>
>That would be my understanding of "multipath support" for this character
>device, yes.  Especially as hiding the individual char devices for the
>hidden controllers once they are initially exposed would be an ABI break.

Ok. Will look into it for the next iteration.

WARNING: multiple messages have this Message-ID (diff)
From: "Javier González" <javier@javigon.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	kbusch@kernel.org, sagi@grimberg.me, minwoo.im.dev@gmail.com
Subject: Re: [PATCH V6 1/2] nvme: enable char device per namespace
Date: Tue, 9 Mar 2021 22:18:41 +0100	[thread overview]
Message-ID: <20210309211841.tl5pq75iihilil5o@mpHalley.localdomain> (raw)
In-Reply-To: <20210309150531.GA15052@lst.de>

On 09.03.2021 16:05, Christoph Hellwig wrote:
>On Tue, Mar 09, 2021 at 01:42:23PM +0100, Javier González wrote:
>>> - nvme_cdev_fops implements file operations that directly on a nvme_ns,
>>>   so they are path specific
>>
>> This is correct.
>>
>>> - we allow opening them even for a hidden controller
>>
>> This is also correct.
>>
>>> - there does not seem to be a char device node for ns_head at all.
>>
>> Also correct.
>>
>> We tried to keep it simple in the first iteration. Am I understanding
>> that you see necessary to have per ns_head char devices?
>
>That would be my understanding of "multipath support" for this character
>device, yes.  Especially as hiding the individual char devices for the
>hidden controllers once they are initially exposed would be an ABI break.

Ok. Will look into it for the next iteration.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-03-09 21:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01 19:24 [PATCH V6 0/2] nvme: enable char device per namespace javier
2021-03-01 19:24 ` javier
2021-03-01 19:24 ` [PATCH V6 1/2] " javier
2021-03-01 19:24   ` javier
2021-03-03  9:10   ` Christoph Hellwig
2021-03-03  9:10     ` Christoph Hellwig
2021-03-03 10:02     ` Javier González
2021-03-03 10:02       ` Javier González
2021-03-09 11:31       ` Christoph Hellwig
2021-03-09 11:31         ` Christoph Hellwig
2021-03-09 12:42         ` Javier González
2021-03-09 12:42           ` Javier González
2021-03-09 15:05           ` Christoph Hellwig
2021-03-09 15:05             ` Christoph Hellwig
2021-03-09 21:18             ` Javier González [this message]
2021-03-09 21:18               ` Javier González
2021-03-24 12:29   ` Niklas Cassel
2021-03-24 12:29     ` Niklas Cassel
2021-03-25  2:09     ` Minwoo Im
2021-03-25  2:09       ` Minwoo Im
2021-03-25  8:26       ` hch
2021-03-25  8:26         ` hch
2021-03-25  8:39         ` Niklas Cassel
2021-03-25  8:39           ` Niklas Cassel
2021-03-25  9:34           ` Minwoo Im
2021-03-25  9:34             ` Minwoo Im
2021-03-25 12:25   ` Niklas Cassel
2021-03-25 12:25     ` Niklas Cassel
2021-03-25 12:33     ` Minwoo Im
2021-03-25 12:33       ` Minwoo Im
2021-03-25 15:14     ` Keith Busch
2021-03-25 15:14       ` Keith Busch
2021-03-01 19:24 ` [PATCH V6 2/2] nvme: allow open for nvme-generic char device javier
2021-03-01 19:24   ` javier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210309211841.tl5pq75iihilil5o@mpHalley.localdomain \
    --to=javier@javigon.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=minwoo.im.dev@gmail.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.