From: Heiko Carstens <hca@linux.ibm.com> To: Li Wang <liwang@redhat.com>, Alexander Gordeev <agordeev@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Sven Schnelle <svens@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Viresh Kumar <viresh.kumar@linaro.org>, Thomas Gleixner <tglx@linutronix.de> Cc: ltp@lists.linux.it, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: [PATCH 0/3] s390 vdso fixes Date: Tue, 23 Mar 2021 22:58:16 +0100 [thread overview] Message-ID: <20210323215819.4161164-1-hca@linux.ibm.com> (raw) In-Reply-To: <YFmUrVOyX4q+8Dy9@osiris> Li Wang reported that clock_gettime(CLOCK_MONOTONIC_RAW, ...) does not work correctly on s390 via vdso. Debugging this also revealed an unrelated bug (first patch). The second patch fixes the problem: the tod clock steering parameters required by __arch_get_hw_counter() are only present within the first element of the _vdso_data array and not at all within the _timens_data array. Instead of working around this simply provide an s390 specific vdso data page which contains the tod clock steering parameters. This allows also to remove ARCH_HAS_VDSO_DATA again. Heiko Carstens (3): s390/vdso: fix tod clock steering s390/vdso: fix arch_data access for __arch_get_hw_counter() lib/vdso: remove struct arch_vdso_data from vdso data struct arch/Kconfig | 3 --- arch/s390/Kconfig | 1 - arch/s390/include/asm/vdso.h | 4 +++- arch/s390/include/asm/vdso/data.h | 13 ------------ arch/s390/include/asm/vdso/datapage.h | 17 +++++++++++++++ arch/s390/include/asm/vdso/gettimeofday.h | 11 ++++++++-- arch/s390/kernel/time.c | 5 +++-- arch/s390/kernel/vdso.c | 25 ++++++++++++++++++++--- arch/s390/kernel/vdso64/vdso64.lds.S | 3 ++- include/vdso/datapage.h | 10 --------- 10 files changed, 56 insertions(+), 36 deletions(-) delete mode 100644 arch/s390/include/asm/vdso/data.h create mode 100644 arch/s390/include/asm/vdso/datapage.h -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com> To: ltp@lists.linux.it Subject: [LTP] [PATCH 0/3] s390 vdso fixes Date: Tue, 23 Mar 2021 22:58:16 +0100 [thread overview] Message-ID: <20210323215819.4161164-1-hca@linux.ibm.com> (raw) In-Reply-To: <YFmUrVOyX4q+8Dy9@osiris> Li Wang reported that clock_gettime(CLOCK_MONOTONIC_RAW, ...) does not work correctly on s390 via vdso. Debugging this also revealed an unrelated bug (first patch). The second patch fixes the problem: the tod clock steering parameters required by __arch_get_hw_counter() are only present within the first element of the _vdso_data array and not at all within the _timens_data array. Instead of working around this simply provide an s390 specific vdso data page which contains the tod clock steering parameters. This allows also to remove ARCH_HAS_VDSO_DATA again. Heiko Carstens (3): s390/vdso: fix tod clock steering s390/vdso: fix arch_data access for __arch_get_hw_counter() lib/vdso: remove struct arch_vdso_data from vdso data struct arch/Kconfig | 3 --- arch/s390/Kconfig | 1 - arch/s390/include/asm/vdso.h | 4 +++- arch/s390/include/asm/vdso/data.h | 13 ------------ arch/s390/include/asm/vdso/datapage.h | 17 +++++++++++++++ arch/s390/include/asm/vdso/gettimeofday.h | 11 ++++++++-- arch/s390/kernel/time.c | 5 +++-- arch/s390/kernel/vdso.c | 25 ++++++++++++++++++++--- arch/s390/kernel/vdso64/vdso64.lds.S | 3 ++- include/vdso/datapage.h | 10 --------- 10 files changed, 56 insertions(+), 36 deletions(-) delete mode 100644 arch/s390/include/asm/vdso/data.h create mode 100644 arch/s390/include/asm/vdso/datapage.h -- 2.25.1
next prev parent reply other threads:[~2021-03-23 21:59 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-23 6:21 [LTP] [s390x vDSO Bug?] clock_gettime(CLOCK_MONOTONIC_RAW, ...) gets abnormal ts value Li Wang 2021-03-23 7:11 ` Heiko Carstens 2021-03-23 7:11 ` [LTP] " Heiko Carstens 2021-03-23 13:48 ` Heiko Carstens 2021-03-23 13:48 ` [LTP] " Heiko Carstens 2021-03-23 21:58 ` Heiko Carstens [this message] 2021-03-23 21:58 ` [LTP] [PATCH 0/3] s390 vdso fixes Heiko Carstens 2021-03-23 21:58 ` [PATCH 1/3] s390/vdso: fix tod clock steering Heiko Carstens 2021-03-23 21:58 ` [LTP] " Heiko Carstens 2021-03-24 9:50 ` Heiko Carstens 2021-03-24 9:50 ` [LTP] " Heiko Carstens 2021-03-23 21:58 ` [PATCH 2/3] s390/vdso: fix arch_data access for __arch_get_hw_counter() Heiko Carstens 2021-03-23 21:58 ` [LTP] " Heiko Carstens 2021-03-24 5:53 ` Heiko Carstens 2021-03-24 5:53 ` [LTP] " Heiko Carstens 2021-03-23 21:58 ` [PATCH 3/3] lib/vdso: remove struct arch_vdso_data from vdso data struct Heiko Carstens 2021-03-23 21:58 ` [LTP] " Heiko Carstens 2021-03-25 17:55 ` Thomas Gleixner 2021-03-25 17:55 ` [LTP] " Thomas Gleixner 2021-03-25 17:57 ` Thomas Gleixner 2021-03-25 17:57 ` [LTP] " Thomas Gleixner 2021-03-25 8:56 ` [LTP] [PATCH 0/3] s390 vdso fixes Li Wang 2021-03-25 12:33 ` Heiko Carstens 2021-03-25 12:33 ` [LTP] " Heiko Carstens 2021-03-25 14:11 ` Li Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210323215819.4161164-1-hca@linux.ibm.com \ --to=hca@linux.ibm.com \ --cc=agordeev@linux.ibm.com \ --cc=borntraeger@de.ibm.com \ --cc=gor@linux.ibm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=liwang@redhat.com \ --cc=ltp@lists.linux.it \ --cc=svens@linux.ibm.com \ --cc=tglx@linutronix.de \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.