From: Rob Herring <robh@kernel.org> To: Parshuram Thombare <pthombar@cadence.com> Cc: robert.foss@linaro.org, laurent.pinchart@ideasonboard.com, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, narmstrong@baylibre.com, nikhil.nd@ti.com, kishon@ti.com, sjakhade@cadence.com, mparab@cadence.com Subject: Re: [PATCH v5 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP Date: Tue, 23 Mar 2021 16:45:46 -0600 [thread overview] Message-ID: <20210323224546.GA1485576@robh.at.kernel.org> (raw) In-Reply-To: <1616146709-7227-1-git-send-email-pthombar@cadence.com> On Fri, Mar 19, 2021 at 10:38:29AM +0100, Parshuram Thombare wrote: > Add binding changes for HDCP in the MHDP8546 DPI/DP bridge binding. > > Signed-off-by: Parshuram Thombare <pthombar@cadence.com> > --- > .../display/bridge/cdns,mhdp8546.yaml | 34 ++++++++++++------- > 1 file changed, 21 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml > index 63427878715e..d571f4bb6b16 100644 > --- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml > @@ -17,8 +17,8 @@ properties: > - ti,j721e-mhdp8546 > > reg: > - minItems: 1 > - maxItems: 2 > + minItems: 2 > + maxItems: 3 1 entry was valid and now it is not? That's not a compatible change and needs an explanation at a minimum. > items: > - description: > Register block of mhdptx apb registers up to PHY mapped area (AUX_CONFIG_P). > @@ -26,13 +26,20 @@ properties: > included in the associated PHY. > - description: > Register block for DSS_EDP0_INTG_CFG_VP registers in case of TI J7 SoCs. > + - description: > + Register block of mhdptx sapb registers. > > reg-names: > - minItems: 1 > - maxItems: 2 > - items: > - - const: mhdptx > - - const: j721e-intg > + minItems: 2 > + maxItems: 3 > + oneOf: > + - items: > + - const: mhdptx > + - const: j721e-intg > + - const: mhdptx-sapb > + - items: > + - const: mhdptx > + - const: mhdptx-sapb > > clocks: > maxItems: 1 > @@ -98,15 +105,15 @@ allOf: > then: > properties: > reg: > - minItems: 2 > + minItems: 3 > reg-names: > - minItems: 2 > + minItems: 3 > else: > properties: > reg: > - maxItems: 1 > + maxItems: 2 > reg-names: > - maxItems: 1 > + maxItems: 2 > > required: > - compatible > @@ -129,8 +136,9 @@ examples: > > mhdp: dp-bridge@f0fb000000 { > compatible = "cdns,mhdp8546"; > - reg = <0xf0 0xfb000000 0x0 0x1000000>; > - reg-names = "mhdptx"; > + reg = <0xf0 0xfb000000 0x0 0x1000000>, > + <0x0 0x4f48000 0x0 0x74>; > + reg-names = "mhdptx", "mhdptx-sapb"; > clocks = <&mhdp_clock>; > phys = <&dp_phy>; > phy-names = "dpphy"; > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Parshuram Thombare <pthombar@cadence.com> Cc: devicetree@vger.kernel.org, narmstrong@baylibre.com, airlied@linux.ie, robert.foss@linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kishon@ti.com, a.hajda@samsung.com, laurent.pinchart@ideasonboard.com, sjakhade@cadence.com, nikhil.nd@ti.com, mparab@cadence.com Subject: Re: [PATCH v5 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP Date: Tue, 23 Mar 2021 16:45:46 -0600 [thread overview] Message-ID: <20210323224546.GA1485576@robh.at.kernel.org> (raw) In-Reply-To: <1616146709-7227-1-git-send-email-pthombar@cadence.com> On Fri, Mar 19, 2021 at 10:38:29AM +0100, Parshuram Thombare wrote: > Add binding changes for HDCP in the MHDP8546 DPI/DP bridge binding. > > Signed-off-by: Parshuram Thombare <pthombar@cadence.com> > --- > .../display/bridge/cdns,mhdp8546.yaml | 34 ++++++++++++------- > 1 file changed, 21 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml > index 63427878715e..d571f4bb6b16 100644 > --- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml > @@ -17,8 +17,8 @@ properties: > - ti,j721e-mhdp8546 > > reg: > - minItems: 1 > - maxItems: 2 > + minItems: 2 > + maxItems: 3 1 entry was valid and now it is not? That's not a compatible change and needs an explanation at a minimum. > items: > - description: > Register block of mhdptx apb registers up to PHY mapped area (AUX_CONFIG_P). > @@ -26,13 +26,20 @@ properties: > included in the associated PHY. > - description: > Register block for DSS_EDP0_INTG_CFG_VP registers in case of TI J7 SoCs. > + - description: > + Register block of mhdptx sapb registers. > > reg-names: > - minItems: 1 > - maxItems: 2 > - items: > - - const: mhdptx > - - const: j721e-intg > + minItems: 2 > + maxItems: 3 > + oneOf: > + - items: > + - const: mhdptx > + - const: j721e-intg > + - const: mhdptx-sapb > + - items: > + - const: mhdptx > + - const: mhdptx-sapb > > clocks: > maxItems: 1 > @@ -98,15 +105,15 @@ allOf: > then: > properties: > reg: > - minItems: 2 > + minItems: 3 > reg-names: > - minItems: 2 > + minItems: 3 > else: > properties: > reg: > - maxItems: 1 > + maxItems: 2 > reg-names: > - maxItems: 1 > + maxItems: 2 > > required: > - compatible > @@ -129,8 +136,9 @@ examples: > > mhdp: dp-bridge@f0fb000000 { > compatible = "cdns,mhdp8546"; > - reg = <0xf0 0xfb000000 0x0 0x1000000>; > - reg-names = "mhdptx"; > + reg = <0xf0 0xfb000000 0x0 0x1000000>, > + <0x0 0x4f48000 0x0 0x74>; > + reg-names = "mhdptx", "mhdptx-sapb"; > clocks = <&mhdp_clock>; > phys = <&dp_phy>; > phy-names = "dpphy"; > -- > 2.25.1 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-23 22:46 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-19 9:37 [PATCH v5 0/2] enable HDCP in Cadence MHDP bridge driver Parshuram Thombare 2021-03-19 9:37 ` Parshuram Thombare 2021-03-19 9:38 ` [PATCH v5 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP Parshuram Thombare 2021-03-19 9:38 ` Parshuram Thombare 2021-03-23 22:45 ` Rob Herring [this message] 2021-03-23 22:45 ` Rob Herring 2021-04-07 6:03 ` Parshuram Raju Thombare 2021-04-07 6:03 ` Parshuram Raju Thombare 2021-03-19 9:38 ` [PATCH v5 2/2] drm: bridge: cdns-mhdp8546: Enable HDCP Parshuram Thombare 2021-03-19 9:38 ` Parshuram Thombare
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210323224546.GA1485576@robh.at.kernel.org \ --to=robh@kernel.org \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=kishon@ti.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mparab@cadence.com \ --cc=narmstrong@baylibre.com \ --cc=nikhil.nd@ti.com \ --cc=pthombar@cadence.com \ --cc=robert.foss@linaro.org \ --cc=sjakhade@cadence.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.