From: "Pali Rohár" <pali@kernel.org>
To: Jianjun Wang <jianjun.wang@mediatek.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>, Marc Zyngier <maz@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, youlin.pei@mediatek.com,
chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com,
sin_jieyang@mediatek.com, drinkcat@chromium.org,
Rex-BC.Chen@mediatek.com, anson.chuang@mediatek.com,
Krzysztof Wilczyski <kw@linux.com>
Subject: Re: [v9,2/7] PCI: Export pci_pio_to_address() for module use
Date: Wed, 24 Mar 2021 10:09:42 +0100 [thread overview]
Message-ID: <20210324090942.kmhxnxzm7tz3ynuy@pali> (raw)
In-Reply-To: <20210324030510.29177-3-jianjun.wang@mediatek.com>
On Wednesday 24 March 2021 11:05:05 Jianjun Wang wrote:
> This interface will be used by PCI host drivers for PIO translation,
> export it to support compiling those drivers as kernel modules.
>
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> ---
> drivers/pci/pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 16a17215f633..12bba221c9f2 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pio)
>
> return address;
> }
> +EXPORT_SYMBOL(pci_pio_to_address);
Hello! I'm not sure if EXPORT_SYMBOL is correct because file has GPL-2.0
header. Should not be in this case used only EXPORT_SYMBOL_GPL? Maybe
other people would know what is correct?
>
> unsigned long __weak pci_address_to_pio(phys_addr_t address)
> {
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali@kernel.org>
To: Jianjun Wang <jianjun.wang@mediatek.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>, Marc Zyngier <maz@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, youlin.pei@mediatek.com,
chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com,
sin_jieyang@mediatek.com, drinkcat@chromium.org,
Rex-BC.Chen@mediatek.com, anson.chuang@mediatek.com,
Krzysztof Wilczyski <kw@linux.com>
Subject: Re: [v9,2/7] PCI: Export pci_pio_to_address() for module use
Date: Wed, 24 Mar 2021 10:09:42 +0100 [thread overview]
Message-ID: <20210324090942.kmhxnxzm7tz3ynuy@pali> (raw)
In-Reply-To: <20210324030510.29177-3-jianjun.wang@mediatek.com>
On Wednesday 24 March 2021 11:05:05 Jianjun Wang wrote:
> This interface will be used by PCI host drivers for PIO translation,
> export it to support compiling those drivers as kernel modules.
>
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> ---
> drivers/pci/pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 16a17215f633..12bba221c9f2 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pio)
>
> return address;
> }
> +EXPORT_SYMBOL(pci_pio_to_address);
Hello! I'm not sure if EXPORT_SYMBOL is correct because file has GPL-2.0
header. Should not be in this case used only EXPORT_SYMBOL_GPL? Maybe
other people would know what is correct?
>
> unsigned long __weak pci_address_to_pio(phys_addr_t address)
> {
> --
> 2.25.1
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali@kernel.org>
To: Jianjun Wang <jianjun.wang@mediatek.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>, Marc Zyngier <maz@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, youlin.pei@mediatek.com,
chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com,
sin_jieyang@mediatek.com, drinkcat@chromium.org,
Rex-BC.Chen@mediatek.com, anson.chuang@mediatek.com,
Krzysztof Wilczyski <kw@linux.com>
Subject: Re: [v9,2/7] PCI: Export pci_pio_to_address() for module use
Date: Wed, 24 Mar 2021 10:09:42 +0100 [thread overview]
Message-ID: <20210324090942.kmhxnxzm7tz3ynuy@pali> (raw)
In-Reply-To: <20210324030510.29177-3-jianjun.wang@mediatek.com>
On Wednesday 24 March 2021 11:05:05 Jianjun Wang wrote:
> This interface will be used by PCI host drivers for PIO translation,
> export it to support compiling those drivers as kernel modules.
>
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> ---
> drivers/pci/pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 16a17215f633..12bba221c9f2 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4052,6 +4052,7 @@ phys_addr_t pci_pio_to_address(unsigned long pio)
>
> return address;
> }
> +EXPORT_SYMBOL(pci_pio_to_address);
Hello! I'm not sure if EXPORT_SYMBOL is correct because file has GPL-2.0
header. Should not be in this case used only EXPORT_SYMBOL_GPL? Maybe
other people would know what is correct?
>
> unsigned long __weak pci_address_to_pio(phys_addr_t address)
> {
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-24 9:10 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 3:05 [v9,0/7] PCI: mediatek: Add new generation controller support Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` [v9,1/7] dt-bindings: PCI: mediatek-gen3: Add YAML schema Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` [v9,2/7] PCI: Export pci_pio_to_address() for module use Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 9:09 ` Pali Rohár [this message]
2021-03-24 9:09 ` Pali Rohár
2021-03-24 9:09 ` Pali Rohár
2021-04-13 9:53 ` Lorenzo Pieralisi
2021-04-13 9:53 ` Lorenzo Pieralisi
2021-04-13 9:53 ` Lorenzo Pieralisi
2021-04-16 19:24 ` Bjorn Helgaas
2021-04-16 19:24 ` Bjorn Helgaas
2021-04-16 19:24 ` Bjorn Helgaas
2021-03-24 3:05 ` [v9,3/7] PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192 Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-04-08 5:45 ` Jianjun Wang
2021-04-08 5:45 ` Jianjun Wang
2021-04-08 5:45 ` Jianjun Wang
2021-03-24 3:05 ` [v9,4/7] PCI: mediatek-gen3: Add INTx support Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 16:17 ` Marc Zyngier
2021-03-24 16:17 ` Marc Zyngier
2021-03-24 16:17 ` Marc Zyngier
2021-03-24 3:05 ` [v9,5/7] PCI: mediatek-gen3: Add MSI support Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 16:18 ` Marc Zyngier
2021-03-24 16:18 ` Marc Zyngier
2021-03-24 16:18 ` Marc Zyngier
2021-03-27 19:28 ` Pali Rohár
2021-03-27 19:28 ` Pali Rohár
2021-03-27 19:28 ` Pali Rohár
2021-03-27 19:44 ` Marc Zyngier
2021-03-27 19:44 ` Marc Zyngier
2021-03-27 19:44 ` Marc Zyngier
2021-03-27 20:29 ` Pali Rohár
2021-03-27 20:29 ` Pali Rohár
2021-03-27 20:29 ` Pali Rohár
2021-03-27 21:45 ` Marc Zyngier
2021-03-27 21:45 ` Marc Zyngier
2021-03-27 21:45 ` Marc Zyngier
2021-03-24 3:05 ` [v9,6/7] PCI: mediatek-gen3: Add system PM support Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` [v9,7/7] MAINTAINERS: Add Jianjun Wang as MediaTek PCI co-maintainer Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-03-24 3:05 ` Jianjun Wang
2021-04-16 19:21 ` [v9,0/7] PCI: mediatek: Add new generation controller support Bjorn Helgaas
2021-04-16 19:21 ` Bjorn Helgaas
2021-04-16 19:21 ` Bjorn Helgaas
2021-04-19 10:44 ` Lorenzo Pieralisi
2021-04-19 10:44 ` Lorenzo Pieralisi
2021-04-19 10:44 ` Lorenzo Pieralisi
2021-04-20 2:05 ` Jianjun Wang
2021-04-20 2:05 ` Jianjun Wang
2021-04-20 2:05 ` Jianjun Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324090942.kmhxnxzm7tz3ynuy@pali \
--to=pali@kernel.org \
--cc=Rex-BC.Chen@mediatek.com \
--cc=anson.chuang@mediatek.com \
--cc=bhelgaas@google.com \
--cc=chuanjia.liu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=jianjun.wang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=qizhong.cheng@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sin_jieyang@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.