[PATCH] blk-zoned: Remove the definition of blk_zone_start()

[PATCH] blk-zoned: Remove the definition of blk_zone_start()

[Bart Van Assche]

Commit e76239a3748c ("block: add a report_zones method") removed the last
blk_zone_start() call. Hence also remove the definition of this function.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 block/blk-zoned.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index c0276b42d9fb..250cb76ee615 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -52,14 +52,6 @@ const char *blk_zone_cond_str(enum blk_zone_cond zone_cond)
 }
 EXPORT_SYMBOL_GPL(blk_zone_cond_str);
 
-static inline sector_t blk_zone_start(struct request_queue *q,
-				      sector_t sector)
-{
-	sector_t zone_mask = blk_queue_zone_sectors(q) - 1;
-
-	return sector & ~zone_mask;
-}
-
 /*
  * Return true if a request is a write requests that needs zone write locking.
  */

Re: [PATCH] blk-zoned: Remove the definition of blk_zone_start()

[Himanshu Madhani]

> On Apr 6, 2021, at 3:08 PM, Bart Van Assche <bvanassche@acm.org> wrote:
> 
> Commit e76239a3748c ("block: add a report_zones method") removed the last
> blk_zone_start() call. Hence also remove the definition of this function.
> 
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> block/blk-zoned.c | 8 --------
> 1 file changed, 8 deletions(-)
> 
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index c0276b42d9fb..250cb76ee615 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -52,14 +52,6 @@ const char *blk_zone_cond_str(enum blk_zone_cond zone_cond)
> }
> EXPORT_SYMBOL_GPL(blk_zone_cond_str);
> 
> -static inline sector_t blk_zone_start(struct request_queue *q,
> -				      sector_t sector)
> -{
> -	sector_t zone_mask = blk_queue_zone_sectors(q) - 1;
> -
> -	return sector & ~zone_mask;
> -}
> -
> /*
>  * Return true if a request is a write requests that needs zone write locking.
>  */

Looks Good. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering

Re: [PATCH] blk-zoned: Remove the definition of blk_zone_start()

[Chaitanya Kulkarni]

On 4/6/21 13:08, Bart Van Assche wrote:
> Commit e76239a3748c ("block: add a report_zones method") removed the last
> blk_zone_start() call. Hence also remove the definition of this function.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

Re: [PATCH] blk-zoned: Remove the definition of blk_zone_start()

[Christoph Hellwig]

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] blk-zoned: Remove the definition of blk_zone_start()

[Jens Axboe]

On 4/6/21 2:08 PM, Bart Van Assche wrote:
> Commit e76239a3748c ("block: add a report_zones method") removed the last
> blk_zone_start() call. Hence also remove the definition of this function.

Applied, thanks.

-- 
Jens Axboe