* [PATCH] hwmon: (nct6683) remove useless function
@ 2021-04-13 6:02 Jiapeng Chong
2021-04-13 16:35 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-04-13 6:02 UTC (permalink / raw)
To: jdelvare; +Cc: linux, linux-hwmon, linux-kernel, Jiapeng Chong
Fix the following clang warning:
drivers/hwmon/nct6683.c:491:19: warning: unused function 'in_to_reg'
[-Wunused-function].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/hwmon/nct6683.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index a23047a..b886cf0 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -488,17 +488,6 @@ static inline long in_from_reg(u16 reg, u8 src)
return reg * scale;
}
-static inline u16 in_to_reg(u32 val, u8 src)
-{
- int scale = 16;
-
- if (src == MON_SRC_VCC || src == MON_SRC_VSB || src == MON_SRC_AVSB ||
- src == MON_SRC_VBAT)
- scale <<= 1;
-
- return clamp_val(DIV_ROUND_CLOSEST(val, scale), 0, 127);
-}
-
static u16 nct6683_read(struct nct6683_data *data, u16 reg)
{
int res;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (nct6683) remove useless function
2021-04-13 6:02 [PATCH] hwmon: (nct6683) remove useless function Jiapeng Chong
@ 2021-04-13 16:35 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-04-13 16:35 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: jdelvare, linux-hwmon, linux-kernel
On Tue, Apr 13, 2021 at 02:02:50PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/hwmon/nct6683.c:491:19: warning: unused function 'in_to_reg'
> [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/nct6683.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index a23047a..b886cf0 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -488,17 +488,6 @@ static inline long in_from_reg(u16 reg, u8 src)
> return reg * scale;
> }
>
> -static inline u16 in_to_reg(u32 val, u8 src)
> -{
> - int scale = 16;
> -
> - if (src == MON_SRC_VCC || src == MON_SRC_VSB || src == MON_SRC_AVSB ||
> - src == MON_SRC_VBAT)
> - scale <<= 1;
> -
> - return clamp_val(DIV_ROUND_CLOSEST(val, scale), 0, 127);
> -}
> -
> static u16 nct6683_read(struct nct6683_data *data, u16 reg)
> {
> int res;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-13 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 6:02 [PATCH] hwmon: (nct6683) remove useless function Jiapeng Chong
2021-04-13 16:35 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.